Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v1 1/2] package/libfribidi: enable host build
@ 2019-12-09 20:52 Peter Seiderer
  2019-12-09 20:52 ` [Buildroot] [PATCH v1 2/2] package/pango: needs libfribidi Peter Seiderer
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Peter Seiderer @ 2019-12-09 20:52 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/libfribidi/libfribidi.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/libfribidi/libfribidi.mk b/package/libfribidi/libfribidi.mk
index 4394623592..0e17be6db0 100644
--- a/package/libfribidi/libfribidi.mk
+++ b/package/libfribidi/libfribidi.mk
@@ -13,3 +13,4 @@ LIBFRIBIDI_INSTALL_STAGING = YES
 LIBFRIBIDI_DEPENDENCIES = host-pkgconf
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))
-- 
2.24.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH v1 2/2] package/pango: needs libfribidi
  2019-12-09 20:52 [Buildroot] [PATCH v1 1/2] package/libfribidi: enable host build Peter Seiderer
@ 2019-12-09 20:52 ` Peter Seiderer
  2019-12-12 21:34   ` Thomas Petazzoni
  2019-12-23  8:04   ` Peter Korsgaard
  2019-12-12 21:33 ` [Buildroot] [PATCH v1 1/2] package/libfribidi: enable host build Thomas Petazzoni
  2019-12-23  8:03 ` Peter Korsgaard
  2 siblings, 2 replies; 8+ messages in thread
From: Peter Seiderer @ 2019-12-09 20:52 UTC (permalink / raw)
  To: buildroot

Fixes:
  http://autobuild.buildroot.net/results/f16fda910da23dfe5f8ac1cb51f9dbcec444b516

  subprocess.CalledProcessError: Command '['git', 'clone', 'https://github.com/fribidi/fribidi.git', 'fribidi']' returned non-zero exit status 128.

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/pango/Config.in | 1 +
 package/pango/pango.mk  | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/package/pango/Config.in b/package/pango/Config.in
index cdf8b54171..e810598eef 100644
--- a/package/pango/Config.in
+++ b/package/pango/Config.in
@@ -7,6 +7,7 @@ config BR2_PACKAGE_PANGO
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # harfbuzz
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # harfbuzz
 	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBFRIBIDI
 	select BR2_PACKAGE_EXPAT
 	select BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_FONTCONFIG
diff --git a/package/pango/pango.mk b/package/pango/pango.mk
index 33e7825896..48edd18b05 100644
--- a/package/pango/pango.mk
+++ b/package/pango/pango.mk
@@ -19,6 +19,7 @@ PANGO_DEPENDENCIES = \
 	$(TARGET_NLS_DEPENDENCIES) \
 	host-pkgconf \
 	libglib2 \
+	libfribidi \
 	cairo \
 	harfbuzz \
 	fontconfig \
@@ -26,6 +27,7 @@ PANGO_DEPENDENCIES = \
 HOST_PANGO_DEPENDENCIES = \
 	host-pkgconf \
 	host-libglib2 \
+	host-libfribidi \
 	host-cairo \
 	host-harfbuzz \
 	host-fontconfig \
-- 
2.24.0

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH v1 1/2] package/libfribidi: enable host build
  2019-12-09 20:52 [Buildroot] [PATCH v1 1/2] package/libfribidi: enable host build Peter Seiderer
  2019-12-09 20:52 ` [Buildroot] [PATCH v1 2/2] package/pango: needs libfribidi Peter Seiderer
@ 2019-12-12 21:33 ` Thomas Petazzoni
  2019-12-23  8:03 ` Peter Korsgaard
  2 siblings, 0 replies; 8+ messages in thread
From: Thomas Petazzoni @ 2019-12-12 21:33 UTC (permalink / raw)
  To: buildroot

On Mon,  9 Dec 2019 21:52:23 +0100
Peter Seiderer <ps.report@gmx.net> wrote:

> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  package/libfribidi/libfribidi.mk | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH v1 2/2] package/pango: needs libfribidi
  2019-12-09 20:52 ` [Buildroot] [PATCH v1 2/2] package/pango: needs libfribidi Peter Seiderer
@ 2019-12-12 21:34   ` Thomas Petazzoni
  2019-12-12 21:39     ` Peter Seiderer
  2019-12-23  8:04   ` Peter Korsgaard
  1 sibling, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2019-12-12 21:34 UTC (permalink / raw)
  To: buildroot

On Mon,  9 Dec 2019 21:52:24 +0100
Peter Seiderer <ps.report@gmx.net> wrote:

> Fixes:
>   http://autobuild.buildroot.net/results/f16fda910da23dfe5f8ac1cb51f9dbcec444b516
> 
>   subprocess.CalledProcessError: Command '['git', 'clone', 'https://github.com/fribidi/fribidi.git', 'fribidi']' returned non-zero exit status 128.
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

This commit title really was too short, especially we like to
understand since when this problem is occurring. So I've added the
following paragraph:

    Since commit 5cce413eb11ac75f5c48ed351896c5d1c33961d5 ("package/pango:
    bump to version 1.44.6"), pango needs libfribidi. Through the Meson
    subprojects mechanism, it tries to download it by itself if not
    available. But in Buildroot, we definitely want to use the separate
    libfribidi package, so let's add it as a dependency of pango.

A side question is: is here a way to tell Meson to never ever download
subprojects by itself, and instead bail out loudly ?

I've applied with the improved commit log. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH v1 2/2] package/pango: needs libfribidi
  2019-12-12 21:34   ` Thomas Petazzoni
@ 2019-12-12 21:39     ` Peter Seiderer
  2019-12-23 15:30       ` Peter Seiderer
  0 siblings, 1 reply; 8+ messages in thread
From: Peter Seiderer @ 2019-12-12 21:39 UTC (permalink / raw)
  To: buildroot

Hello Thomas,

On Thu, 12 Dec 2019 22:34:48 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> On Mon,  9 Dec 2019 21:52:24 +0100
> Peter Seiderer <ps.report@gmx.net> wrote:
>
> > Fixes:
> >   http://autobuild.buildroot.net/results/f16fda910da23dfe5f8ac1cb51f9dbcec444b516
> >
> >   subprocess.CalledProcessError: Command '['git', 'clone', 'https://github.com/fribidi/fribidi.git', 'fribidi']' returned non-zero exit status 128.
> >
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>
> This commit title really was too short, especially we like to
> understand since when this problem is occurring. So I've added the
> following paragraph:
>
>     Since commit 5cce413eb11ac75f5c48ed351896c5d1c33961d5 ("package/pango:
>     bump to version 1.44.6"), pango needs libfribidi. Through the Meson
>     subprojects mechanism, it tries to download it by itself if not
>     available. But in Buildroot, we definitely want to use the separate
>     libfribidi package, so let's add it as a dependency of pango.

+2

>
> A side question is: is here a way to tell Meson to never ever download
> subprojects by itself, and instead bail out loudly ?

Will investigate...

>
> I've applied with the improved commit log. Thanks!

Thanks.

Regards,
Peter

>
> Thomas

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH v1 1/2] package/libfribidi: enable host build
  2019-12-09 20:52 [Buildroot] [PATCH v1 1/2] package/libfribidi: enable host build Peter Seiderer
  2019-12-09 20:52 ` [Buildroot] [PATCH v1 2/2] package/pango: needs libfribidi Peter Seiderer
  2019-12-12 21:33 ` [Buildroot] [PATCH v1 1/2] package/libfribidi: enable host build Thomas Petazzoni
@ 2019-12-23  8:03 ` Peter Korsgaard
  2 siblings, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2019-12-23  8:03 UTC (permalink / raw)
  To: buildroot

>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Committed to 2019.11.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH v1 2/2] package/pango: needs libfribidi
  2019-12-09 20:52 ` [Buildroot] [PATCH v1 2/2] package/pango: needs libfribidi Peter Seiderer
  2019-12-12 21:34   ` Thomas Petazzoni
@ 2019-12-23  8:04   ` Peter Korsgaard
  1 sibling, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2019-12-23  8:04 UTC (permalink / raw)
  To: buildroot

>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > Fixes:
 >   http://autobuild.buildroot.net/results/f16fda910da23dfe5f8ac1cb51f9dbcec444b516

 >   subprocess.CalledProcessError: Command '['git', 'clone', 'https://github.com/fribidi/fribidi.git', 'fribidi']' returned non-zero exit status 128.

 > Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Committed to 2019.11.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH v1 2/2] package/pango: needs libfribidi
  2019-12-12 21:39     ` Peter Seiderer
@ 2019-12-23 15:30       ` Peter Seiderer
  0 siblings, 0 replies; 8+ messages in thread
From: Peter Seiderer @ 2019-12-23 15:30 UTC (permalink / raw)
  To: buildroot

Hello Thomas,

> >
> > A side question is: is here a way to tell Meson to never ever download
> > subprojects by itself, and instead bail out loudly ?
>
> Will investigate...
>

According to the meson documentation ([1]) the options

	--wrap-mode=nodownload
	--wrap-mode=nofallback
	--wrap-mode=forcefallback

are available, I think one of the first two would be
useful (the second as default, the fist-one for special
cases)?

Regards,
Peter

[1] https://mesonbuild.com/Subprojects.html#commandline-options

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-12-23 15:30 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-09 20:52 [Buildroot] [PATCH v1 1/2] package/libfribidi: enable host build Peter Seiderer
2019-12-09 20:52 ` [Buildroot] [PATCH v1 2/2] package/pango: needs libfribidi Peter Seiderer
2019-12-12 21:34   ` Thomas Petazzoni
2019-12-12 21:39     ` Peter Seiderer
2019-12-23 15:30       ` Peter Seiderer
2019-12-23  8:04   ` Peter Korsgaard
2019-12-12 21:33 ` [Buildroot] [PATCH v1 1/2] package/libfribidi: enable host build Thomas Petazzoni
2019-12-23  8:03 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox