Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/lua-msgpack-native: fix build with moonjit
@ 2019-12-10 17:40 Francois Perrad
  2019-12-18 22:15 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Francois Perrad @ 2019-12-10 17:40 UTC (permalink / raw)
  To: buildroot

compatibility with Lua 5.0 was removed in LuaJIT/moonjit 2.1.x
(Lua 5.1.x and LuaJIT 2.0.x have this compatibility)

see http://autobuild.buildroot.org/results/4e4/4e428df01def186cb034a1774f6c00e2e7c9468c/build-end.log

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/lua-msgpack-native/lua-msgpack-native.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/lua-msgpack-native/lua-msgpack-native.mk b/package/lua-msgpack-native/lua-msgpack-native.mk
index acd3a0e1c..b3ca7aef4 100644
--- a/package/lua-msgpack-native/lua-msgpack-native.mk
+++ b/package/lua-msgpack-native/lua-msgpack-native.mk
@@ -11,7 +11,7 @@ LUA_MSGPACK_NATIVE_LICENSE = Apache-2.0
 LUA_MSGPACK_NATIVE_LICENSE_FILES = LICENSE.txt
 
 define LUA_MSGPACK_NATIVE_BUILD_CMDS
-	$(TARGET_CC) $(TARGET_CFLAGS) -fPIC -shared -o $(@D)/msgpack.so $(@D)/mp.c
+	$(TARGET_CC) $(TARGET_CFLAGS) -DluaL_reg=luaL_Reg -fPIC -shared -o $(@D)/msgpack.so $(@D)/mp.c
 endef
 
 define LUA_MSGPACK_NATIVE_INSTALL_TARGET_CMDS
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] package/lua-msgpack-native: fix build with moonjit
  2019-12-10 17:40 [Buildroot] [PATCH] package/lua-msgpack-native: fix build with moonjit Francois Perrad
@ 2019-12-18 22:15 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2019-12-18 22:15 UTC (permalink / raw)
  To: buildroot

On Tue, 10 Dec 2019 18:40:04 +0100
Francois Perrad <fperrad@gmail.com> wrote:

> compatibility with Lua 5.0 was removed in LuaJIT/moonjit 2.1.x
> (Lua 5.1.x and LuaJIT 2.0.x have this compatibility)
> 
> see http://autobuild.buildroot.org/results/4e4/4e428df01def186cb034a1774f6c00e2e7c9468c/build-end.log

This should have been:

Fixes:

  http://autobuild.buildroot.org/results/4e428df01def186cb034a1774f6c00e2e7c9468c/

> 
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  package/lua-msgpack-native/lua-msgpack-native.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/lua-msgpack-native/lua-msgpack-native.mk b/package/lua-msgpack-native/lua-msgpack-native.mk
> index acd3a0e1c..b3ca7aef4 100644
> --- a/package/lua-msgpack-native/lua-msgpack-native.mk
> +++ b/package/lua-msgpack-native/lua-msgpack-native.mk
> @@ -11,7 +11,7 @@ LUA_MSGPACK_NATIVE_LICENSE = Apache-2.0
>  LUA_MSGPACK_NATIVE_LICENSE_FILES = LICENSE.txt
>  
>  define LUA_MSGPACK_NATIVE_BUILD_CMDS
> -	$(TARGET_CC) $(TARGET_CFLAGS) -fPIC -shared -o $(@D)/msgpack.so $(@D)/mp.c
> +	$(TARGET_CC) $(TARGET_CFLAGS) -DluaL_reg=luaL_Reg -fPIC -shared -o $(@D)/msgpack.so $(@D)/mp.c

I've added a comment in the .mk file to explain this, as it is a bit
weird, and then I've applied to master.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-18 22:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-10 17:40 [Buildroot] [PATCH] package/lua-msgpack-native: fix build with moonjit Francois Perrad
2019-12-18 22:15 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox