* [Buildroot] [PATCH 1/1] package/python-pyqt5: select BR2_PACKAGE_QT5BASE_GUI
@ 2019-12-30 21:48 Fabrice Fontaine
2019-12-30 22:42 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Fabrice Fontaine @ 2019-12-30 21:48 UTC (permalink / raw)
To: buildroot
gui is a mandatory dependency of python-pyqt5 as "-gui" option is used
internally by the configure.py script
Fixes:
- http://autobuild.buildroot.org/results/ea0c8db44aacf1ce76f75e8288969fe5da6690d9
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/python-pyqt5/Config.in | 1 +
package/python-pyqt5/python-pyqt5.mk | 3 +--
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/python-pyqt5/Config.in b/package/python-pyqt5/Config.in
index 20ac988703..9fa7676f98 100644
--- a/package/python-pyqt5/Config.in
+++ b/package/python-pyqt5/Config.in
@@ -5,6 +5,7 @@ config BR2_PACKAGE_PYTHON_PYQT5
bool "python-pyqt5"
depends on BR2_PACKAGE_QT5
select BR2_PACKAGE_PYTHON_SIP
+ select BR2_PACKAGE_QT5BASE_GUI
help
Python bindings for Qt 5
diff --git a/package/python-pyqt5/python-pyqt5.mk b/package/python-pyqt5/python-pyqt5.mk
index b6d559cd5b..260a93af9c 100644
--- a/package/python-pyqt5/python-pyqt5.mk
+++ b/package/python-pyqt5/python-pyqt5.mk
@@ -12,9 +12,8 @@ PYTHON_PYQT5_LICENSE_FILES = LICENSE
PYTHON_PYQT5_DEPENDENCIES = python-sip host-python-sip qt5base
PYTHON_PYQT5_MODULES = \
- QtCore \
+ QtCore QtGui \
$(if $(BR2_PACKAGE_QT5BASE_DBUS),QtDBus) \
- $(if $(BR2_PACKAGE_QT5BASE_GUI),QtGui) \
$(if $(BR2_PACKAGE_QT5BASE_NETWORK),QtNetwork) \
$(if $(BR2_PACKAGE_QT5BASE_OPENGL_LIB),QtOpenGL) \
$(if $(BR2_PACKAGE_QT5BASE_PRINTSUPPORT),QtPrintSupport) \
--
2.24.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/python-pyqt5: select BR2_PACKAGE_QT5BASE_GUI
2019-12-30 21:48 [Buildroot] [PATCH 1/1] package/python-pyqt5: select BR2_PACKAGE_QT5BASE_GUI Fabrice Fontaine
@ 2019-12-30 22:42 ` Thomas Petazzoni
2020-01-12 22:06 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2019-12-30 22:42 UTC (permalink / raw)
To: buildroot
On Mon, 30 Dec 2019 22:48:42 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> gui is a mandatory dependency of python-pyqt5 as "-gui" option is used
> internally by the configure.py script
>
> Fixes:
> - http://autobuild.buildroot.org/results/ea0c8db44aacf1ce76f75e8288969fe5da6690d9
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
This seems weird. Are you sure? Could you talk with upstream about this?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/python-pyqt5: select BR2_PACKAGE_QT5BASE_GUI
2019-12-30 22:42 ` Thomas Petazzoni
@ 2020-01-12 22:06 ` Thomas Petazzoni
2020-01-12 22:23 ` Fabrice Fontaine
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2020-01-12 22:06 UTC (permalink / raw)
To: buildroot
Fabrice,
Any comment on the below question ?
Thanks!
Thomas
On Mon, 30 Dec 2019 23:42:59 +0100
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> On Mon, 30 Dec 2019 22:48:42 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > gui is a mandatory dependency of python-pyqt5 as "-gui" option is used
> > internally by the configure.py script
> >
> > Fixes:
> > - http://autobuild.buildroot.org/results/ea0c8db44aacf1ce76f75e8288969fe5da6690d9
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> This seems weird. Are you sure? Could you talk with upstream about this?
>
> Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/python-pyqt5: select BR2_PACKAGE_QT5BASE_GUI
2020-01-12 22:06 ` Thomas Petazzoni
@ 2020-01-12 22:23 ` Fabrice Fontaine
2020-01-23 22:39 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Fabrice Fontaine @ 2020-01-12 22:23 UTC (permalink / raw)
To: buildroot
Le dim. 12 janv. 2020 ? 23:06, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> Fabrice,
>
> Any comment on the below question ?
This is indeed "strange" but configure.py is really passing -gui
unconditionally for QtCore (as well as QtDbus, QtNetwork ...).
I didn't try to get in touch with upstream yet however I would assume
that pyqt really expects that GUI is enabled on Qt.
Here is an extract of their whitepaper
(https://www.riverbankcomputing.com/static/Docs/PyQt4-whitepaper/pyqt-whitepaper-a4.pdf):
PyQt, provides an ideal combination for rapidly creating powerful and
flexible GUI applications.
>
> Thanks!
>
> Thomas
>
> On Mon, 30 Dec 2019 23:42:59 +0100
> Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
>
> > On Mon, 30 Dec 2019 22:48:42 +0100
> > Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> >
> > > gui is a mandatory dependency of python-pyqt5 as "-gui" option is used
> > > internally by the configure.py script
> > >
> > > Fixes:
> > > - http://autobuild.buildroot.org/results/ea0c8db44aacf1ce76f75e8288969fe5da6690d9
> > >
> > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> >
> > This seems weird. Are you sure? Could you talk with upstream about this?
> >
> > Thomas
>
>
>
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/python-pyqt5: select BR2_PACKAGE_QT5BASE_GUI
2020-01-12 22:23 ` Fabrice Fontaine
@ 2020-01-23 22:39 ` Arnout Vandecappelle
2020-03-07 8:06 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2020-01-23 22:39 UTC (permalink / raw)
To: buildroot
On 12/01/2020 23:23, Fabrice Fontaine wrote:
> Le dim. 12 janv. 2020 ? 23:06, Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> a ?crit :
>>
>> Fabrice,
>>
>> Any comment on the below question ?
> This is indeed "strange" but configure.py is really passing -gui
> unconditionally for QtCore (as well as QtDbus, QtNetwork ...).
I've added a bit of this explanation to the commit message and applied to
master, thanks!
Regards,
Arnout
> I didn't try to get in touch with upstream yet however I would assume
> that pyqt really expects that GUI is enabled on Qt.
> Here is an extract of their whitepaper
> (https://www.riverbankcomputing.com/static/Docs/PyQt4-whitepaper/pyqt-whitepaper-a4.pdf):
> PyQt, provides an ideal combination for rapidly creating powerful and
> flexible GUI applications.
>>
>> Thanks!
>>
>> Thomas
>>
>> On Mon, 30 Dec 2019 23:42:59 +0100
>> Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
>>
>>> On Mon, 30 Dec 2019 22:48:42 +0100
>>> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>>>
>>>> gui is a mandatory dependency of python-pyqt5 as "-gui" option is used
>>>> internally by the configure.py script
>>>>
>>>> Fixes:
>>>> - http://autobuild.buildroot.org/results/ea0c8db44aacf1ce76f75e8288969fe5da6690d9
>>>>
>>>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>>>
>>> This seems weird. Are you sure? Could you talk with upstream about this?
>>>
>>> Thomas
>>
>>
>>
>> --
>> Thomas Petazzoni, CTO, Bootlin
>> Embedded Linux and Kernel engineering
>> https://bootlin.com
> Best Regards,
>
> Fabrice
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/python-pyqt5: select BR2_PACKAGE_QT5BASE_GUI
2020-01-23 22:39 ` Arnout Vandecappelle
@ 2020-03-07 8:06 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2020-03-07 8:06 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
> On 12/01/2020 23:23, Fabrice Fontaine wrote:
>> Le dim. 12 janv. 2020 ? 23:06, Thomas Petazzoni
>> <thomas.petazzoni@bootlin.com> a ?crit :
>>>
>>> Fabrice,
>>>
>>> Any comment on the below question ?
>> This is indeed "strange" but configure.py is really passing -gui
>> unconditionally for QtCore (as well as QtDbus, QtNetwork ...).
> I've added a bit of this explanation to the commit message and applied to
> master, thanks!
Committed to 2019.02.x and 2019.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-07 8:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-30 21:48 [Buildroot] [PATCH 1/1] package/python-pyqt5: select BR2_PACKAGE_QT5BASE_GUI Fabrice Fontaine
2019-12-30 22:42 ` Thomas Petazzoni
2020-01-12 22:06 ` Thomas Petazzoni
2020-01-12 22:23 ` Fabrice Fontaine
2020-01-23 22:39 ` Arnout Vandecappelle
2020-03-07 8:06 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox