[Buildroot] [PATCH] package/libnss: fix build failure due to HW PPC Crypto bug

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

On Wed, 1 Jan 2020 00:44:09 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> >> So if we stick with nss-3.48, the package should likely depend on
> >> BR2_TOOLCHAIN_GCC_AT_LEAST_8.  
> 
> This ^^^ is too restrictive, but...
> 
> > Or don't utilize PPC hardware accelerated instructions by undefining
> > USE_PPC_CRYPTO... which is probably the saner option :-). This would
> > give the semblance that the compile worked as expected since the hashing
> > function will now be available, but Thomas' concern re CPU_ARCH and the
> > future inclusion of ppc specific source is still valid.  
> 
> ...this is a good idea. So with gcc version < 8.x let's disable 
> USE_PPC_CRYPTO and with gcc version >= 8.x let's enable it only if 
> LITTLE_ENDIAN. So at this point I would change my upstream patch to do 
> that in NSS, since there's already a gcc version check but only against 
> version 5.x(>=) that instead needs to be >= 8.x.

As I said in my previous e-mail, I also don't see how it can work with
the current OS_TEST value that we pass in libnss.mk, which is never set
to ppc64 or ppc64le as the libnss build system expects.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com