[Buildroot] [PATCH 1/1] package/samba4: AD DC needs python3

[Buildroot] [PATCH 1/1] package/samba4: AD DC needs python3

[Fabrice Fontaine]

python3 is mandatory since version 4.11 and
https://gitlab.com/samba-team/samba/commit/63d20d7822ead1626f7cb41fdbae6c9300893314

As a result, AD DC needs python3

Fixes:
 - http://autobuild.buildroot.org/results/7af629b8acc92c81e006b1b87ae9a6fd461cf96d

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/samba4/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/samba4/Config.in b/package/samba4/Config.in
index a6997c13eb..493c79f3f8 100644
--- a/package/samba4/Config.in
+++ b/package/samba4/Config.in
@@ -31,10 +31,14 @@ if BR2_PACKAGE_SAMBA4
 
 config BR2_PACKAGE_SAMBA4_AD_DC
 	bool "AD DC"
+	depends on BR2_PACKAGE_PYTHON3
 	select BR2_PACKAGE_JANSSON
 	help
 	  Enable Active Directory Domain Controller functionality.
 
+comment "AD DC depends on python3"
+	depends on !BR2_PACKAGE_PYTHON3
+
 config BR2_PACKAGE_SAMBA4_ADS
 	bool "ADS"
 	select BR2_PACKAGE_OPENLDAP
-- 
2.24.0

[Buildroot] [PATCH 1/1] package/samba4: AD DC needs python3

[Thomas Petazzoni]

On Wed,  1 Jan 2020 18:56:15 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> python3 is mandatory since version 4.11 and
> https://gitlab.com/samba-team/samba/commit/63d20d7822ead1626f7cb41fdbae6c9300893314
> 
> As a result, AD DC needs python3
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/7af629b8acc92c81e006b1b87ae9a6fd461cf96d
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/samba4/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master, thanks. Could you have a look at the discussion we
had at
http://lists.busybox.net/pipermail/buildroot/2019-November/266145.html
on the topic of Samba4 use of Python, and see if we have now taken into
account all what Trent Piepho reported back then ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com