* [Buildroot] [PATCH] lua-codegen: new package
@ 2019-09-05 8:08 Francois Perrad
2019-12-08 15:12 ` François Perrad
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Francois Perrad @ 2019-09-05 8:08 UTC (permalink / raw)
To: buildroot
Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
package/Config.in | 1 +
package/lua-codegen/Config.in | 6 ++++++
package/lua-codegen/lua-codegen.hash | 3 +++
package/lua-codegen/lua-codegen.mk | 12 ++++++++++++
4 files changed, 22 insertions(+)
create mode 100644 package/lua-codegen/Config.in
create mode 100644 package/lua-codegen/lua-codegen.hash
create mode 100644 package/lua-codegen/lua-codegen.mk
diff --git a/package/Config.in b/package/Config.in
index 710ed12be..8b5719d46 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -617,6 +617,7 @@ menu "Lua libraries/modules"
source "package/lua-cjson/Config.in"
source "package/lua-coat/Config.in"
source "package/lua-coatpersistent/Config.in"
+ source "package/lua-codegen/Config.in"
source "package/lua-compat53/Config.in"
source "package/lua-cqueues/Config.in"
source "package/lua-csnappy/Config.in"
diff --git a/package/lua-codegen/Config.in b/package/lua-codegen/Config.in
new file mode 100644
index 000000000..bc0ca3d14
--- /dev/null
+++ b/package/lua-codegen/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LUA_CODEGEN
+ bool "lua-codegen"
+ help
+ a template engine.
+
+ https://fperrad.frama.io/lua-CodeGen
diff --git a/package/lua-codegen/lua-codegen.hash b/package/lua-codegen/lua-codegen.hash
new file mode 100644
index 000000000..0b49a5a78
--- /dev/null
+++ b/package/lua-codegen/lua-codegen.hash
@@ -0,0 +1,3 @@
+# computed by luarocks/buildroot
+sha256 c09126d7f5d0fa9c867ee9108eb5961dab111320ee35e5f842317f6058e922ec lua-codegen-0.3.3-1.src.rock
+sha256 f09265c450c3a59558ecc552ea4ba61e5a74dec995738eec545d121718833a80 lua-CodeGen-0.3.3/COPYRIGHT
diff --git a/package/lua-codegen/lua-codegen.mk b/package/lua-codegen/lua-codegen.mk
new file mode 100644
index 000000000..caa9008e5
--- /dev/null
+++ b/package/lua-codegen/lua-codegen.mk
@@ -0,0 +1,12 @@
+################################################################################
+#
+# lua-codegen
+#
+################################################################################
+
+LUA_CODEGEN_VERSION = 0.3.3-1
+LUA_CODEGEN_NAME_UPSTREAM = lua-CodeGen
+LUA_CODEGEN_LICENSE = MIT
+LUA_CODEGEN_LICENSE_FILES = $(LUA_CODEGEN_SUBDIR)/COPYRIGHT
+
+$(eval $(luarocks-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] lua-codegen: new package
2019-09-05 8:08 [Buildroot] [PATCH] lua-codegen: new package Francois Perrad
@ 2019-12-08 15:12 ` François Perrad
2019-12-24 17:53 ` Giulio Benetti
2020-01-06 20:52 ` Thomas Petazzoni
2 siblings, 0 replies; 4+ messages in thread
From: François Perrad @ 2019-12-08 15:12 UTC (permalink / raw)
To: buildroot
ping
Le jeu. 5 sept. 2019 ? 10:08, Francois Perrad <fperrad@gmail.com> a ?crit :
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> package/Config.in | 1 +
> package/lua-codegen/Config.in | 6 ++++++
> package/lua-codegen/lua-codegen.hash | 3 +++
> package/lua-codegen/lua-codegen.mk | 12 ++++++++++++
> 4 files changed, 22 insertions(+)
> create mode 100644 package/lua-codegen/Config.in
> create mode 100644 package/lua-codegen/lua-codegen.hash
> create mode 100644 package/lua-codegen/lua-codegen.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 710ed12be..8b5719d46 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -617,6 +617,7 @@ menu "Lua libraries/modules"
> source "package/lua-cjson/Config.in"
> source "package/lua-coat/Config.in"
> source "package/lua-coatpersistent/Config.in"
> + source "package/lua-codegen/Config.in"
> source "package/lua-compat53/Config.in"
> source "package/lua-cqueues/Config.in"
> source "package/lua-csnappy/Config.in"
> diff --git a/package/lua-codegen/Config.in b/package/lua-codegen/Config.in
> new file mode 100644
> index 000000000..bc0ca3d14
> --- /dev/null
> +++ b/package/lua-codegen/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_LUA_CODEGEN
> + bool "lua-codegen"
> + help
> + a template engine.
> +
> + https://fperrad.frama.io/lua-CodeGen
> diff --git a/package/lua-codegen/lua-codegen.hash
> b/package/lua-codegen/lua-codegen.hash
> new file mode 100644
> index 000000000..0b49a5a78
> --- /dev/null
> +++ b/package/lua-codegen/lua-codegen.hash
> @@ -0,0 +1,3 @@
> +# computed by luarocks/buildroot
> +sha256 c09126d7f5d0fa9c867ee9108eb5961dab111320ee35e5f842317f6058e922ec
> lua-codegen-0.3.3-1.src.rock
> +sha256 f09265c450c3a59558ecc552ea4ba61e5a74dec995738eec545d121718833a80
> lua-CodeGen-0.3.3/COPYRIGHT
> diff --git a/package/lua-codegen/lua-codegen.mk b/package/lua-codegen/
> lua-codegen.mk
> new file mode 100644
> index 000000000..caa9008e5
> --- /dev/null
> +++ b/package/lua-codegen/lua-codegen.mk
> @@ -0,0 +1,12 @@
>
> +################################################################################
> +#
> +# lua-codegen
> +#
>
> +################################################################################
> +
> +LUA_CODEGEN_VERSION = 0.3.3-1
> +LUA_CODEGEN_NAME_UPSTREAM = lua-CodeGen
> +LUA_CODEGEN_LICENSE = MIT
> +LUA_CODEGEN_LICENSE_FILES = $(LUA_CODEGEN_SUBDIR)/COPYRIGHT
> +
> +$(eval $(luarocks-package))
> --
> 2.20.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191208/b3ede575/attachment.html>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] lua-codegen: new package
2019-09-05 8:08 [Buildroot] [PATCH] lua-codegen: new package Francois Perrad
2019-12-08 15:12 ` François Perrad
@ 2019-12-24 17:53 ` Giulio Benetti
2020-01-06 20:52 ` Thomas Petazzoni
2 siblings, 0 replies; 4+ messages in thread
From: Giulio Benetti @ 2019-12-24 17:53 UTC (permalink / raw)
To: buildroot
Hi Francois,
please use "package/lua-codegen: new package" as first line commit log.
And please provide a little description of the package in commit log.
On 9/5/19 10:08 AM, Francois Perrad wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> package/Config.in | 1 +
> package/lua-codegen/Config.in | 6 ++++++
> package/lua-codegen/lua-codegen.hash | 3 +++
> package/lua-codegen/lua-codegen.mk | 12 ++++++++++++
> 4 files changed, 22 insertions(+)
> create mode 100644 package/lua-codegen/Config.in
> create mode 100644 package/lua-codegen/lua-codegen.hash
> create mode 100644 package/lua-codegen/lua-codegen.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 710ed12be..8b5719d46 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -617,6 +617,7 @@ menu "Lua libraries/modules"
> source "package/lua-cjson/Config.in"
> source "package/lua-coat/Config.in"
> source "package/lua-coatpersistent/Config.in"
> + source "package/lua-codegen/Config.in"
> source "package/lua-compat53/Config.in"
> source "package/lua-cqueues/Config.in"
> source "package/lua-csnappy/Config.in"
> diff --git a/package/lua-codegen/Config.in b/package/lua-codegen/Config.in
> new file mode 100644
> index 000000000..bc0ca3d14
> --- /dev/null
> +++ b/package/lua-codegen/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_LUA_CODEGEN
> + bool "lua-codegen"
> + help
> + a template engine.
Here let's use capital "A template engine", but please improve a little
bit the description above.
> +
> + https://fperrad.frama.io/lua-CodeGen
> diff --git a/package/lua-codegen/lua-codegen.hash b/package/lua-codegen/lua-codegen.hash
> new file mode 100644
> index 000000000..0b49a5a78
> --- /dev/null
> +++ b/package/lua-codegen/lua-codegen.hash
> @@ -0,0 +1,3 @@
> +# computed by luarocks/buildroot
> +sha256 c09126d7f5d0fa9c867ee9108eb5961dab111320ee35e5f842317f6058e922ec lua-codegen-0.3.3-1.src.rock
> +sha256 f09265c450c3a59558ecc552ea4ba61e5a74dec995738eec545d121718833a80 lua-CodeGen-0.3.3/COPYRIGHT
> diff --git a/package/lua-codegen/lua-codegen.mk b/package/lua-codegen/lua-codegen.mk
> new file mode 100644
> index 000000000..caa9008e5
> --- /dev/null
> +++ b/package/lua-codegen/lua-codegen.mk
> @@ -0,0 +1,12 @@
> +################################################################################
> +#
> +# lua-codegen
> +#
> +################################################################################
> +
> +LUA_CODEGEN_VERSION = 0.3.3-1
> +LUA_CODEGEN_NAME_UPSTREAM = lua-CodeGen
> +LUA_CODEGEN_LICENSE = MIT
> +LUA_CODEGEN_LICENSE_FILES = $(LUA_CODEGEN_SUBDIR)/COPYRIGHT
> +
> +$(eval $(luarocks-package))
>
For the rest, it builds correctly and it looks ok to me, so:
Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Maybe it should be enough if you provide those 2 little descriptions
answering inline without submit a v2.
Best regards
--
Giulio Benetti
Benetti Engineering sas
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] lua-codegen: new package
2019-09-05 8:08 [Buildroot] [PATCH] lua-codegen: new package Francois Perrad
2019-12-08 15:12 ` François Perrad
2019-12-24 17:53 ` Giulio Benetti
@ 2020-01-06 20:52 ` Thomas Petazzoni
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2020-01-06 20:52 UTC (permalink / raw)
To: buildroot
Hello Fran?ois,
On Thu, 5 Sep 2019 10:08:39 +0200
Francois Perrad <fperrad@gmail.com> wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> package/Config.in | 1 +
> package/lua-codegen/Config.in | 6 ++++++
> package/lua-codegen/lua-codegen.hash | 3 +++
> package/lua-codegen/lua-codegen.mk | 12 ++++++++++++
> 4 files changed, 22 insertions(+)
> create mode 100644 package/lua-codegen/Config.in
> create mode 100644 package/lua-codegen/lua-codegen.hash
> create mode 100644 package/lua-codegen/lua-codegen.mk
Thanks, I've applied. However, I'd like to point out that the link
fperrad.github.com/lua-CodeGen from
https://luarocks.org/modules/fperrad/lua-codegen is broken, and the
link http://github.com/fperrad/lua-CodeGen/releases/ from
https://fperrad.frama.io/lua-CodeGen/ is also broken.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-06 20:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-05 8:08 [Buildroot] [PATCH] lua-codegen: new package Francois Perrad
2019-12-08 15:12 ` François Perrad
2019-12-24 17:53 ` Giulio Benetti
2020-01-06 20:52 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox