From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/bustle: select dbus instead of depending on it
Date: Wed, 8 Jan 2020 09:35:44 +0100 [thread overview]
Message-ID: <20200108093544.3288c09d@windsurf> (raw)
In-Reply-To: <20200104184513.2369600-1-fontaine.fabrice@gmail.com>
On Sat, 4 Jan 2020 19:45:12 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
I agree that in general we prefer to use "select" for non-obvious
dependencies. But here, the dependency is obvious, and in fact "bustle"
is completely useless if you don't use D-Bus: you will only want to
even consider enabling bustle if you're already using D-Bus, and want
to debug some stuff.
So I think it is a case where a "depends on" dependency makes a lot of
sense, very much like Python modules all "depends on" the Python
interpreter being present, rather than selecting it.
So I've mark the patch as Rejected in patchwork.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-01-08 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-04 18:45 [Buildroot] [PATCH 1/2] package/bustle: select dbus instead of depending on it Fabrice Fontaine
2020-01-04 18:45 ` [Buildroot] [PATCH 2/2] package/bustle: bump to version 0.7.5 Fabrice Fontaine
2020-01-08 8:34 ` Thomas Petazzoni
2020-01-08 8:35 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108093544.3288c09d@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox