[Buildroot] [PATCH 1/2] package/bustle: select dbus instead of depending on it

[Buildroot] [PATCH 1/2] package/bustle: select dbus instead of depending on it

[Fabrice Fontaine]

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/bustle/Config.in | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/package/bustle/Config.in b/package/bustle/Config.in
index 109ebdeed8..b3d321e14b 100644
--- a/package/bustle/Config.in
+++ b/package/bustle/Config.in
@@ -1,9 +1,9 @@
 config BR2_PACKAGE_BUSTLE
 	bool "bustle"
 	depends on BR2_USE_WCHAR # libglib2
-	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
-	depends on BR2_USE_MMU # libglib2
-	depends on BR2_PACKAGE_DBUS # runtime
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
+	depends on BR2_USE_MMU # dbus, libglib2
+	select BR2_PACKAGE_DBUS # runtime
 	select BR2_PACKAGE_LIBPCAP
 	select BR2_PACKAGE_LIBGLIB2
 	help
@@ -22,5 +22,4 @@ config BR2_PACKAGE_BUSTLE
 
 comment "bustle needs a toolchain w/ wchar, threads"
 	depends on BR2_USE_MMU
-	depends on BR2_PACKAGE_DBUS
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
-- 
2.24.0

[Buildroot] [PATCH 2/2] package/bustle: bump to version 0.7.5

[Fabrice Fontaine]

- Switch homepage to https://gitlab.freedesktop.org/bustle/bustle/
- Switch site to
  https://www.freedesktop.org/software/bustle/$(BUSTLE_VERSION)
- Add hash for license file

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/bustle/Config.in   | 2 +-
 package/bustle/bustle.hash | 3 ++-
 package/bustle/bustle.mk   | 4 ++--
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/package/bustle/Config.in b/package/bustle/Config.in
index b3d321e14b..563b65f2c3 100644
--- a/package/bustle/Config.in
+++ b/package/bustle/Config.in
@@ -18,7 +18,7 @@ config BR2_PACKAGE_BUSTLE
 	  This only installs the command line bustle-pcap tool, not
 	  the graphical viewer.
 
-	  http://www.willthompson.co.uk/bustle/
+	  https://gitlab.freedesktop.org/bustle/bustle/
 
 comment "bustle needs a toolchain w/ wchar, threads"
 	depends on BR2_USE_MMU
diff --git a/package/bustle/bustle.hash b/package/bustle/bustle.hash
index 49890f74ff..05281c4f11 100644
--- a/package/bustle/bustle.hash
+++ b/package/bustle/bustle.hash
@@ -1,2 +1,3 @@
 # Locally calculated
-sha256 921c2cbbb957dcb02c3aa8fd1eeff3534cb437fa9eeca1c25206ad1e741a3f14  bustle-0.5.4.tar.gz
+sha256 7760a695b25cb264e7342f353dcdc6d2b7faeacdcd85dd14e03c61b18e791664  bustle-0.7.5.tar.gz
+sha256 a6d6109e5b086de8e852e451b91b08b323302f55b6975d506c64c43bb094be38  LICENSE
diff --git a/package/bustle/bustle.mk b/package/bustle/bustle.mk
index ffbfbe40f7..675ffb0529 100644
--- a/package/bustle/bustle.mk
+++ b/package/bustle/bustle.mk
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-BUSTLE_VERSION = 0.5.4
-BUSTLE_SITE = http://www.willthompson.co.uk/bustle/releases/$(BUSTLE_VERSION)
+BUSTLE_VERSION = 0.7.5
+BUSTLE_SITE = https://www.freedesktop.org/software/bustle/$(BUSTLE_VERSION)
 BUSTLE_LICENSE = LGPL-2.1+
 BUSTLE_LICENSE_FILES = LICENSE
 BUSTLE_DEPENDENCIES = libglib2 libpcap host-pkgconf
-- 
2.24.0

[Buildroot] [PATCH 2/2] package/bustle: bump to version 0.7.5

[Thomas Petazzoni]

On Sat,  4 Jan 2020 19:45:13 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> - Switch homepage to https://gitlab.freedesktop.org/bustle/bustle/
> - Switch site to
>   https://www.freedesktop.org/software/bustle/$(BUSTLE_VERSION)
> - Add hash for license file
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/bustle/Config.in   | 2 +-
>  package/bustle/bustle.hash | 3 ++-
>  package/bustle/bustle.mk   | 4 ++--
>  3 files changed, 5 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/2] package/bustle: select dbus instead of depending on it

[Thomas Petazzoni]

On Sat,  4 Jan 2020 19:45:12 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

I agree that in general we prefer to use "select" for non-obvious
dependencies. But here, the dependency is obvious, and in fact "bustle"
is completely useless if you don't use D-Bus: you will only want to
even consider enabling bustle if you're already using D-Bus, and want
to debug some stuff.

So I think it is a case where a "depends on" dependency makes a lot of
sense, very much like Python modules all "depends on" the Python
interpreter being present, rather than selecting it.

So I've mark the patch as Rejected in patchwork.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com