* [Buildroot] [PATCH v2,1/1] package/olsr: use make foreach loops
@ 2020-01-14 18:14 Fabrice Fontaine
2020-01-14 21:25 ` [Buildroot] [PATCH v2, 1/1] " Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2020-01-14 18:14 UTC (permalink / raw)
To: buildroot
Replace shell for loops by make foreach loops
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Thomas Petazzoni):
- Add a trailing backslash
package/olsr/olsr.mk | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/package/olsr/olsr.mk b/package/olsr/olsr.mk
index e643a0cfb3..53bf874af0 100644
--- a/package/olsr/olsr.mk
+++ b/package/olsr/olsr.mk
@@ -18,19 +18,19 @@ OLSR_DEPENDENCIES = host-flex host-bison
define OLSR_BUILD_CMDS
$(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D) olsrd
- for p in $(OLSR_PLUGINS) ; do \
- $(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D)/lib/$$p ; \
- done
+ $(foreach p,$(OLSR_PLUGINS), \
+ $(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D)/lib/$(p)
+ )
endef
define OLSR_INSTALL_TARGET_CMDS
$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) \
prefix="/usr" install_bin
- for p in $(OLSR_PLUGINS) ; do \
- $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/lib/$$p \
+ $(foreach p,$(OLSR_PLUGINS), \
+ $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/lib/$(p) \
LDCONFIG=/bin/true DESTDIR=$(TARGET_DIR) \
- prefix="/usr" install ; \
- done
+ prefix="/usr" install
+ )
$(INSTALL) -D -m 0644 $(@D)/files/olsrd.conf.default.lq \
$(TARGET_DIR)/etc/olsrd/olsrd.conf
endef
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH v2, 1/1] package/olsr: use make foreach loops
2020-01-14 18:14 [Buildroot] [PATCH v2,1/1] package/olsr: use make foreach loops Fabrice Fontaine
@ 2020-01-14 21:25 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2020-01-14 21:25 UTC (permalink / raw)
To: buildroot
On Tue, 14 Jan 2020 19:14:51 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Replace shell for loops by make foreach loops
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Thomas Petazzoni):
> - Add a trailing backslash
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-14 21:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-14 18:14 [Buildroot] [PATCH v2,1/1] package/olsr: use make foreach loops Fabrice Fontaine
2020-01-14 21:25 ` [Buildroot] [PATCH v2, 1/1] " Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox