[Buildroot] [PATCH] package/erlang-p1-xmpp: fix host build

[Buildroot] [PATCH] package/erlang-p1-xmpp: fix host build

[Johan Oudinet]

Fixes:
http://autobuild.buildroot.net/results/3e594350131994df53b20d5113fefbba2e747836
Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>
---
 package/erlang-p1-xmpp/erlang-p1-xmpp.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/erlang-p1-xmpp/erlang-p1-xmpp.mk b/package/erlang-p1-xmpp/erlang-p1-xmpp.mk
index ced058731b..2f74c60df2 100644
--- a/package/erlang-p1-xmpp/erlang-p1-xmpp.mk
+++ b/package/erlang-p1-xmpp/erlang-p1-xmpp.mk
@@ -11,6 +11,7 @@ ERLANG_P1_XMPP_LICENSE_FILES = LICENSE.txt
 ERLANG_P1_XMPP_INSTALL_STAGING = YES
 ERLANG_P1_XMPP_DEPENDENCIES = erlang-p1-xml erlang-p1-stringprep \
 	erlang-p1-tls erlang-p1-utils erlang-p1-zlib host-erlang-p1-xml
+HOST_ERLANG_P1_XMPP_DEPENDENCIES = host-erlang-p1-xml
 
 $(eval $(rebar-package))
 $(eval $(host-rebar-package))
-- 
2.20.1

[Buildroot] [PATCH] package/erlang-p1-xmpp: fix host build

[Thomas Petazzoni]

On Wed, 22 Jan 2020 11:34:01 +0100
Johan Oudinet <johan.oudinet@gmail.com> wrote:

> Fixes:
> http://autobuild.buildroot.net/results/3e594350131994df53b20d5113fefbba2e747836
> Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>

Thanks, I've applied, but I have a question below.

>  ERLANG_P1_XMPP_DEPENDENCIES = erlang-p1-xml erlang-p1-stringprep \
>  	erlang-p1-tls erlang-p1-utils erlang-p1-zlib host-erlang-p1-xml
> +HOST_ERLANG_P1_XMPP_DEPENDENCIES = host-erlang-p1-xml

It is weird that there is no symmetry between the target dependencies
and host dependencies. Why don't we have the same set of packages ?

Also, it is really normal/correct for the target variant to depend on
host-erlang-p1-xml ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] package/erlang-p1-xmpp: fix host build

[Johan Oudinet]

On Sun, Feb 2, 2020 at 9:57 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Wed, 22 Jan 2020 11:34:01 +0100
> Johan Oudinet <johan.oudinet@gmail.com> wrote:
>
> >  ERLANG_P1_XMPP_DEPENDENCIES = erlang-p1-xml erlang-p1-stringprep \
> >       erlang-p1-tls erlang-p1-utils erlang-p1-zlib host-erlang-p1-xml
> > +HOST_ERLANG_P1_XMPP_DEPENDENCIES = host-erlang-p1-xml
>
> It is weird that there is no symmetry between the target dependencies
> and host dependencies. Why don't we have the same set of packages ?

I honestly don't know. I use this package only as a dependency of
ejabberd. So I just check it compiles and ejabberd works correctly
afterwards. This is far from perfect to test if the list of
dependencies is correct.

> Also, it is really normal/correct for the target variant to depend on
> host-erlang-p1-xml ?

I remember I had to add this host dependency to make the target
variant compiles. I also think this is weird. I haven't tested
recently to remove such dependency but I'll try to simplify the
dependencies next time I bump the version of this package.

-- 
Johan