* [Buildroot] [PATCH v2 1/2] package/libiconv: enable extra encodings
@ 2020-02-01 12:59 Bernd Kuhls
2020-02-01 12:59 ` [Buildroot] [PATCH 2/2] package/kodi: needs extra encodings in libiconv Bernd Kuhls
2020-02-03 16:42 ` [Buildroot] [PATCH v2 1/2] package/libiconv: enable extra encodings Yann E. MORIN
0 siblings, 2 replies; 4+ messages in thread
From: Bernd Kuhls @ 2020-02-01 12:59 UTC (permalink / raw)
To: buildroot
Quoting https://www.gnu.org/software/libiconv/
"When configured with the option --enable-extra-encodings, it also
provides support for a few extra encodings:
European languages
CP{437,737,775,852,853,855,857,858,860,861,863,865,869,1125}
Semitic languages
CP864
Japanese
EUC-JISX0213, Shift_JISX0213, ISO-2022-JP-3
Chinese
BIG5-2003 (experimental)
Turkmen
TDS565
Platform specifics
ATARIST, RISCOS-LATIN1"
Updating Kodi from version 17.6 to 18.5 caused runtime errors on systems
with locale support disabled, here Kodi uses libiconv but needs CP437:
ERROR: customConvert: iconv_open() for "CP437" -> "UTF-8" failed,
errno = 22 (Invalid argument)
Due to the size increase of libiconv.so.2.6.0 from 941K to 1,1M a new
Config.in option was added.
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
v2: added Config.in option (Thomas, Arnout)
package/libiconv/Config.in | 22 ++++++++++++++++++++++
package/libiconv/libiconv.mk | 4 ++++
2 files changed, 26 insertions(+)
diff --git a/package/libiconv/Config.in b/package/libiconv/Config.in
index ee4fd62011..6c9e6ea81b 100644
--- a/package/libiconv/Config.in
+++ b/package/libiconv/Config.in
@@ -5,3 +5,25 @@ config BR2_PACKAGE_LIBICONV
unicode conversion library
http://ftp.gnu.org/pub/gnu/libiconv
+
+if BR2_PACKAGE_LIBICONV
+
+config BR2_PACKAGE_LIBICONV_EXTRA_ENCODINGS
+ bool "extra encodings"
+ help
+ Provide support for a few extra encodings:
+
+ European languages
+ CP{437,737,775,852,853,855,857,858,860,861,863,865,869,1125}
+ Semitic languages
+ CP864
+ Japanese
+ EUC-JISX0213, Shift_JISX0213, ISO-2022-JP-3
+ Chinese
+ BIG5-2003 (experimental)
+ Turkmen
+ TDS565
+ Platform specifics
+ ATARIST, RISCOS-LATIN1
+
+endif
diff --git a/package/libiconv/libiconv.mk b/package/libiconv/libiconv.mk
index 9a8133612b..ec79a5d735 100644
--- a/package/libiconv/libiconv.mk
+++ b/package/libiconv/libiconv.mk
@@ -10,6 +10,10 @@ LIBICONV_INSTALL_STAGING = YES
LIBICONV_LICENSE = GPL-3.0+ (iconv program), LGPL-2.0+ (library)
LIBICONV_LICENSE_FILES = COPYING COPYING.LIB
+ifeq ($(BR2_PACKAGE_LIBICONV_EXTRA_ENCODINGS),y)
+LIBICONV_CONF_OPTS = --enable-extra-encodings
+endif
+
# Don't build the preloadable library, as we don't need it (it's only
# for LD_PRELOAD to replace glibc's iconv, but we never build libiconv
# when glibc is used). And it causes problems for static only builds.
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] package/kodi: needs extra encodings in libiconv
2020-02-01 12:59 [Buildroot] [PATCH v2 1/2] package/libiconv: enable extra encodings Bernd Kuhls
@ 2020-02-01 12:59 ` Bernd Kuhls
2020-02-03 16:42 ` Yann E. MORIN
2020-02-03 16:42 ` [Buildroot] [PATCH v2 1/2] package/libiconv: enable extra encodings Yann E. MORIN
1 sibling, 1 reply; 4+ messages in thread
From: Bernd Kuhls @ 2020-02-01 12:59 UTC (permalink / raw)
To: buildroot
The Kodi build system also enables extra encodings:
https://github.com/xbmc/xbmc/blob/Leia/tools/depends/target/libiconv/Makefile#L13
Without them addons fail to install:
https://github.com/garbear/kodi-steamlink/issues/34#issuecomment-579392269
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/kodi/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/kodi/Config.in b/package/kodi/Config.in
index f592e18e13..65e7768d6d 100644
--- a/package/kodi/Config.in
+++ b/package/kodi/Config.in
@@ -65,6 +65,7 @@ menuconfig BR2_PACKAGE_KODI
select BR2_PACKAGE_LIBCURL
select BR2_PACKAGE_LIBFRIBIDI
select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
+ select BR2_PACKAGE_LIBICONV_EXTRA_ENCODINGS if !BR2_ENABLE_LOCALE
select BR2_PACKAGE_LIBPLIST
select BR2_PACKAGE_LIBSAMPLERATE
select BR2_PACKAGE_LZO
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/libiconv: enable extra encodings
2020-02-01 12:59 [Buildroot] [PATCH v2 1/2] package/libiconv: enable extra encodings Bernd Kuhls
2020-02-01 12:59 ` [Buildroot] [PATCH 2/2] package/kodi: needs extra encodings in libiconv Bernd Kuhls
@ 2020-02-03 16:42 ` Yann E. MORIN
1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2020-02-03 16:42 UTC (permalink / raw)
To: buildroot
Bernd, All,
On 2020-02-01 13:59 +0100, Bernd Kuhls spake thusly:
> Quoting https://www.gnu.org/software/libiconv/
>
> "When configured with the option --enable-extra-encodings, it also
> provides support for a few extra encodings:
>
> European languages
> CP{437,737,775,852,853,855,857,858,860,861,863,865,869,1125}
> Semitic languages
> CP864
> Japanese
> EUC-JISX0213, Shift_JISX0213, ISO-2022-JP-3
> Chinese
> BIG5-2003 (experimental)
> Turkmen
> TDS565
> Platform specifics
> ATARIST, RISCOS-LATIN1"
>
> Updating Kodi from version 17.6 to 18.5 caused runtime errors on systems
> with locale support disabled, here Kodi uses libiconv but needs CP437:
>
> ERROR: customConvert: iconv_open() for "CP437" -> "UTF-8" failed,
> errno = 22 (Invalid argument)
>
> Due to the size increase of libiconv.so.2.6.0 from 941K to 1,1M a new
> Config.in option was added.
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v2: added Config.in option (Thomas, Arnout)
>
> package/libiconv/Config.in | 22 ++++++++++++++++++++++
> package/libiconv/libiconv.mk | 4 ++++
> 2 files changed, 26 insertions(+)
>
> diff --git a/package/libiconv/Config.in b/package/libiconv/Config.in
> index ee4fd62011..6c9e6ea81b 100644
> --- a/package/libiconv/Config.in
> +++ b/package/libiconv/Config.in
> @@ -5,3 +5,25 @@ config BR2_PACKAGE_LIBICONV
> unicode conversion library
>
> http://ftp.gnu.org/pub/gnu/libiconv
> +
> +if BR2_PACKAGE_LIBICONV
> +
> +config BR2_PACKAGE_LIBICONV_EXTRA_ENCODINGS
> + bool "extra encodings"
> + help
> + Provide support for a few extra encodings:
> +
> + European languages
> + CP{437,737,775,852,853,855,857,858,860,861,863,865,869,1125}
This line was too long, causing check-package to complain:
package/libiconv/Config.in:17: help text: <tab><2 spaces><62 chars>
(http://nightly.buildroot.org/#writing-rules-config-in)
So I removed two of the indenting spaces, and we're good.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> + Semitic languages
> + CP864
> + Japanese
> + EUC-JISX0213, Shift_JISX0213, ISO-2022-JP-3
> + Chinese
> + BIG5-2003 (experimental)
> + Turkmen
> + TDS565
> + Platform specifics
> + ATARIST, RISCOS-LATIN1
> +
> +endif
> diff --git a/package/libiconv/libiconv.mk b/package/libiconv/libiconv.mk
> index 9a8133612b..ec79a5d735 100644
> --- a/package/libiconv/libiconv.mk
> +++ b/package/libiconv/libiconv.mk
> @@ -10,6 +10,10 @@ LIBICONV_INSTALL_STAGING = YES
> LIBICONV_LICENSE = GPL-3.0+ (iconv program), LGPL-2.0+ (library)
> LIBICONV_LICENSE_FILES = COPYING COPYING.LIB
>
> +ifeq ($(BR2_PACKAGE_LIBICONV_EXTRA_ENCODINGS),y)
> +LIBICONV_CONF_OPTS = --enable-extra-encodings
> +endif
> +
> # Don't build the preloadable library, as we don't need it (it's only
> # for LD_PRELOAD to replace glibc's iconv, but we never build libiconv
> # when glibc is used). And it causes problems for static only builds.
> --
> 2.20.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] package/kodi: needs extra encodings in libiconv
2020-02-01 12:59 ` [Buildroot] [PATCH 2/2] package/kodi: needs extra encodings in libiconv Bernd Kuhls
@ 2020-02-03 16:42 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2020-02-03 16:42 UTC (permalink / raw)
To: buildroot
Bernd, All,
On 2020-02-01 13:59 +0100, Bernd Kuhls spake thusly:
> The Kodi build system also enables extra encodings:
> https://github.com/xbmc/xbmc/blob/Leia/tools/depends/target/libiconv/Makefile#L13
>
> Without them addons fail to install:
> https://github.com/garbear/kodi-steamlink/issues/34#issuecomment-579392269
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/kodi/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/kodi/Config.in b/package/kodi/Config.in
> index f592e18e13..65e7768d6d 100644
> --- a/package/kodi/Config.in
> +++ b/package/kodi/Config.in
> @@ -65,6 +65,7 @@ menuconfig BR2_PACKAGE_KODI
> select BR2_PACKAGE_LIBCURL
> select BR2_PACKAGE_LIBFRIBIDI
> select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
> + select BR2_PACKAGE_LIBICONV_EXTRA_ENCODINGS if !BR2_ENABLE_LOCALE
> select BR2_PACKAGE_LIBPLIST
> select BR2_PACKAGE_LIBSAMPLERATE
> select BR2_PACKAGE_LZO
> --
> 2.20.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-03 16:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-01 12:59 [Buildroot] [PATCH v2 1/2] package/libiconv: enable extra encodings Bernd Kuhls
2020-02-01 12:59 ` [Buildroot] [PATCH 2/2] package/kodi: needs extra encodings in libiconv Bernd Kuhls
2020-02-03 16:42 ` Yann E. MORIN
2020-02-03 16:42 ` [Buildroot] [PATCH v2 1/2] package/libiconv: enable extra encodings Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox