* [Buildroot] [PATCH 1/1] package/libupnpp: remove unneeded static workaround
@ 2020-02-16 14:52 Fabrice Fontaine
2020-02-18 23:39 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2020-02-16 14:52 UTC (permalink / raw)
To: buildroot
libupnpp uses pkg-config since version 0.15.1 and
https://opensourceprojects.eu/p/libupnpp/code/ci/3dc44417e868b9b4417cbc15f8173e0a2e142b17
so remove unneeded static workaround
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libupnpp/libupnpp.mk | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/package/libupnpp/libupnpp.mk b/package/libupnpp/libupnpp.mk
index 53dc9f6c36..c9c103d9b5 100644
--- a/package/libupnpp/libupnpp.mk
+++ b/package/libupnpp/libupnpp.mk
@@ -9,15 +9,7 @@ LIBUPNPP_SITE = http://www.lesbonscomptes.com/upmpdcli/downloads
LIBUPNPP_LICENSE = LGPL-2.1+
LIBUPNPP_LICENSE_FILES = COPYING
LIBUPNPP_INSTALL_STAGING = YES
-LIBUPNPP_DEPENDENCIES = expat libcurl \
+LIBUPNPP_DEPENDENCIES = host-pkgconf expat libcurl \
$(if $(BR2_PACKAGE_LIBUPNP),libupnp,libupnp18)
-# configure script fails to link against the dependencies of libupnp
-# and libcurl causing detection to fail when statically linking
-ifeq ($(BR2_STATIC_LIBS),y)
-LIBUPNPP_DEPENDENCIES += host-pkgconf
-LIBUPNPP_CONF_ENV += \
- LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs libupnp libcurl`"
-endif
-
$(eval $(autotools-package))
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] package/libupnpp: remove unneeded static workaround
2020-02-16 14:52 [Buildroot] [PATCH 1/1] package/libupnpp: remove unneeded static workaround Fabrice Fontaine
@ 2020-02-18 23:39 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2020-02-18 23:39 UTC (permalink / raw)
To: buildroot
On Sun, 16 Feb 2020 15:52:04 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> libupnpp uses pkg-config since version 0.15.1 and
> https://opensourceprojects.eu/p/libupnpp/code/ci/3dc44417e868b9b4417cbc15f8173e0a2e142b17
> so remove unneeded static workaround
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libupnpp/libupnpp.mk | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-18 23:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-16 14:52 [Buildroot] [PATCH 1/1] package/libupnpp: remove unneeded static workaround Fabrice Fontaine
2020-02-18 23:39 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox