* [Buildroot] [PATCH 1/1] toolchain/toolchain-external/toolchain-external-codesourcery-arm: disable SSP
@ 2019-10-28 13:08 Fabrice Fontaine
2019-12-20 16:33 ` Giulio Benetti
2020-02-20 2:03 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2019-10-28 13:08 UTC (permalink / raw)
To: buildroot
This toolchain does not support -fstack-protector-strong:
SSP option -fstack-protector-strong not available in this toolchain, please select another SSP level
As there is no way to add a !BR2_SSP_STRONG dependency without creating a
Kconfig recursive dependency, just remove BR2_TOOLCHAIN_HAS_SSP
Fixes:
- http://autobuild.buildroot.net/results/78dc6428ffaa529fdad8e9c8aaec49ded5f0209a
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
.../toolchain-external-codesourcery-arm/Config.in | 1 -
1 file changed, 1 deletion(-)
diff --git a/toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in b/toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in
index bdbe2acaea..f80e54ff06 100644
--- a/toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in
+++ b/toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in
@@ -8,7 +8,6 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM
depends on !BR2_cortex_a12 && !BR2_cortex_a17 && !BR2_ARM_CPU_ARMV8A
depends on !BR2_STATIC_LIBS
select BR2_TOOLCHAIN_EXTERNAL_GLIBC
- select BR2_TOOLCHAIN_HAS_SSP
select BR2_TOOLCHAIN_HAS_NATIVE_RPC
select BR2_INSTALL_LIBSTDCPP
select BR2_HOSTARCH_NEEDS_IA32_LIBS
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] toolchain/toolchain-external/toolchain-external-codesourcery-arm: disable SSP
2019-10-28 13:08 [Buildroot] [PATCH 1/1] toolchain/toolchain-external/toolchain-external-codesourcery-arm: disable SSP Fabrice Fontaine
@ 2019-12-20 16:33 ` Giulio Benetti
2019-12-21 9:00 ` Fabrice Fontaine
2020-02-20 2:03 ` Thomas Petazzoni
1 sibling, 1 reply; 4+ messages in thread
From: Giulio Benetti @ 2019-12-20 16:33 UTC (permalink / raw)
To: buildroot
Hi Fabrice,
On 10/28/19 2:08 PM, Fabrice Fontaine wrote:
> This toolchain does not support -fstack-protector-strong:
> SSP option -fstack-protector-strong not available in this toolchain, please select another SSP level
>
> As there is no way to add a !BR2_SSP_STRONG dependency without creating a
> Kconfig recursive dependency, just remove BR2_TOOLCHAIN_HAS_SSP
>
> Fixes:
> - http://autobuild.buildroot.net/results/78dc6428ffaa529fdad8e9c8aaec49ded5f0209a
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
I've tried applying this patch against autobuilder's buildroot but
Buildroot recognizes that this toolchain is still capable of SSP and
gives this error:
"SSP support available in this toolchain, please enable
BR2_TOOLCHAIN_EXTERNAL_HAS_SSP"
The same is with your patch on top of master branch.
Can you please verify and dig into this problem?
Thank you very much
Best regards
--
Giulio Benetti
Benetti Engineering sas
> ---
> .../toolchain-external-codesourcery-arm/Config.in | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in b/toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in
> index bdbe2acaea..f80e54ff06 100644
> --- a/toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in
> +++ b/toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in
> @@ -8,7 +8,6 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM
> depends on !BR2_cortex_a12 && !BR2_cortex_a17 && !BR2_ARM_CPU_ARMV8A
> depends on !BR2_STATIC_LIBS
> select BR2_TOOLCHAIN_EXTERNAL_GLIBC
> - select BR2_TOOLCHAIN_HAS_SSP
> select BR2_TOOLCHAIN_HAS_NATIVE_RPC
> select BR2_INSTALL_LIBSTDCPP
> select BR2_HOSTARCH_NEEDS_IA32_LIBS
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] toolchain/toolchain-external/toolchain-external-codesourcery-arm: disable SSP
2019-12-20 16:33 ` Giulio Benetti
@ 2019-12-21 9:00 ` Fabrice Fontaine
0 siblings, 0 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2019-12-21 9:00 UTC (permalink / raw)
To: buildroot
Hi Giulio,
Le ven. 20 d?c. 2019 ? 17:33, Giulio Benetti
<giulio.benetti@benettiengineering.com> a ?crit :
>
> Hi Fabrice,
>
> On 10/28/19 2:08 PM, Fabrice Fontaine wrote:
> > This toolchain does not support -fstack-protector-strong:
> > SSP option -fstack-protector-strong not available in this toolchain, please select another SSP level
> >
> > As there is no way to add a !BR2_SSP_STRONG dependency without creating a
> > Kconfig recursive dependency, just remove BR2_TOOLCHAIN_HAS_SSP
> >
> > Fixes:
> > - http://autobuild.buildroot.net/results/78dc6428ffaa529fdad8e9c8aaec49ded5f0209a
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> I've tried applying this patch against autobuilder's buildroot but
> Buildroot recognizes that this toolchain is still capable of SSP and
> gives this error:
> "SSP support available in this toolchain, please enable
> BR2_TOOLCHAIN_EXTERNAL_HAS_SSP"
>
> The same is with your patch on top of master branch.
>
> Can you please verify and dig into this problem?
Indeed, this patch does not fix the issue as toolchain/helpers.mk
raises an error because it detects that -fstack-protector is supported
through:
__HAS_SSP=`echo 'void main(){}' | $${__CROSS_CC} -Werror
-fstack-protector -x c - -o $(BUILD_DIR)/.br-toolchain-test.tmp
>/dev/null 2>&1 && echo y` ; \
if [ "$(BR2_TOOLCHAIN_HAS_SSP)" != "y" -a "$${__HAS_SSP}" = "y" ] ; then \
echo "SSP support available in this toolchain, please enable
BR2_TOOLCHAIN_EXTERNAL_HAS_SSP" ; \
exit 1 ; \
fi ; \
So I assume the correct way to fix this autobuilder failure is to
patch utils/genrandconfig to avoid this configuration setup with this
toolchain.
The quickest solution would be to update the fixup_config function to
reject BR2_SSP_STRONG with BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM but
this does not seem very generic.
>
> Thank you very much
> Best regards
> --
> Giulio Benetti
> Benetti Engineering sas
Best Regards,
Fabrice
>
> > ---
> > .../toolchain-external-codesourcery-arm/Config.in | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in b/toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in
> > index bdbe2acaea..f80e54ff06 100644
> > --- a/toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in
> > +++ b/toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in
> > @@ -8,7 +8,6 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM
> > depends on !BR2_cortex_a12 && !BR2_cortex_a17 && !BR2_ARM_CPU_ARMV8A
> > depends on !BR2_STATIC_LIBS
> > select BR2_TOOLCHAIN_EXTERNAL_GLIBC
> > - select BR2_TOOLCHAIN_HAS_SSP
> > select BR2_TOOLCHAIN_HAS_NATIVE_RPC
> > select BR2_INSTALL_LIBSTDCPP
> > select BR2_HOSTARCH_NEEDS_IA32_LIBS
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] toolchain/toolchain-external/toolchain-external-codesourcery-arm: disable SSP
2019-10-28 13:08 [Buildroot] [PATCH 1/1] toolchain/toolchain-external/toolchain-external-codesourcery-arm: disable SSP Fabrice Fontaine
2019-12-20 16:33 ` Giulio Benetti
@ 2020-02-20 2:03 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2020-02-20 2:03 UTC (permalink / raw)
To: buildroot
Hello Fabrice,
On Mon, 28 Oct 2019 14:08:38 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> This toolchain does not support -fstack-protector-strong:
> SSP option -fstack-protector-strong not available in this toolchain, please select another SSP level
>
> As there is no way to add a !BR2_SSP_STRONG dependency without creating a
> Kconfig recursive dependency, just remove BR2_TOOLCHAIN_HAS_SSP
>
> Fixes:
> - http://autobuild.buildroot.net/results/78dc6428ffaa529fdad8e9c8aaec49ded5f0209a
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
I have submitted a different patch series, implementing a different
solution for this issue:
http://patchwork.ozlabs.org/project/buildroot/list/?series=159621
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-20 2:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-28 13:08 [Buildroot] [PATCH 1/1] toolchain/toolchain-external/toolchain-external-codesourcery-arm: disable SSP Fabrice Fontaine
2019-12-20 16:33 ` Giulio Benetti
2019-12-21 9:00 ` Fabrice Fontaine
2020-02-20 2:03 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox