Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/fail2ban: fix python3 2to3 dependency
Date: Fri, 21 Feb 2020 12:46:26 +0100	[thread overview]
Message-ID: <20200221124626.55f97073@windsurf> (raw)
In-Reply-To: <87d0a8zfk4.fsf@tarshish>

Hello Baruch,

On Fri, 21 Feb 2020 07:15:39 +0200
Baruch Siach <baruch@tkos.co.il> wrote:

> > So for this fail2ban thing, I guess the easier is to move the 2to3
> > execution to a PRE_CONFIGURE_HOOKS, with a good comment above.  
> 
> How would that fix the issue? Is host-python3 guaranteed to build before
> fail2ban PRE_CONFIGURE_HOOKS run unlike POST_PATCH_HOOKS?

Absolutely. The dependencies listed in <pkg>_DEPENDENCIES are
guaranteed to be built and installed before the configure step of <pkg>
starts.

See:

$$($(2)_TARGET_CONFIGURE):	| $$($(2)_FINAL_DEPENDENCIES)

in package/pkg-generic.mk.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2020-02-21 11:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17 12:52 [Buildroot] [PATCH] package/fail2ban: fix python3 2to3 dependency Baruch Siach
2020-02-18 17:43 ` Thomas Petazzoni
2020-02-21  5:15   ` Baruch Siach
2020-02-21 11:46     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200221124626.55f97073@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox