From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/fail2ban: fix python3 2to3 dependency
Date: Fri, 21 Feb 2020 07:15:39 +0200 [thread overview]
Message-ID: <87d0a8zfk4.fsf@tarshish> (raw)
In-Reply-To: <20200218184311.25806bcb@windsurf>
Hi Thomas,
On Tue, Feb 18 2020, Thomas Petazzoni wrote:
> On Mon, 17 Feb 2020 14:52:11 +0200
> Baruch Siach <baruch@tkos.co.il> wrote:
>
>> The 2to3 utility is needed in the patch phase. Use the correct
>> dependency for that.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/dd8e225e2a49cfa6735bed11459007003a37c137/
>> http://autobuild.buildroot.net/results/e688c3652bd474ac682984e2e5947701942f0f57/
>>
>> Cc: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>> Cc: Pascal de Bruijn <p.debruijn@unilogic.nl>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> ---
>> package/fail2ban/fail2ban.mk | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/package/fail2ban/fail2ban.mk b/package/fail2ban/fail2ban.mk
>> index 6f023b48a181..0f8e5ab6e694 100644
>> --- a/package/fail2ban/fail2ban.mk
>> +++ b/package/fail2ban/fail2ban.mk
>> @@ -14,7 +14,7 @@ ifeq ($(BR2_PACKAGE_PYTHON3),y)
>> define FAIL2BAN_PYTHON_2TO3
>> $(HOST_DIR)/bin/2to3 --write --nobackups --no-diffs $(@D)/bin/* $(@D)/fail2ban
>> endef
>> -FAIL2BAN_DEPENDENCIES += host-python3
>> +FAIL2BAN_PATCH_DEPENDENCIES += host-python3
>> FAIL2BAN_POST_PATCH_HOOKS += FAIL2BAN_PYTHON_2TO3
>
> I don't think this solves the problem. Indeed, patch dependencies are
> special. When you do:
>
> FAIL2BAN_PATCH_DEPENDENCIES += host-python3
>
> You're in fact adding a dependency of fail2ban-patch on
> host-python3-patch, and not on host-python3.
>
> See in pkg-generic.mk:
>
> $$($(2)_TARGET_PATCH): | $$(patsubst %,%-patch,$$($(2)_FINAL_PATCH_DEPENDENCIES))
>
> See the nice patsubst here ? :-)
>
> And this intentional, and really needed for some Linux extensions
> (Xenomai ? RTAI ? don't remember which one of the two).
>
> So for this fail2ban thing, I guess the easier is to move the 2to3
> execution to a PRE_CONFIGURE_HOOKS, with a good comment above.
How would that fix the issue? Is host-python3 guaranteed to build before
fail2ban PRE_CONFIGURE_HOOKS run unlike POST_PATCH_HOOKS?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2020-02-21 5:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 12:52 [Buildroot] [PATCH] package/fail2ban: fix python3 2to3 dependency Baruch Siach
2020-02-18 17:43 ` Thomas Petazzoni
2020-02-21 5:15 ` Baruch Siach [this message]
2020-02-21 11:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0a8zfk4.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox