From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/network-manager: bump version to 1.22.8
Date: Mon, 24 Feb 2020 22:19:31 +0100 [thread overview]
Message-ID: <20200224221931.33b86558@windsurf> (raw)
In-Reply-To: <5183eda7f2b375c1f880c1c732f8748b8aa40d17.camel@wiedemann-group.com>
Hello Alex,
On Mon, 24 Feb 2020 13:49:53 +0000
Michel Alex <Alex.Michel@wiedemann-group.com> wrote:
> From cfc2447a49b3113f9642d2e25e43b78039b6431a Mon Sep 17 00:00:00 2001
> From: Alex Michel <alex.michel@wiedemann-group.com>
> Date: Mon, 24 Feb 2020 14:42:38 +0100
> Subject: [PATCH 1/1] package/network-manager: bump version to 1.22.8
There is something odd with your patch, it seems like you copy/paste
the contents of the file generated by "git format-patch". Could you use
"git send-email" instead to send it?
Also, see one more important comment below.
> # Locally computed
> -sha256 49d9659a4f9a09747c320d51d3cf9dfde210de67b70862acf849890f6477b00d COPYING
> -sha256 64a6d38d1b551a1bfd8509e732cdc9202d2681b61f5b39298f488674d3466fc9 CONTRIBUTING
> +sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 COPYING
> +sha256 f0543c137bc0eece552d42642d1bab31707ca3b3663d9c7a81ac3b270a4780e7 CONTRIBUTING
When the hash of the license files are changed, we want an explanation
in the commit log, to make sure the changes were checked properly.
Could you diff the old and new COPYING and CONTRIBUTING files, and
check what the differences are, and summarize them in the commit log ?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-02-24 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 13:49 [Buildroot] [PATCH 1/1] package/network-manager: bump version to 1.22.8 Michel Alex
2020-02-24 21:19 ` Thomas Petazzoni [this message]
2020-02-25 6:29 ` Michel Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224221931.33b86558@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox