[Buildroot] [PATCH 1/1] package/network-manager: bump version to 1.22.8

[Buildroot] [PATCH 1/1] package/network-manager: bump version to 1.22.8

[Michel Alex]

[Buildroot] [PATCH 1/1] package/network-manager: bump version to 1.22.8

[Thomas Petazzoni]

Hello Alex,

On Mon, 24 Feb 2020 13:49:53 +0000
Michel Alex <Alex.Michel@wiedemann-group.com> wrote:

> From cfc2447a49b3113f9642d2e25e43b78039b6431a Mon Sep 17 00:00:00 2001
> From: Alex Michel <alex.michel@wiedemann-group.com>
> Date: Mon, 24 Feb 2020 14:42:38 +0100
> Subject: [PATCH 1/1] package/network-manager: bump version to 1.22.8

There is something odd with your patch, it seems like you copy/paste
the contents of the file generated by "git format-patch". Could you use
"git send-email" instead to send it?

Also, see one more important comment below.

>  # Locally computed
> -sha256 49d9659a4f9a09747c320d51d3cf9dfde210de67b70862acf849890f6477b00d  COPYING
> -sha256 64a6d38d1b551a1bfd8509e732cdc9202d2681b61f5b39298f488674d3466fc9  CONTRIBUTING
> +sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
> +sha256 f0543c137bc0eece552d42642d1bab31707ca3b3663d9c7a81ac3b270a4780e7  CONTRIBUTING

When the hash of the license files are changed, we want an explanation
in the commit log, to make sure the changes were checked properly.

Could you diff the old and new COPYING and CONTRIBUTING files, and
check what the differences are, and summarize them in the commit log ?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/network-manager: bump version to 1.22.8

[Michel Alex]

Thomas,

please see the second version of my patch in the attachment, I'm sorry I am not allowed to use git send-email.

Regards,
Alex

On Mon, 2020-02-24 at 22:19 +0100, Thomas Petazzoni wrote:
> Hello Alex,
> 
> On Mon, 24 Feb 2020 13:49:53 +0000
> Michel Alex <Alex.Michel@wiedemann-group.com> wrote:
> 
> > From cfc2447a49b3113f9642d2e25e43b78039b6431a Mon Sep 17 00:00:00
> > 2001
> > From: Alex Michel <alex.michel@wiedemann-group.com>
> > Date: Mon, 24 Feb 2020 14:42:38 +0100
> > Subject: [PATCH 1/1] package/network-manager: bump version to
> > 1.22.8
> 
> There is something odd with your patch, it seems like you copy/paste
> the contents of the file generated by "git format-patch". Could you
> use
> "git send-email" instead to send it?
> 
> Also, see one more important comment below.
> 
> >  # Locally computed
> > -sha256
> > 49d9659a4f9a09747c320d51d3cf9dfde210de67b70862acf849890f6477b00d  C
> > OPYING
> > -sha256
> > 64a6d38d1b551a1bfd8509e732cdc9202d2681b61f5b39298f488674d3466fc9  C
> > ONTRIBUTING
> > +sha256
> > 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  C
> > OPYING
> > +sha256
> > f0543c137bc0eece552d42642d1bab31707ca3b3663d9c7a81ac3b270a4780e7  C
> > ONTRIBUTING
> 
> When the hash of the license files are changed, we want an
> explanation
> in the commit log, to make sure the changes were checked properly.
> 
> Could you diff the old and new COPYING and CONTRIBUTING files, and
> check what the differences are, and summarize them in the commit log
> ?
> 
> Thanks a lot!
> 
> Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2-0001-package-network-manager-bump-version-to-1.22.8.patch
Type: text/x-patch
Size: 2976 bytes
Desc: v2-0001-package-network-manager-bump-version-to-1.22.8.patch
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200225/fd342ac4/attachment.bin>