Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] Config.in: add BR2_HOST_GCC_AT_LEAST_9
@ 2020-02-25 21:22 Romain Naour
  2020-02-25 22:23 ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Romain Naour @ 2020-02-25 21:22 UTC (permalink / raw)
  To: buildroot

Fedora 30 switched to GCC 9.x. [1]

[1] https://fedoraproject.org/wiki/Changes/GCC9

Signed-off-by: Romain Naour <romain.naour@smile.fr>
---
 Config.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Config.in b/Config.in
index 2ccbdfb963..abaee794a4 100644
--- a/Config.in
+++ b/Config.in
@@ -50,6 +50,11 @@ config BR2_HOST_GCC_AT_LEAST_8
 	default y if BR2_HOST_GCC_VERSION = "8"
 	select BR2_HOST_GCC_AT_LEAST_7
 
+config BR2_HOST_GCC_AT_LEAST_9
+	bool
+	default y if BR2_HOST_GCC_VERSION = "9"
+	select BR2_HOST_GCC_AT_LEAST_8
+
 # When adding new entries above, be sure to update
 # the HOSTCC_MAX_VERSION variable in the Makefile.
 
-- 
2.24.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] Config.in: add BR2_HOST_GCC_AT_LEAST_9
  2020-02-25 21:22 [Buildroot] [PATCH] Config.in: add BR2_HOST_GCC_AT_LEAST_9 Romain Naour
@ 2020-02-25 22:23 ` Thomas Petazzoni
  2020-02-26  8:24   ` Romain Naour
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2020-02-25 22:23 UTC (permalink / raw)
  To: buildroot

On Tue, 25 Feb 2020 22:22:13 +0100
Romain Naour <romain.naour@smile.fr> wrote:

> Fedora 30 switched to GCC 9.x. [1]
> 
> [1] https://fedoraproject.org/wiki/Changes/GCC9
> 
> Signed-off-by: Romain Naour <romain.naour@smile.fr>

Thanks, but this was not sufficiently tested it seems: on my Fedora
system with gcc 9.x, BR2_HOST_GCC_VERSION was still 8, and therefore
BR2_HOST_GCC_AT_LEAST_9 was not "y". This is because the main Buildroot
Makefile HOSTCC_MAX_VERSION variable needs to be updated as well.

I fixed that up and applied to master. Thanks!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] Config.in: add BR2_HOST_GCC_AT_LEAST_9
  2020-02-25 22:23 ` Thomas Petazzoni
@ 2020-02-26  8:24   ` Romain Naour
  0 siblings, 0 replies; 3+ messages in thread
From: Romain Naour @ 2020-02-26  8:24 UTC (permalink / raw)
  To: buildroot

Hello Thomas,

Le 25/02/2020 ? 23:23, Thomas Petazzoni a ?crit?:
> On Tue, 25 Feb 2020 22:22:13 +0100
> Romain Naour <romain.naour@smile.fr> wrote:
> 
>> Fedora 30 switched to GCC 9.x. [1]
>>
>> [1] https://fedoraproject.org/wiki/Changes/GCC9
>>
>> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> 
> Thanks, but this was not sufficiently tested it seems: on my Fedora
> system with gcc 9.x, BR2_HOST_GCC_VERSION was still 8, and therefore
> BR2_HOST_GCC_AT_LEAST_9 was not "y". This is because the main Buildroot
> Makefile HOSTCC_MAX_VERSION variable needs to be updated as well.
> 
> I fixed that up and applied to master. Thanks!

Sorry for that.

I was looking at [1] at the same time (that is why I noticed this symbol was
missing).

[1] https://bugs.busybox.net/show_bug.cgi?id=12581

Best regards,
Romain


> 
> Best regards,
> 
> Thomas
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-26  8:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-25 21:22 [Buildroot] [PATCH] Config.in: add BR2_HOST_GCC_AT_LEAST_9 Romain Naour
2020-02-25 22:23 ` Thomas Petazzoni
2020-02-26  8:24   ` Romain Naour

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox