From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/git: fix build failure due to gcc bug 93847
Date: Thu, 27 Feb 2020 09:17:25 +0100 [thread overview]
Message-ID: <20200227091725.05b1b0df@windsurf> (raw)
In-Reply-To: <871rqh56r3.fsf@dell.be.48ers.dk>
Hello Peter,
On Wed, 26 Feb 2020 23:22:08 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:
> > -ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
> > +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180)$(BR2_TOOLCHAIN_HAS_GCC_BUG_93847),y)
>
> This fails for a (hypothetical) toolchain affected by both issues,
> perhaps something like this would be better?
>
> ifneq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180)$(BR2_TOOLCHAIN_HAS_GCC_BUG_93847),)
True in the general case. But BR2_TOOLCHAIN_HAS_GCC_BUG_85180 only
applies to Microblaze, and BR2_TOOLCHAIN_HAS_GCC_BUG_93847 to NIOS2. So
practically speaking, they are mutually exclusive options, so the case
where both are enabled at the same time is impossible.
But I agree that in the general case what you showed would be
preferable.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-02-27 8:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 15:40 [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_GCC_BUG_93847 Giulio Benetti
2020-02-20 15:40 ` [Buildroot] [PATCH 2/2] package/git: fix build failure due to gcc bug 93847 Giulio Benetti
2020-02-26 21:15 ` Thomas Petazzoni
2020-02-26 22:22 ` Peter Korsgaard
2020-02-27 8:17 ` Thomas Petazzoni [this message]
2020-02-27 11:20 ` Giulio Benetti
2020-02-27 21:15 ` Yann E. MORIN
2020-02-27 21:42 ` Peter Korsgaard
2020-02-26 21:15 ` [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_GCC_BUG_93847 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227091725.05b1b0df@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox