From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/git: fix build failure due to gcc bug 93847
Date: Thu, 27 Feb 2020 22:15:49 +0100 [thread overview]
Message-ID: <20200227211549.GG8743@scaer> (raw)
In-Reply-To: <871rqh56r3.fsf@dell.be.48ers.dk>
Peter, All,
On 2020-02-26 23:22 +0100, Peter Korsgaard spake thusly:
> >>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
>
> > The git package exhibits gcc bug 93847 when built for the Nios2
> > architecture with optimization enabled, which causes a build failure.
>
> > As done for other packages in Buildroot work around this gcc bug by
> > setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_93847=y.
>
> > Fixes:
> > http://autobuild.buildroot.net/results/e22/e225e62ea2d48660df4110790664f0c3306c1ea9/
>
> > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> > ---
> > package/git/git.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> > diff --git a/package/git/git.mk b/package/git/git.mk
> > index a5c8669fc9..f32a2f8eb9 100644
> > --- a/package/git/git.mk
> > +++ b/package/git/git.mk
> > @@ -67,7 +67,7 @@ endif
>
> > GIT_CFLAGS = $(TARGET_CFLAGS)
>
> > -ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
> > +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180)$(BR2_TOOLCHAIN_HAS_GCC_BUG_93847),y)
>
> This fails for a (hypothetical) toolchain affected by both issues,
> perhaps something like this would be better?
>
> ifneq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180)$(BR2_TOOLCHAIN_HAS_GCC_BUG_93847),)
Or we can keep positive logic and use the available make utilities:
ifeq ($(or $(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),$(BR2_TOOLCHAIN_HAS_GCC_BUG_93847)),y)
Regards,
Yann E. MORIN.
> --
> Bye, Peter Korsgaard
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-02-27 21:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 15:40 [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_GCC_BUG_93847 Giulio Benetti
2020-02-20 15:40 ` [Buildroot] [PATCH 2/2] package/git: fix build failure due to gcc bug 93847 Giulio Benetti
2020-02-26 21:15 ` Thomas Petazzoni
2020-02-26 22:22 ` Peter Korsgaard
2020-02-27 8:17 ` Thomas Petazzoni
2020-02-27 11:20 ` Giulio Benetti
2020-02-27 21:15 ` Yann E. MORIN [this message]
2020-02-27 21:42 ` Peter Korsgaard
2020-02-26 21:15 ` [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_GCC_BUG_93847 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227211549.GG8743@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox