[Buildroot] [PATCH 1/3] fs/cramfs: add depends on !BR2_PACKAGE_LIBSELINUX

[Buildroot] [PATCH 1/3] fs/cramfs: add depends on !BR2_PACKAGE_LIBSELINUX

[aduskett at gmail.com]

From: Adam Duskett <Aduskett@gmail.com>

cramfs does not support extended attributes (xattrs) needed for SELinux to
function.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
 fs/cramfs/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/cramfs/Config.in b/fs/cramfs/Config.in
index 89f8ad52b8..891efade3b 100644
--- a/fs/cramfs/Config.in
+++ b/fs/cramfs/Config.in
@@ -1,5 +1,6 @@
 config BR2_TARGET_ROOTFS_CRAMFS
 	bool "cramfs root filesystem"
+	depends on !BR2_PACKAGE_LIBSELINUX
 	help
 	  Build a cramfs root filesystem
 
@@ -24,3 +25,6 @@ config BR2_TARGET_ROOTFS_CRAMFS_XIP
 	  4.15+ kernel.
 
 endif # BR2_TARGET_ROOTFS_CRAMFS
+
+comment "cramfs does not support SELinux"
+	depends on BR2_PACKAGE_LIBSELINUX
-- 
2.24.1

[Buildroot] [PATCH 2/3] fs/romfs: add depends on !BR2_PACKAGE_LIBSELINUX

[aduskett at gmail.com]

From: Adam Duskett <Aduskett@gmail.com>

romfs does not support extended attributes (xattrs) needed for SELinux to
function.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
 fs/romfs/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/romfs/Config.in b/fs/romfs/Config.in
index 84944a0fc0..055f5eedd7 100644
--- a/fs/romfs/Config.in
+++ b/fs/romfs/Config.in
@@ -1,4 +1,8 @@
 config BR2_TARGET_ROOTFS_ROMFS
 	bool "romfs root filesystem"
+	depends on !BR2_PACKAGE_LIBSELINUX
 	help
 	  Build a romfs image of the root filesystem.
+
+comment "romfs does not support SELinux"
+	depends on BR2_PACKAGE_LIBSELINUX
-- 
2.24.1

[Buildroot] [PATCH 3/3] fss/yaffs2: add depends on !BR2_PACKAGE_LIBSELINUX

[aduskett at gmail.com]

From: Adam Duskett <Aduskett@gmail.com>

yaffs2 does not support extended attributes (xattrs) needed for SELinux to
function.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
 fs/yaffs2/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/yaffs2/Config.in b/fs/yaffs2/Config.in
index 27da4ba638..99c25c4066 100644
--- a/fs/yaffs2/Config.in
+++ b/fs/yaffs2/Config.in
@@ -1,4 +1,8 @@
 config BR2_TARGET_ROOTFS_YAFFS2
 	bool "yaffs2 root filesystem"
+	depends on !BR2_PACKAGE_LIBSELINUX
 	help
 	  Build a yaffs2 root filesystem
+
+comment "yaffs2 does not support SELinux"
+	depends on BR2_PACKAGE_LIBSELINUX
-- 
2.24.1

[Buildroot] [PATCH 1/3] fs/cramfs: add depends on !BR2_PACKAGE_LIBSELINUX

[Thomas Petazzoni]

Hello,

On Thu, 12 Mar 2020 11:29:38 -0700
aduskett at gmail.com wrote:

> From: Adam Duskett <Aduskett@gmail.com>
> 
> cramfs does not support extended attributes (xattrs) needed for SELinux to
> function.
> 
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>

I quickly discussed this with Peter on IRC, and we both agreed we
didn't like these direct dependencies.

One solution I suggested is to do something like this:

 - Introduce some hidden boolean like BR2_SYSTEM_NEEDS_XATTR_FS (or
   some better name)

 - Have libselinux select this

 - Have the filesystems that don't support xattr have a depends on
   !BR2_SYSTEM_NEEDS_XATTR_FS.

I'm just not sure about where to define BR2_SYSTEM_NEEDS_XATTR_FS, and
I'm not sure about the naming. Should it be in fs/Config.in? In
system/Config.in?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com