* [Buildroot] [PATCH 1/1] package/gssdp: explicitly disable vapi
@ 2020-03-15 16:41 aduskett at gmail.com
2020-03-15 16:47 ` Yann E. MORIN
2020-03-21 21:31 ` Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: aduskett at gmail.com @ 2020-03-15 16:41 UTC (permalink / raw)
To: buildroot
From: Adam Duskett <Aduskett@gmail.com>
Currently, vapi support does not work with meson due to meson calling vapigen
directly instead of the vala wrapper. As such, when building typelib files for
gobject-introspection, vapigen fails to find the proper .gir files and fails
to build.
Explicitly disable vapi until a fix for vapi is made.
Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
package/gssdp/gssdp.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/gssdp/gssdp.mk b/package/gssdp/gssdp.mk
index 4589517691..071ad00109 100644
--- a/package/gssdp/gssdp.mk
+++ b/package/gssdp/gssdp.mk
@@ -14,7 +14,8 @@ GSSDP_INSTALL_STAGING = YES
GSSDP_DEPENDENCIES = host-pkgconf libglib2 libsoup
GSSDP_CONF_OPTS = \
-Dexamples=false \
- -Dintrospection=false
+ -Dintrospection=false \
+ -Dvapi=false
ifeq ($(BR2_PACKAGE_LIBGTK3),y)
GSSDP_DEPENDENCIES += libgtk3
--
2.24.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/gssdp: explicitly disable vapi
2020-03-15 16:41 [Buildroot] [PATCH 1/1] package/gssdp: explicitly disable vapi aduskett at gmail.com
@ 2020-03-15 16:47 ` Yann E. MORIN
2020-03-15 17:21 ` Yann E. MORIN
2020-03-21 21:31 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2020-03-15 16:47 UTC (permalink / raw)
To: buildroot
Adam, All,
On 2020-03-15 09:41 -0700, aduskett at gmail.com spake thusly:
> From: Adam Duskett <Aduskett@gmail.com>
>
> Currently, vapi support does not work with meson due to meson calling vapigen
> directly instead of the vala wrapper. As such, when building typelib files for
> gobject-introspection, vapigen fails to find the proper .gir files and fails
> to build.
>
> Explicitly disable vapi until a fix for vapi is made.
>
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
> package/gssdp/gssdp.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/gssdp/gssdp.mk b/package/gssdp/gssdp.mk
> index 4589517691..071ad00109 100644
> --- a/package/gssdp/gssdp.mk
> +++ b/package/gssdp/gssdp.mk
> @@ -14,7 +14,8 @@ GSSDP_INSTALL_STAGING = YES
> GSSDP_DEPENDENCIES = host-pkgconf libglib2 libsoup
> GSSDP_CONF_OPTS = \
> -Dexamples=false \
> - -Dintrospection=false
> + -Dintrospection=false \
> + -Dvapi=false
Sorry, no: that's two different fixes, so should be two different
patches:
- one to explicitly disable vapi support
- one to enable instrospection
Regards,
Yann E. MORIN.
> ifeq ($(BR2_PACKAGE_LIBGTK3),y)
> GSSDP_DEPENDENCIES += libgtk3
> --
> 2.24.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/gssdp: explicitly disable vapi
2020-03-15 16:47 ` Yann E. MORIN
@ 2020-03-15 17:21 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2020-03-15 17:21 UTC (permalink / raw)
To: buildroot
Adam, All,
On 2020-03-15 17:47 +0100, Yann E. MORIN spake thusly:
> On 2020-03-15 09:41 -0700, aduskett at gmail.com spake thusly:
> > From: Adam Duskett <Aduskett@gmail.com>
> > Currently, vapi support does not work with meson due to meson calling vapigen
> > directly instead of the vala wrapper. As such, when building typelib files for
> > gobject-introspection, vapigen fails to find the proper .gir files and fails
> > to build.
> >
> > Explicitly disable vapi until a fix for vapi is made.
> >
> > Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> > ---
> > package/gssdp/gssdp.mk | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/package/gssdp/gssdp.mk b/package/gssdp/gssdp.mk
> > index 4589517691..071ad00109 100644
> > --- a/package/gssdp/gssdp.mk
> > +++ b/package/gssdp/gssdp.mk
> > @@ -14,7 +14,8 @@ GSSDP_INSTALL_STAGING = YES
> > GSSDP_DEPENDENCIES = host-pkgconf libglib2 libsoup
> > GSSDP_CONF_OPTS = \
> > -Dexamples=false \
> > - -Dintrospection=false
> > + -Dintrospection=false \
> > + -Dvapi=false
>
> Sorry, no: that's two different fixes, so should be two different
> patches:
> - one to explicitly disable vapi support
> - one to enable instrospection
And I was being stupid here: the patch does not enable introspection, so
it is good...
Applied to master, thanks.
Regards,
Yann E. MORIN.
> Regards,
> Yann E. MORIN.
>
> > ifeq ($(BR2_PACKAGE_LIBGTK3),y)
> > GSSDP_DEPENDENCIES += libgtk3
> > --
> > 2.24.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/gssdp: explicitly disable vapi
2020-03-15 16:41 [Buildroot] [PATCH 1/1] package/gssdp: explicitly disable vapi aduskett at gmail.com
2020-03-15 16:47 ` Yann E. MORIN
@ 2020-03-21 21:31 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2020-03-21 21:31 UTC (permalink / raw)
To: buildroot
>>>>> "aduskett" == aduskett <aduskett@gmail.com> writes:
> From: Adam Duskett <Aduskett@gmail.com>
> Currently, vapi support does not work with meson due to meson calling vapigen
> directly instead of the vala wrapper. As such, when building typelib files for
> gobject-introspection, vapigen fails to find the proper .gir files and fails
> to build.
> Explicitly disable vapi until a fix for vapi is made.
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
Committed to 2020.02.x and 2019.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-21 21:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-15 16:41 [Buildroot] [PATCH 1/1] package/gssdp: explicitly disable vapi aduskett at gmail.com
2020-03-15 16:47 ` Yann E. MORIN
2020-03-15 17:21 ` Yann E. MORIN
2020-03-21 21:31 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox