* [Buildroot] [PATCH 1/1] package/rcw : bump to LSDK-19.09
@ 2020-03-18 7:14 Laurent Hartanerot
2020-03-18 21:12 ` Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Laurent Hartanerot @ 2020-03-18 7:14 UTC (permalink / raw)
To: buildroot
From: Laurent Hartanerot <laurent.hartanerot@atos.net>
Upgrade python to python3 : "Only Python versions 3.0+ are supported"
Signed-off-by: Laurent Hartanerot <laurent.hartanerot@atos.net>
---
package/rcw/rcw.hash | 2 +-
package/rcw/rcw.mk | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash
index 7de1ec659a..76b6373942 100644
--- a/package/rcw/rcw.hash
+++ b/package/rcw/rcw.hash
@@ -1,3 +1,3 @@
# Locally calculated
-sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz
+sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz
sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE
diff --git a/package/rcw/rcw.mk b/package/rcw/rcw.mk
index 81e22fff93..5081b1c646 100644
--- a/package/rcw/rcw.mk
+++ b/package/rcw/rcw.mk
@@ -4,7 +4,7 @@
#
################################################################################
-RCW_VERSION = LSDK-18.12
+RCW_VERSION = LSDK-19.09
RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw
RCW_SITE_METHOD = git
RCW_LICENSE = BSD-3-Clause
@@ -39,7 +39,7 @@ endef
HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES
define HOST_RCW_BUILD_CMDS
- python $(@D)/rcw.py -i $(@D)/custom_board/rcw/$(RCW_PROJECT) -I $(@D)/custom_board -o $(@D)/PBL.bin
+ python3 $(@D)/rcw.py -i $(@D)/custom_board/rcw/$(RCW_PROJECT) -I $(@D)/custom_board -o $(@D)/PBL.bin
endef
define HOST_RCW_INSTALL_DELIVERY_FILE
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [Buildroot] [PATCH 1/1] package/rcw : bump to LSDK-19.09 2020-03-18 7:14 [Buildroot] [PATCH 1/1] package/rcw : bump to LSDK-19.09 Laurent Hartanerot @ 2020-03-18 21:12 ` Thomas Petazzoni 2020-03-22 10:31 ` [Buildroot] [PATCH v2 " Laurent Hartanerot 2020-03-22 16:24 ` [Buildroot] [PATCH v3 " Laurent Hartanerot 2 siblings, 0 replies; 12+ messages in thread From: Thomas Petazzoni @ 2020-03-18 21:12 UTC (permalink / raw) To: buildroot Hello Laurent, Thanks for your contribution, see below for a review. On Wed, 18 Mar 2020 08:14:27 +0100 Laurent Hartanerot <laurent.hartanerot@gmail.com> wrote: > From: Laurent Hartanerot <laurent.hartanerot@atos.net> > > Upgrade python to python3 : "Only Python versions 3.0+ are supported" > > Signed-off-by: Laurent Hartanerot <laurent.hartanerot@atos.net> > --- > package/rcw/rcw.hash | 2 +- > package/rcw/rcw.mk | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash > index 7de1ec659a..76b6373942 100644 > --- a/package/rcw/rcw.hash > +++ b/package/rcw/rcw.hash > @@ -1,3 +1,3 @@ > # Locally calculated > -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz > +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz > sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE > diff --git a/package/rcw/rcw.mk b/package/rcw/rcw.mk > index 81e22fff93..5081b1c646 100644 > --- a/package/rcw/rcw.mk > +++ b/package/rcw/rcw.mk > @@ -4,7 +4,7 @@ > # > ################################################################################ > > -RCW_VERSION = LSDK-18.12 > +RCW_VERSION = LSDK-19.09 > RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw > RCW_SITE_METHOD = git > RCW_LICENSE = BSD-3-Clause > @@ -39,7 +39,7 @@ endef > HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES > > define HOST_RCW_BUILD_CMDS > - python $(@D)/rcw.py -i $(@D)/custom_board/rcw/$(RCW_PROJECT) -I $(@D)/custom_board -o $(@D)/PBL.bin > + python3 $(@D)/rcw.py -i $(@D)/custom_board/rcw/$(RCW_PROJECT) -I $(@D)/custom_board -o $(@D)/PBL.bin We don't have any guarantee that python3 is available on the build machine. And in fact, since commit 9c0c7846cdb63f3ed62563c4f532ad02ad0a1c98 we also don't have the guarantee that python is available on the build machine. So, here, we would need two patches: - A first patch that is a fix to the package in its current version. It should add host-python to its dependencies, and make sure $(HOST_DIR)/bin/python gets used. This way, the patch can be backported to our LTS branch 2020.02. - A second patch that bumps the package to LSDK-19.09, switches to using $(BR2_PYTHON3_HOST_DEPENDENCY) in HOST_RCW_DEPENDENCIES, and then be careful to use python3, but with $(HOST_DIR)/bin in the PATH, so that either the system-wide python3 is used, or the one built by Buildroot. Could you look into doing this ? Thanks a lot! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/rcw : bump to LSDK-19.09 2020-03-18 7:14 [Buildroot] [PATCH 1/1] package/rcw : bump to LSDK-19.09 Laurent Hartanerot 2020-03-18 21:12 ` Thomas Petazzoni @ 2020-03-22 10:31 ` Laurent Hartanerot 2020-03-22 13:12 ` Yann E. MORIN 2020-03-22 16:24 ` [Buildroot] [PATCH v3 " Laurent Hartanerot 2 siblings, 1 reply; 12+ messages in thread From: Laurent Hartanerot @ 2020-03-22 10:31 UTC (permalink / raw) To: buildroot From: Laurent Hartanerot <laurent.hartanerot@atos.net> Upgrade python to python3 : "Only Python versions 3.0+ are supported" Signed-off-by: Laurent Hartanerot <laurent.hartanerot@atos.net> --- package/rcw/rcw.hash | 2 +- package/rcw/rcw.mk | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash index 7de1ec659a..76b6373942 100644 --- a/package/rcw/rcw.hash +++ b/package/rcw/rcw.hash @@ -1,3 +1,3 @@ # Locally calculated -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE diff --git a/package/rcw/rcw.mk b/package/rcw/rcw.mk index dbfeae7b21..928135abfc 100644 --- a/package/rcw/rcw.mk +++ b/package/rcw/rcw.mk @@ -4,13 +4,13 @@ # ################################################################################ -RCW_VERSION = LSDK-18.12 +RCW_VERSION = LSDK-19.09 RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw RCW_SITE_METHOD = git RCW_LICENSE = BSD-3-Clause RCW_LICENSE_FILES = LICENSE -HOST_RCW_DEPENDENCIES = host-python +HOST_RCW_DEPENDENCIES = host-python3 RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH)) @@ -41,7 +41,7 @@ endef HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES define HOST_RCW_BUILD_CMDS - $(HOST_DIR)/bin/python $(@D)/rcw.py \ + $(HOST_DIR)/bin/python3 $(@D)/rcw.py \ -i $(@D)/custom_board/rcw/$(RCW_PROJECT) \ -I $(@D)/custom_board -o $(@D)/PBL.bin endef -- 2.20.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/rcw : bump to LSDK-19.09 2020-03-22 10:31 ` [Buildroot] [PATCH v2 " Laurent Hartanerot @ 2020-03-22 13:12 ` Yann E. MORIN 2020-03-22 14:51 ` Laurent Hartanerot 0 siblings, 1 reply; 12+ messages in thread From: Yann E. MORIN @ 2020-03-22 13:12 UTC (permalink / raw) To: buildroot Laurent, All, On 2020-03-22 11:31 +0100, Laurent Hartanerot spake thusly: > From: Laurent Hartanerot <laurent.hartanerot@atos.net> > > Upgrade python to python3 : "Only Python versions 3.0+ are supported" > > Signed-off-by: Laurent Hartanerot <laurent.hartanerot@atos.net> > --- > package/rcw/rcw.hash | 2 +- > package/rcw/rcw.mk | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash > index 7de1ec659a..76b6373942 100644 > --- a/package/rcw/rcw.hash > +++ b/package/rcw/rcw.hash > @@ -1,3 +1,3 @@ > # Locally calculated > -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz > +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz > sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE > diff --git a/package/rcw/rcw.mk b/package/rcw/rcw.mk > index dbfeae7b21..928135abfc 100644 > --- a/package/rcw/rcw.mk > +++ b/package/rcw/rcw.mk > @@ -4,13 +4,13 @@ > # > ################################################################################ > > -RCW_VERSION = LSDK-18.12 > +RCW_VERSION = LSDK-19.09 > RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw > RCW_SITE_METHOD = git > RCW_LICENSE = BSD-3-Clause > RCW_LICENSE_FILES = LICENSE > > -HOST_RCW_DEPENDENCIES = host-python > +HOST_RCW_DEPENDENCIES = host-python3 As far as I can see, that's not what Thomas requested in his previous review http://lists.busybox.net/pipermail/buildroot/2020-March/277531.html Thomas requested that the bump be split in two changes: - a first patch that does not update the version, but adds the missing dependency to host-python, making sure to use by replacing the call to 'python' by a call to $(HOST_DIR)/bin/python, so that we can backport that fix into our LTS branch, 2020.02; - a second patch that does the version bump, and in the process, changes the dependency on host-python to using the conditional depednency set in the variable $(BR2_PYTHON3_HOST_DEPENDENCY). If you have issues with the above, then do not hesitate to explain your concerns, instead of re-sending almost exactly the same change. In the meantime, I've marked the patch as changes-requested in patchwork. Regards, Yann E. MORIN. > RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH)) > > @@ -41,7 +41,7 @@ endef > HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES > > define HOST_RCW_BUILD_CMDS > - $(HOST_DIR)/bin/python $(@D)/rcw.py \ > + $(HOST_DIR)/bin/python3 $(@D)/rcw.py \ > -i $(@D)/custom_board/rcw/$(RCW_PROJECT) \ > -I $(@D)/custom_board -o $(@D)/PBL.bin > endef > -- > 2.20.1 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/rcw : bump to LSDK-19.09 2020-03-22 13:12 ` Yann E. MORIN @ 2020-03-22 14:51 ` Laurent Hartanerot 2020-03-22 15:18 ` Yann E. MORIN 0 siblings, 1 reply; 12+ messages in thread From: Laurent Hartanerot @ 2020-03-22 14:51 UTC (permalink / raw) To: buildroot Hello Yann, Thank you for the feedback, - I thought I followed the explanations by making a first patch : https://patchwork.ozlabs.org/patch/1258063/ and the second patch (this) for the version bump... Maybe, I shouldn't have done it in response to this email (--in-reply-to=) - I take this opportunity to explain why I have not used +HOST_RCW_DEPENDENCIES = $(BR2_PYTHON3_HOST_DEPENDENCY) but +HOST_RCW_DEPENDENCIES = host-python3 in the first case the host-python3 dependency is not added When I check the varaibles (in the first case) I get : $ make printvars "VARS=HOST_RCW_DEPENDENCIES" HOST_RCW_DEPENDENCIES= host-skeleton $ make printvars "VARS=BR2_PYTHON3_HOST_DEPENDENCY" but in the second case : $ make printvars "VARS=BR2_PYTHON3_HOST_DEPENDENCY" $ make printvars "VARS=HOST_RCW_DEPENDENCIES" HOST_RCW_DEPENDENCIES=host-python3 host-skeleton I don't find the reason why $(BR2_PYTHON3_HOST_DEPENDENCY) is not equals to host-python3. Thanks for support Le dim. 22 mars 2020 ? 14:13, Yann E. MORIN <yann.morin.1998@free.fr> a ?crit : > Laurent, All, > > On 2020-03-22 11:31 +0100, Laurent Hartanerot spake thusly: > > From: Laurent Hartanerot <laurent.hartanerot@atos.net> > > > > Upgrade python to python3 : "Only Python versions 3.0+ are supported" > > > > Signed-off-by: Laurent Hartanerot <laurent.hartanerot@atos.net> > > --- > > package/rcw/rcw.hash | 2 +- > > package/rcw/rcw.mk | 6 +++--- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash > > index 7de1ec659a..76b6373942 100644 > > --- a/package/rcw/rcw.hash > > +++ b/package/rcw/rcw.hash > > @@ -1,3 +1,3 @@ > > # Locally calculated > > -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 > rcw-LSDK-18.12.tar.gz > > +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 > rcw-LSDK-19.09.tar.gz > > sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd > LICENSE > > diff --git a/package/rcw/rcw.mk b/package/rcw/rcw.mk > > index dbfeae7b21..928135abfc 100644 > > --- a/package/rcw/rcw.mk > > +++ b/package/rcw/rcw.mk > > @@ -4,13 +4,13 @@ > > # > > > ################################################################################ > > > > -RCW_VERSION = LSDK-18.12 > > +RCW_VERSION = LSDK-19.09 > > RCW_SITE = > https://source.codeaurora.org/external/qoriq/qoriq-components/rcw > > RCW_SITE_METHOD = git > > RCW_LICENSE = BSD-3-Clause > > RCW_LICENSE_FILES = LICENSE > > > > -HOST_RCW_DEPENDENCIES = host-python > > +HOST_RCW_DEPENDENCIES = host-python3 > > As far as I can see, that's not what Thomas requested in his previous > review http://lists.busybox.net/pipermail/buildroot/2020-March/277531.html > > Thomas requested that the bump be split in two changes: > > - a first patch that does not update the version, but adds the missing > dependency to host-python, making sure to use by replacing the call > to 'python' by a call to $(HOST_DIR)/bin/python, so that we can > backport that fix into our LTS branch, 2020.02; > > - a second patch that does the version bump, and in the process, > changes the dependency on host-python to using the conditional > depednency set in the variable $(BR2_PYTHON3_HOST_DEPENDENCY). > > If you have issues with the above, then do not hesitate to explain your > concerns, instead of re-sending almost exactly the same change. > > In the meantime, I've marked the patch as changes-requested in patchwork. > > Regards, > Yann E. MORIN. > > > RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH)) > > > > @@ -41,7 +41,7 @@ endef > > HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES > > > > define HOST_RCW_BUILD_CMDS > > - $(HOST_DIR)/bin/python $(@D)/rcw.py \ > > + $(HOST_DIR)/bin/python3 $(@D)/rcw.py \ > > -i $(@D)/custom_board/rcw/$(RCW_PROJECT) \ > > -I $(@D)/custom_board -o $(@D)/PBL.bin > > endef > > -- > > 2.20.1 > > > > _______________________________________________ > > buildroot mailing list > > buildroot at busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > > -- > > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' > conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ > | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is > no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v > conspiracy. | > > '------------------------------^-------^------------------^--------------------' > -- Laurent HARTANEROT Laurent.Hartanerot at gmail.com tel : 06 49 14 93 74 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200322/8f66a89c/attachment.html> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/rcw : bump to LSDK-19.09 2020-03-22 14:51 ` Laurent Hartanerot @ 2020-03-22 15:18 ` Yann E. MORIN 2020-03-22 15:29 ` Laurent Hartanerot 0 siblings, 1 reply; 12+ messages in thread From: Yann E. MORIN @ 2020-03-22 15:18 UTC (permalink / raw) To: buildroot Laurent, All, On 2020-03-22 15:51 +0100, Laurent Hartanerot spake thusly: > Hello Yann, > Thank you for the feedback, > - I thought I followed the explanations by making a first patch : > [1]https://patchwork.ozlabs.org/patch/1258063/ > and the second patch (this) for the version bump... > Maybe, I shouldn't have done it in response to this email (--in-reply-to=) Ah, sorry, I had missed that one (and so did not completely understand where the existing dependency on host-python came from... My bad. > - I take this opportunity to explain why I have not used > +HOST_RCW_DEPENDENCIES = $(BR2_PYTHON3_HOST_DEPENDENCY) > but > +HOST_RCW_DEPENDENCIES = host-python3 > in the first case the host-python3 dependency is not added > When I check the varaibles (in the first case) I get : > $ make printvars "VARS=HOST_RCW_DEPENDENCIES" > HOST_RCW_DEPENDENCIES= host-skeleton > $ make printvars "VARS=BR2_PYTHON3_HOST_DEPENDENCY" > but in the second case : > $ make printvars "VARS=BR2_PYTHON3_HOST_DEPENDENCY" > $ make printvars "VARS=HOST_RCW_DEPENDENCIES" > HOST_RCW_DEPENDENCIES=host-python3 host-skeleton > I don't find the reason why $(BR2_PYTHON3_HOST_DEPENDENCY) is not equals to host-python3. That's probably because you already have a python3 installed in your machine? That's exactly the purpose of BR2_PYTHON3_HOST_DEPENDENCY: if the build machine already has a python3 (3.4 or later), then there is no need to build our own. If the build machine does not already have python3 or it is older than 3.4, then we need to build our own. See: support/dependencies/check-host-python3.mk support/dependencies/check-host-python3.sh Regards, Yann E. MORIN. > Thanks for support > Le?dim. 22 mars 2020 ??14:13, Yann E. MORIN < [2]yann.morin.1998@free.fr> a ?crit?: > > Laurent, All, > > On 2020-03-22 11:31 +0100, Laurent Hartanerot spake thusly: > > From: Laurent Hartanerot < [3]laurent.hartanerot@atos.net> > > > > Upgrade python to python3 : "Only Python versions 3.0+ are supported" > > > > Signed-off-by: Laurent Hartanerot < [4]laurent.hartanerot@atos.net> > > --- > >? package/rcw/rcw.hash | 2 +- > >? package/rcw/ [5]rcw.mk? ?| 6 +++--- > >? 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash > > index 7de1ec659a..76b6373942 100644 > > --- a/package/rcw/rcw.hash > > +++ b/package/rcw/rcw.hash > > @@ -1,3 +1,3 @@ > >? # Locally calculated > > -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz > > +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz > >? sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE > > diff --git a/package/rcw/ [6]rcw.mk b/package/rcw/ [7]rcw.mk > > index dbfeae7b21..928135abfc 100644 > > --- a/package/rcw/ [8]rcw.mk > > +++ b/package/rcw/ [9]rcw.mk > > @@ -4,13 +4,13 @@ > >? # > >? ################################################################################ > >? > > -RCW_VERSION = LSDK-18.12 > > +RCW_VERSION = LSDK-19.09 > >? RCW_SITE = [10]https://source.codeaurora.org/external/qoriq/qoriq-components/rcw > >? RCW_SITE_METHOD = git > >? RCW_LICENSE = BSD-3-Clause > >? RCW_LICENSE_FILES = LICENSE > >? > > -HOST_RCW_DEPENDENCIES = host-python > > +HOST_RCW_DEPENDENCIES = host-python3 > > As far as I can see, that's not what Thomas requested in his previous > review [11]http://lists.busybox.net/pipermail/buildroot/2020-March/277531.html > > Thomas requested that the bump be split in two changes: > > ? - a first patch that does not update the version, but adds the missing > ? ? dependency to host-python, making sure to use by replacing the call > ? ? to 'python' by a call to $(HOST_DIR)/bin/python, so that we can > ? ? backport that fix into our LTS branch, 2020.02; > > ? - a second patch that does the version bump, and in the process, > ? ? changes the dependency on host-python to using the conditional > ? ? depednency set in the variable $(BR2_PYTHON3_HOST_DEPENDENCY). > > If you have issues with the above, then do not hesitate to explain your > concerns, instead of re-sending almost exactly the same change. > > In the meantime, I've marked the patch as changes-requested in patchwork. > > Regards, > Yann E. MORIN. > > >? RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH)) > >? > > @@ -41,7 +41,7 @@ endef > >? HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES > >? > >? define HOST_RCW_BUILD_CMDS > > -? ? ?$(HOST_DIR)/bin/python $(@D)/rcw.py \ > > +? ? ?$(HOST_DIR)/bin/python3 $(@D)/rcw.py \ > >? ? ? ? ? ? ? ?-i $(@D)/custom_board/rcw/$(RCW_PROJECT) \ > >? ? ? ? ? ? ? ?-I $(@D)/custom_board -o $(@D)/PBL.bin > >? endef > > -- > > 2.20.1 > > > > _______________________________________________ > > buildroot mailing list > > [12]buildroot at busybox.net > > [13]http://lists.busybox.net/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > |? Yann E. MORIN? | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software? Designer | \ / CAMPAIGN? ? ?|? ___? ? ? ? ? ? > ? ?| > | +33 561 099 427 `------------.-------:? X? AGAINST? ? ? |? \e/? There is no? | > | [14]http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL? ? |? ?v? ?conspiracy.? | > '------------------------------^-------^------------------^--------------------' > > -- > Laurent HARTANEROT > [15]Laurent.Hartanerot at gmail.com > tel : 06 49 14 93 74 > > Links: > 1. https://patchwork.ozlabs.org/patch/1258063/ > 2. mailto:yann.morin.1998 at free.fr > 3. mailto:laurent.hartanerot at atos.net > 4. mailto:laurent.hartanerot at atos.net > 5. http://rcw.mk > 6. http://rcw.mk > 7. http://rcw.mk > 8. http://rcw.mk > 9. http://rcw.mk > 10. https://source.codeaurora.org/external/qoriq/qoriq-components/rcw > 11. http://lists.busybox.net/pipermail/buildroot/2020-March/277531.html > 12. mailto:buildroot at busybox.net > 13. http://lists.busybox.net/mailman/listinfo/buildroot > 14. http://ymorin.is-a-geek.org/ > 15. mailto:Laurent.Hartanerot at gmail.com -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/rcw : bump to LSDK-19.09 2020-03-22 15:18 ` Yann E. MORIN @ 2020-03-22 15:29 ` Laurent Hartanerot 2020-03-22 15:48 ` Yann E. MORIN 0 siblings, 1 reply; 12+ messages in thread From: Laurent Hartanerot @ 2020-03-22 15:29 UTC (permalink / raw) To: buildroot Yann, All, That's probably because you already have a python3 installed in your > machine? > Yes it is. > > That's exactly the purpose of BR2_PYTHON3_HOST_DEPENDENCY: if the > build machine already has a python3 (3.4 or later), then there is no > need to build our own. If the build machine does not already have > python3 or it is older than 3.4, then we need to build our own. > > See: > support/dependencies/check-host-python3.mk > support/dependencies/check-host-python3.sh > I understand that. But, in this case, we cannot use the syntax ($(HOST_DIR)/bin/python3). What is the correct syntax ? > Links: > > 1. https://patchwork.ozlabs.org/patch/1258063/ > > 2. mailto:yann.morin.1998 at free.fr > > 3. mailto:laurent.hartanerot at atos.net > > 4. mailto:laurent.hartanerot at atos.net > > 5. http://rcw.mk > > 6. http://rcw.mk > > 7. http://rcw.mk > > 8. http://rcw.mk > > 9. http://rcw.mk > > 10. https://source.codeaurora.org/external/qoriq/qoriq-components/rcw > > 11. http://lists.busybox.net/pipermail/buildroot/2020-March/277531.html > > 12. mailto:buildroot at busybox.net > > 13. http://lists.busybox.net/mailman/listinfo/buildroot > > 14. http://ymorin.is-a-geek.org/ > > 15. mailto:Laurent.Hartanerot at gmail.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200322/9f4db92f/attachment.html> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/rcw : bump to LSDK-19.09 2020-03-22 15:29 ` Laurent Hartanerot @ 2020-03-22 15:48 ` Yann E. MORIN 0 siblings, 0 replies; 12+ messages in thread From: Yann E. MORIN @ 2020-03-22 15:48 UTC (permalink / raw) To: buildroot Laurent, All, On 2020-03-22 16:29 +0100, Laurent Hartanerot spake thusly: > That's exactly the purpose of BR2_PYTHON3_HOST_DEPENDENCY: if the > build machine already has a python3 (3.4 or later), then there is no > need to build our own. If the build machine does not already have > python3 or it is older than 3.4, then we need to build our own. > > See: > ? ? support/dependencies/ [1]check-host-python3.mk > ? ? support/dependencies/check-host-python3.sh > > ? > I understand that. > But, in this case, we cannot use the syntax ($(HOST_DIR)/bin/python3). > What is the correct syntax ? Ah, right, I see your problem: you are calling directly to python3. What you should be able to do then, is something like: PATH="$(BR_PATH)"; \ python3 blablabla... Regards, Yann E. MORIN. > > Links: > > 1. [2]https://patchwork.ozlabs.org/patch/1258063/ > > 2. mailto: [3]yann.morin.1998 at free.fr > > 3. mailto: [4]laurent.hartanerot at atos.net > > 4. mailto: [5]laurent.hartanerot at atos.net > > 5. [6]http://rcw.mk > > 6. [7]http://rcw.mk > > 7. [8]http://rcw.mk > > 8. [9]http://rcw.mk > > 9. [10]http://rcw.mk > > 10. [11]https://source.codeaurora.org/external/qoriq/qoriq-components/rcw > > 11. [12]http://lists.busybox.net/pipermail/buildroot/2020-March/277531.html > > 12. mailto: [13]buildroot at busybox.net > > 13. [14]http://lists.busybox.net/mailman/listinfo/buildroot > > 14. [15]http://ymorin.is-a-geek.org/ > > 15. mailto: [16]Laurent.Hartanerot at gmail.com > > Links: > 1. http://check-host-python3.mk > 2. https://patchwork.ozlabs.org/patch/1258063/ > 3. mailto:yann.morin.1998 at free.fr > 4. mailto:laurent.hartanerot at atos.net > 5. mailto:laurent.hartanerot at atos.net > 6. http://rcw.mk > 7. http://rcw.mk > 8. http://rcw.mk > 9. http://rcw.mk > 10. http://rcw.mk > 11. https://source.codeaurora.org/external/qoriq/qoriq-components/rcw > 12. http://lists.busybox.net/pipermail/buildroot/2020-March/277531.html > 13. mailto:buildroot at busybox.net > 14. http://lists.busybox.net/mailman/listinfo/buildroot > 15. http://ymorin.is-a-geek.org/ > 16. mailto:Laurent.Hartanerot at gmail.com -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v3 1/1] package/rcw : bump to LSDK-19.09 2020-03-18 7:14 [Buildroot] [PATCH 1/1] package/rcw : bump to LSDK-19.09 Laurent Hartanerot 2020-03-18 21:12 ` Thomas Petazzoni 2020-03-22 10:31 ` [Buildroot] [PATCH v2 " Laurent Hartanerot @ 2020-03-22 16:24 ` Laurent Hartanerot 2020-03-22 21:09 ` Yann E. MORIN 2 siblings, 1 reply; 12+ messages in thread From: Laurent Hartanerot @ 2020-03-22 16:24 UTC (permalink / raw) To: buildroot From: Laurent Hartanerot <laurent.hartanerot@atos.net> Upgrade python to python3 : "Only Python versions 3.0+ are supported" Signed-off-by: Laurent Hartanerot <laurent.hartanerot@atos.net> --- package/rcw/rcw.hash | 2 +- package/rcw/rcw.mk | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash index 7de1ec659a..76b6373942 100644 --- a/package/rcw/rcw.hash +++ b/package/rcw/rcw.hash @@ -1,3 +1,3 @@ # Locally calculated -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE diff --git a/package/rcw/rcw.mk b/package/rcw/rcw.mk index dbfeae7b21..10e357ed69 100644 --- a/package/rcw/rcw.mk +++ b/package/rcw/rcw.mk @@ -4,13 +4,13 @@ # ################################################################################ -RCW_VERSION = LSDK-18.12 +RCW_VERSION = LSDK-19.09 RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw RCW_SITE_METHOD = git RCW_LICENSE = BSD-3-Clause RCW_LICENSE_FILES = LICENSE -HOST_RCW_DEPENDENCIES = host-python +HOST_RCW_DEPENDENCIES = $(BR2_PYTHON3_HOST_DEPENDENCY) RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH)) @@ -41,7 +41,7 @@ endef HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES define HOST_RCW_BUILD_CMDS - $(HOST_DIR)/bin/python $(@D)/rcw.py \ + python3 $(@D)/rcw.py \ -i $(@D)/custom_board/rcw/$(RCW_PROJECT) \ -I $(@D)/custom_board -o $(@D)/PBL.bin endef -- 2.20.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v3 1/1] package/rcw : bump to LSDK-19.09 2020-03-22 16:24 ` [Buildroot] [PATCH v3 " Laurent Hartanerot @ 2020-03-22 21:09 ` Yann E. MORIN 2020-03-23 6:56 ` Laurent Hartanerot 0 siblings, 1 reply; 12+ messages in thread From: Yann E. MORIN @ 2020-03-22 21:09 UTC (permalink / raw) To: buildroot Laurent, All, On 2020-03-22 17:24 +0100, Laurent Hartanerot spake thusly: > From: Laurent Hartanerot <laurent.hartanerot@atos.net> > > Upgrade python to python3 : "Only Python versions 3.0+ are supported" > > Signed-off-by: Laurent Hartanerot <laurent.hartanerot@atos.net> > --- > package/rcw/rcw.hash | 2 +- > package/rcw/rcw.mk | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash > index 7de1ec659a..76b6373942 100644 > --- a/package/rcw/rcw.hash > +++ b/package/rcw/rcw.hash > @@ -1,3 +1,3 @@ > # Locally calculated > -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz > +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz > sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE > diff --git a/package/rcw/rcw.mk b/package/rcw/rcw.mk > index dbfeae7b21..10e357ed69 100644 > --- a/package/rcw/rcw.mk > +++ b/package/rcw/rcw.mk > @@ -4,13 +4,13 @@ > # > ################################################################################ > > -RCW_VERSION = LSDK-18.12 > +RCW_VERSION = LSDK-19.09 > RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw > RCW_SITE_METHOD = git > RCW_LICENSE = BSD-3-Clause > RCW_LICENSE_FILES = LICENSE > > -HOST_RCW_DEPENDENCIES = host-python > +HOST_RCW_DEPENDENCIES = $(BR2_PYTHON3_HOST_DEPENDENCY) > > RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH)) > > @@ -41,7 +41,7 @@ endef > HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES > > define HOST_RCW_BUILD_CMDS > - $(HOST_DIR)/bin/python $(@D)/rcw.py \ > + python3 $(@D)/rcw.py \ This would not work if building our own host-python3, because it most probably is not in the default PATH, which by the way I explained in a previous mail. Furthermore, this can all be highyl simplified, because the script is not a direct python3 script, it uses /usr/bin/env as shebang, so will properly find the appropriate python3 from the PATH. I've fixed that and pushed to master. Please review my commit and verify it also still works for you, please. Thanks! Regards, Yann E. MORIN. > -i $(@D)/custom_board/rcw/$(RCW_PROJECT) \ > -I $(@D)/custom_board -o $(@D)/PBL.bin > endef > -- > 2.20.1 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v3 1/1] package/rcw : bump to LSDK-19.09 2020-03-22 21:09 ` Yann E. MORIN @ 2020-03-23 6:56 ` Laurent Hartanerot 2020-03-23 17:04 ` Yann E. MORIN 0 siblings, 1 reply; 12+ messages in thread From: Laurent Hartanerot @ 2020-03-23 6:56 UTC (permalink / raw) To: buildroot Yann, All, Sorry, I did not understand what you wanted me to do in your previous email. Now, looking at your patch, it's clearer. I just tested the modification. It's ok for me. Thank's Yann Le dim. 22 mars 2020 ? 22:09, Yann E. MORIN <yann.morin.1998@free.fr> a ?crit : > Laurent, All, > > On 2020-03-22 17:24 +0100, Laurent Hartanerot spake thusly: > > From: Laurent Hartanerot <laurent.hartanerot@atos.net> > > > > Upgrade python to python3 : "Only Python versions 3.0+ are supported" > > > > Signed-off-by: Laurent Hartanerot <laurent.hartanerot@atos.net> > > --- > > package/rcw/rcw.hash | 2 +- > > package/rcw/rcw.mk | 6 +++--- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash > > index 7de1ec659a..76b6373942 100644 > > --- a/package/rcw/rcw.hash > > +++ b/package/rcw/rcw.hash > > @@ -1,3 +1,3 @@ > > # Locally calculated > > -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 > rcw-LSDK-18.12.tar.gz > > +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 > rcw-LSDK-19.09.tar.gz > > sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd > LICENSE > > diff --git a/package/rcw/rcw.mk b/package/rcw/rcw.mk > > index dbfeae7b21..10e357ed69 100644 > > --- a/package/rcw/rcw.mk > > +++ b/package/rcw/rcw.mk > > @@ -4,13 +4,13 @@ > > # > > > ################################################################################ > > > > -RCW_VERSION = LSDK-18.12 > > +RCW_VERSION = LSDK-19.09 > > RCW_SITE = > https://source.codeaurora.org/external/qoriq/qoriq-components/rcw > > RCW_SITE_METHOD = git > > RCW_LICENSE = BSD-3-Clause > > RCW_LICENSE_FILES = LICENSE > > > > -HOST_RCW_DEPENDENCIES = host-python > > +HOST_RCW_DEPENDENCIES = $(BR2_PYTHON3_HOST_DEPENDENCY) > > > > RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH)) > > > > @@ -41,7 +41,7 @@ endef > > HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES > > > > define HOST_RCW_BUILD_CMDS > > - $(HOST_DIR)/bin/python $(@D)/rcw.py \ > > + python3 $(@D)/rcw.py \ > > This would not work if building our own host-python3, because it most > probably is not in the default PATH, which by the way I explained in a > previous mail. > > Furthermore, this can all be highyl simplified, because the script is > not a direct python3 script, it uses /usr/bin/env as shebang, so will > properly find the appropriate python3 from the PATH. > > I've fixed that and pushed to master. Please review my commit and verify > it also still works for you, please. Thanks! > > Regards, > Yann E. MORIN. > > > -i $(@D)/custom_board/rcw/$(RCW_PROJECT) \ > > -I $(@D)/custom_board -o $(@D)/PBL.bin > > endef > > -- > > 2.20.1 > > > > _______________________________________________ > > buildroot mailing list > > buildroot at busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > > -- > > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' > conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ > | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is > no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v > conspiracy. | > > '------------------------------^-------^------------------^--------------------' > -- Laurent HARTANEROT Laurent.Hartanerot at gmail.com tel : 06 49 14 93 74 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200323/aedaea9a/attachment.html> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v3 1/1] package/rcw : bump to LSDK-19.09 2020-03-23 6:56 ` Laurent Hartanerot @ 2020-03-23 17:04 ` Yann E. MORIN 0 siblings, 0 replies; 12+ messages in thread From: Yann E. MORIN @ 2020-03-23 17:04 UTC (permalink / raw) To: buildroot Laurent, All, On 2020-03-23 07:56 +0100, Laurent Hartanerot spake thusly: > Yann, All, > Sorry, I did not understand what you wanted me to do in your previous email. > Now, looking at your patch, it's clearer. > I just tested the modification. It's ok for me. Thanks for the feedback, and sorry for my messy explanations... Regards, Yann E. MORIN. > Thank's Yann > Le?dim. 22 mars 2020 ??22:09, Yann E. MORIN < [1]yann.morin.1998@free.fr> a ?crit?: > > Laurent, All, > > On 2020-03-22 17:24 +0100, Laurent Hartanerot spake thusly: > > From: Laurent Hartanerot < [2]laurent.hartanerot@atos.net> > > > > Upgrade python to python3 : "Only Python versions 3.0+ are supported" > > > > Signed-off-by: Laurent Hartanerot < [3]laurent.hartanerot@atos.net> > > --- > >? package/rcw/rcw.hash | 2 +- > >? package/rcw/ [4]rcw.mk? ?| 6 +++--- > >? 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash > > index 7de1ec659a..76b6373942 100644 > > --- a/package/rcw/rcw.hash > > +++ b/package/rcw/rcw.hash > > @@ -1,3 +1,3 @@ > >? # Locally calculated > > -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz > > +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz > >? sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE > > diff --git a/package/rcw/ [5]rcw.mk b/package/rcw/ [6]rcw.mk > > index dbfeae7b21..10e357ed69 100644 > > --- a/package/rcw/ [7]rcw.mk > > +++ b/package/rcw/ [8]rcw.mk > > @@ -4,13 +4,13 @@ > >? # > >? ################################################################################ > >? > > -RCW_VERSION = LSDK-18.12 > > +RCW_VERSION = LSDK-19.09 > >? RCW_SITE = [9]https://source.codeaurora.org/external/qoriq/qoriq-components/rcw > >? RCW_SITE_METHOD = git > >? RCW_LICENSE = BSD-3-Clause > >? RCW_LICENSE_FILES = LICENSE > >? > > -HOST_RCW_DEPENDENCIES = host-python > > +HOST_RCW_DEPENDENCIES = $(BR2_PYTHON3_HOST_DEPENDENCY) > >? > >? RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH)) > >? > > @@ -41,7 +41,7 @@ endef > >? HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES > >? > >? define HOST_RCW_BUILD_CMDS > > -? ? ?$(HOST_DIR)/bin/python $(@D)/rcw.py \ > > +? ? ?python3 $(@D)/rcw.py \ > > This would not work if building our own host-python3, because it most > probably is not in the default PATH, which by the way I explained in a > previous mail. > > Furthermore, this can all be highyl simplified, because the script is > not a direct python3 script, it uses /usr/bin/env as shebang, so will > properly find the appropriate python3 from the PATH. > > I've fixed that and pushed to master. Please review my commit and verify > it also still works for you, please. Thanks! > > Regards, > Yann E. MORIN. > > >? ? ? ? ? ? ? ?-i $(@D)/custom_board/rcw/$(RCW_PROJECT) \ > >? ? ? ? ? ? ? ?-I $(@D)/custom_board -o $(@D)/PBL.bin > >? endef > > -- > > 2.20.1 > > > > _______________________________________________ > > buildroot mailing list > > [10]buildroot at busybox.net > > [11]http://lists.busybox.net/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > |? Yann E. MORIN? | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software? Designer | \ / CAMPAIGN? ? ?|? ___? ? ? ? ? ? > ? ?| > | +33 561 099 427 `------------.-------:? X? AGAINST? ? ? |? \e/? There is no? | > | [12]http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL? ? |? ?v? ?conspiracy.? | > '------------------------------^-------^------------------^--------------------' > > -- > Laurent HARTANEROT > [13]Laurent.Hartanerot at gmail.com > tel : 06 49 14 93 74 > > Links: > 1. mailto:yann.morin.1998 at free.fr > 2. mailto:laurent.hartanerot at atos.net > 3. mailto:laurent.hartanerot at atos.net > 4. http://rcw.mk > 5. http://rcw.mk > 6. http://rcw.mk > 7. http://rcw.mk > 8. http://rcw.mk > 9. https://source.codeaurora.org/external/qoriq/qoriq-components/rcw > 10. mailto:buildroot at busybox.net > 11. http://lists.busybox.net/mailman/listinfo/buildroot > 12. http://ymorin.is-a-geek.org/ > 13. mailto:Laurent.Hartanerot at gmail.com -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-03-23 17:04 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-03-18 7:14 [Buildroot] [PATCH 1/1] package/rcw : bump to LSDK-19.09 Laurent Hartanerot 2020-03-18 21:12 ` Thomas Petazzoni 2020-03-22 10:31 ` [Buildroot] [PATCH v2 " Laurent Hartanerot 2020-03-22 13:12 ` Yann E. MORIN 2020-03-22 14:51 ` Laurent Hartanerot 2020-03-22 15:18 ` Yann E. MORIN 2020-03-22 15:29 ` Laurent Hartanerot 2020-03-22 15:48 ` Yann E. MORIN 2020-03-22 16:24 ` [Buildroot] [PATCH v3 " Laurent Hartanerot 2020-03-22 21:09 ` Yann E. MORIN 2020-03-23 6:56 ` Laurent Hartanerot 2020-03-23 17:04 ` Yann E. MORIN
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox