Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/quagga: install quagga to staging
Date: Mon, 23 Mar 2020 22:07:45 +0100	[thread overview]
Message-ID: <20200323210745.GL22325@scaer> (raw)
In-Reply-To: <20200323204918.53596-1-graham.rhodes@rockwellcollins.com>

Graham, All,

On 2020-03-23 15:49 -0500, Graham Rhodes spake thusly:
> ---
>  package/quagga/quagga.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk
> index 96a971104b..0b352aa367 100644
> --- a/package/quagga/quagga.mk
> +++ b/package/quagga/quagga.mk
> @@ -6,6 +6,7 @@
>  
>  QUAGGA_VERSION = 1.2.4
>  QUAGGA_SITE = http://download.savannah.gnu.org/releases/quagga
> +QUAGGA_INSTALL_STAGING = YES

Thanks for this change, but you have to explain why you need it in
staging.

A commit log should provide explanations for why the change is neeed.

Also, your commit log should end up with your Signed-off-by )SoB) line.
The SoB line is an attestation by yourself that your are allowed to
contribute the change: https://developercertificate.org/

For example, here is a totally hypotetical commit log:

    package/quagga: install to staging

    quagga installs a library that can be used by other applications to
    quaggaize the World, which turns the World into a giant party (this
    is a good thing).

    So, install it to staging.

    Signed-off-by: You NAME <your-email>

Regards,
Yann E. MORIN.

>  QUAGGA_DEPENDENCIES = host-gawk host-pkgconf
>  QUAGGA_LICENSE = GPL-2.0+
>  QUAGGA_LICENSE_FILES = COPYING
> -- 
> 2.23.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-03-23 21:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23 20:49 [Buildroot] [PATCH] package/quagga: install quagga to staging Graham Rhodes
2020-03-23 21:07 ` Yann E. MORIN [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-03-24 13:22 Graham Rhodes
2020-03-24 15:47 Graham Rhodes
2020-03-24 20:51 ` Thomas Petazzoni
2020-04-07 16:23 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200323210745.GL22325@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox