Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/quagga: install quagga to staging
@ 2020-03-23 20:49 Graham Rhodes
  2020-03-23 21:07 ` Yann E. MORIN
  0 siblings, 1 reply; 6+ messages in thread
From: Graham Rhodes @ 2020-03-23 20:49 UTC (permalink / raw)
  To: buildroot

---
 package/quagga/quagga.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk
index 96a971104b..0b352aa367 100644
--- a/package/quagga/quagga.mk
+++ b/package/quagga/quagga.mk
@@ -6,6 +6,7 @@
 
 QUAGGA_VERSION = 1.2.4
 QUAGGA_SITE = http://download.savannah.gnu.org/releases/quagga
+QUAGGA_INSTALL_STAGING = YES
 QUAGGA_DEPENDENCIES = host-gawk host-pkgconf
 QUAGGA_LICENSE = GPL-2.0+
 QUAGGA_LICENSE_FILES = COPYING
-- 
2.23.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] package/quagga: install quagga to staging
  2020-03-23 20:49 [Buildroot] [PATCH] package/quagga: install quagga to staging Graham Rhodes
@ 2020-03-23 21:07 ` Yann E. MORIN
  0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2020-03-23 21:07 UTC (permalink / raw)
  To: buildroot

Graham, All,

On 2020-03-23 15:49 -0500, Graham Rhodes spake thusly:
> ---
>  package/quagga/quagga.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk
> index 96a971104b..0b352aa367 100644
> --- a/package/quagga/quagga.mk
> +++ b/package/quagga/quagga.mk
> @@ -6,6 +6,7 @@
>  
>  QUAGGA_VERSION = 1.2.4
>  QUAGGA_SITE = http://download.savannah.gnu.org/releases/quagga
> +QUAGGA_INSTALL_STAGING = YES

Thanks for this change, but you have to explain why you need it in
staging.

A commit log should provide explanations for why the change is neeed.

Also, your commit log should end up with your Signed-off-by )SoB) line.
The SoB line is an attestation by yourself that your are allowed to
contribute the change: https://developercertificate.org/

For example, here is a totally hypotetical commit log:

    package/quagga: install to staging

    quagga installs a library that can be used by other applications to
    quaggaize the World, which turns the World into a giant party (this
    is a good thing).

    So, install it to staging.

    Signed-off-by: You NAME <your-email>

Regards,
Yann E. MORIN.

>  QUAGGA_DEPENDENCIES = host-gawk host-pkgconf
>  QUAGGA_LICENSE = GPL-2.0+
>  QUAGGA_LICENSE_FILES = COPYING
> -- 
> 2.23.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] package/quagga: install quagga to staging
@ 2020-03-24 13:22 Graham Rhodes
  0 siblings, 0 replies; 6+ messages in thread
From: Graham Rhodes @ 2020-03-24 13:22 UTC (permalink / raw)
  To: buildroot

---
 package/quagga/quagga.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk
index 96a971104b..0b352aa367 100644
--- a/package/quagga/quagga.mk
+++ b/package/quagga/quagga.mk
@@ -6,6 +6,7 @@
 
 QUAGGA_VERSION = 1.2.4
 QUAGGA_SITE = http://download.savannah.gnu.org/releases/quagga
+QUAGGA_INSTALL_STAGING = YES
 QUAGGA_DEPENDENCIES = host-gawk host-pkgconf
 QUAGGA_LICENSE = GPL-2.0+
 QUAGGA_LICENSE_FILES = COPYING
-- 
2.23.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] package/quagga: install quagga to staging
@ 2020-03-24 15:47 Graham Rhodes
  2020-03-24 20:51 ` Thomas Petazzoni
  2020-04-07 16:23 ` Peter Korsgaard
  0 siblings, 2 replies; 6+ messages in thread
From: Graham Rhodes @ 2020-03-24 15:47 UTC (permalink / raw)
  To: buildroot

---
 package/quagga/quagga.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/quagga/quagga.mk b/package/quagga/quagga.mk
index 96a971104b..0b352aa367 100644
--- a/package/quagga/quagga.mk
+++ b/package/quagga/quagga.mk
@@ -6,6 +6,7 @@
 
 QUAGGA_VERSION = 1.2.4
 QUAGGA_SITE = http://download.savannah.gnu.org/releases/quagga
+QUAGGA_INSTALL_STAGING = YES
 QUAGGA_DEPENDENCIES = host-gawk host-pkgconf
 QUAGGA_LICENSE = GPL-2.0+
 QUAGGA_LICENSE_FILES = COPYING
-- 
2.23.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] package/quagga: install quagga to staging
  2020-03-24 15:47 Graham Rhodes
@ 2020-03-24 20:51 ` Thomas Petazzoni
  2020-04-07 16:23 ` Peter Korsgaard
  1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2020-03-24 20:51 UTC (permalink / raw)
  To: buildroot

On Tue, 24 Mar 2020 10:47:21 -0500
Graham Rhodes <graham.rhodes@rockwellcollins.com> wrote:

> ---
>  package/quagga/quagga.mk | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] package/quagga: install quagga to staging
  2020-03-24 15:47 Graham Rhodes
  2020-03-24 20:51 ` Thomas Petazzoni
@ 2020-04-07 16:23 ` Peter Korsgaard
  1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2020-04-07 16:23 UTC (permalink / raw)
  To: buildroot

>>>>> "Graham" == Graham Rhodes <graham.rhodes@rockwellcollins.com> writes:

 > ---
 >  package/quagga/quagga.mk | 1 +
 >  1 file changed, 1 insertion(+)

Committed to 2020.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-04-07 16:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-23 20:49 [Buildroot] [PATCH] package/quagga: install quagga to staging Graham Rhodes
2020-03-23 21:07 ` Yann E. MORIN
  -- strict thread matches above, loose matches on Subject: below --
2020-03-24 13:22 Graham Rhodes
2020-03-24 15:47 Graham Rhodes
2020-03-24 20:51 ` Thomas Petazzoni
2020-04-07 16:23 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox