* [Buildroot] [PATCH v1] package/assimp: bump version to 5.0.1
@ 2020-04-07 21:12 Peter Seiderer
2020-04-08 19:31 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Peter Seiderer @ 2020-04-07 21:12 UTC (permalink / raw)
To: buildroot
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
...1-Fix-FBXConverter-use-proper-64-bit-constant.patch | 10 ++++++----
package/assimp/assimp.hash | 4 ++--
package/assimp/assimp.mk | 2 +-
3 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/package/assimp/0001-Fix-FBXConverter-use-proper-64-bit-constant.patch b/package/assimp/0001-Fix-FBXConverter-use-proper-64-bit-constant.patch
index bfcbeb55e3..1b23d66364 100644
--- a/package/assimp/0001-Fix-FBXConverter-use-proper-64-bit-constant.patch
+++ b/package/assimp/0001-Fix-FBXConverter-use-proper-64-bit-constant.patch
@@ -12,15 +12,17 @@ Use proper 64-bit constant for CONVERT_FBX_TIME(time) conversion, fixes:
code/FBXConverter.cpp:2878: error: integer constant is too large for 'long' type
code/FBXConverter.cpp:2888: error: integer constant is too large for 'long' type
+Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+[Rebased on 5.0.1]
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
- code/FBXConverter.cpp | 2 +-
+ code/FBX/FBXConverter.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
-diff --git a/code/FBXConverter.cpp b/code/FBXConverter.cpp
+diff --git a/code/FBX/FBXConverter.cpp b/code/FBXConverter.cpp
index e0c6b9c..b1e9a71 100644
---- a/code/FBXConverter.cpp
-+++ b/code/FBXConverter.cpp
+--- a/code/FBX/FBXConverter.cpp
++++ b/code/FBX/FBXConverter.cpp
@@ -67,7 +67,7 @@ namespace FBX {
#define MAGIC_NODE_TAG "_$AssimpFbx$"
diff --git a/package/assimp/assimp.hash b/package/assimp/assimp.hash
index 72d367ac43..df5daa79c9 100644
--- a/package/assimp/assimp.hash
+++ b/package/assimp/assimp.hash
@@ -1,3 +1,3 @@
# Locally calculated
-sha256 3520b1e9793b93a2ca3b797199e16f40d61762617e072f2d525fad70f9678a71 assimp-4.1.0.tar.gz
-sha256 a26ccc3dbf2f58ea99c100945a8a126fa0f9f4d7fd2b49aa8bdb8e09355864d8 LICENSE
+sha256 11310ec1f2ad2cd46b95ba88faca8f7aaa1efe9aa12605c55e3de2b977b3dbfc assimp-5.0.1.tar.gz
+sha256 a26ccc3dbf2f58ea99c100945a8a126fa0f9f4d7fd2b49aa8bdb8e09355864d8 LICENSE
diff --git a/package/assimp/assimp.mk b/package/assimp/assimp.mk
index ce02ef300c..5e8e825375 100644
--- a/package/assimp/assimp.mk
+++ b/package/assimp/assimp.mk
@@ -4,7 +4,7 @@
#
################################################################################
-ASSIMP_VERSION = 4.1.0
+ASSIMP_VERSION = 5.0.1
ASSIMP_SITE = $(call github,assimp,assimp,v$(ASSIMP_VERSION))
ASSIMP_LICENSE = BSD-3-Clause
ASSIMP_LICENSE_FILES = LICENSE
--
2.26.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH v1] package/assimp: bump version to 5.0.1
2020-04-07 21:12 [Buildroot] [PATCH v1] package/assimp: bump version to 5.0.1 Peter Seiderer
@ 2020-04-08 19:31 ` Thomas Petazzoni
2020-04-08 20:47 ` Peter Seiderer
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2020-04-08 19:31 UTC (permalink / raw)
To: buildroot
On Tue, 7 Apr 2020 23:12:38 +0200
Peter Seiderer <ps.report@gmx.net> wrote:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> ...1-Fix-FBXConverter-use-proper-64-bit-constant.patch | 10 ++++++----
> package/assimp/assimp.hash | 4 ++--
> package/assimp/assimp.mk | 2 +-
> 3 files changed, 9 insertions(+), 7 deletions(-)
Applied, thanks. Could you submit the patch we have to the upstream
project?
Also did you test building the qt53d package after this update? It is
the only package in Buildroot that uses assimp.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v1] package/assimp: bump version to 5.0.1
2020-04-08 19:31 ` Thomas Petazzoni
@ 2020-04-08 20:47 ` Peter Seiderer
2020-04-08 21:15 ` Peter Seiderer
0 siblings, 1 reply; 5+ messages in thread
From: Peter Seiderer @ 2020-04-08 20:47 UTC (permalink / raw)
To: buildroot
Hello Thomas,
On Wed, 8 Apr 2020 21:31:40 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> On Tue, 7 Apr 2020 23:12:38 +0200
> Peter Seiderer <ps.report@gmx.net> wrote:
>
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> > ...1-Fix-FBXConverter-use-proper-64-bit-constant.patch | 10 ++++++----
> > package/assimp/assimp.hash | 4 ++--
> > package/assimp/assimp.mk | 2 +-
> > 3 files changed, 9 insertions(+), 7 deletions(-)
>
> Applied, thanks. Could you submit the patch we have to the upstream
> project?
Already on my ToDo list ;-)...
>
> Also did you test building the qt53d package after this update? It is
> the only package in Buildroot that uses assimp.
Yes...and compiled without failure after the assimp version bump...
Regards,
Peter
>
> Thanks!
>
> Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v1] package/assimp: bump version to 5.0.1
2020-04-08 20:47 ` Peter Seiderer
@ 2020-04-08 21:15 ` Peter Seiderer
2020-04-09 5:22 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Peter Seiderer @ 2020-04-08 21:15 UTC (permalink / raw)
To: buildroot
Hello Thomas,
On Wed, 8 Apr 2020 22:47:00 +0200, Peter Seiderer <ps.report@gmx.net> wrote:
> Hello Thomas,
>
> On Wed, 8 Apr 2020 21:31:40 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
>
> > On Tue, 7 Apr 2020 23:12:38 +0200
> > Peter Seiderer <ps.report@gmx.net> wrote:
> >
> > > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > > ---
> > > ...1-Fix-FBXConverter-use-proper-64-bit-constant.patch | 10 ++++++----
> > > package/assimp/assimp.hash | 4 ++--
> > > package/assimp/assimp.mk | 2 +-
> > > 3 files changed, 9 insertions(+), 7 deletions(-)
> >
> > Applied, thanks. Could you submit the patch we have to the upstream
> > project?
>
> Already on my ToDo list ;-)...
Seems Fabrice Fontaine already handled it, see [1], but the change did not
make it into the 5.0.1 release...
Regards,
Peter
[1] https://github.com/assimp/assimp/commit/32781a566db2cd6022c7020ff2ac591d753c11ab
>
> >
> > Also did you test building the qt53d package after this update? It is
> > the only package in Buildroot that uses assimp.
>
> Yes...and compiled without failure after the assimp version bump...
>
> Regards,
> Peter
>
> >
> > Thanks!
> >
> > Thomas
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v1] package/assimp: bump version to 5.0.1
2020-04-08 21:15 ` Peter Seiderer
@ 2020-04-09 5:22 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2020-04-09 5:22 UTC (permalink / raw)
To: buildroot
On Wed, 8 Apr 2020 23:15:41 +0200
Peter Seiderer <ps.report@gmx.net> wrote:
> > > Applied, thanks. Could you submit the patch we have to the upstream
> > > project?
> >
> > Already on my ToDo list ;-)...
>
> Seems Fabrice Fontaine already handled it, see [1], but the change did not
> make it into the 5.0.1 release...
Great, thanks for having checked!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-09 5:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-07 21:12 [Buildroot] [PATCH v1] package/assimp: bump version to 5.0.1 Peter Seiderer
2020-04-08 19:31 ` Thomas Petazzoni
2020-04-08 20:47 ` Peter Seiderer
2020-04-08 21:15 ` Peter Seiderer
2020-04-09 5:22 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox