From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/8] core/show-info: report package stamp files
Date: Sat, 11 Apr 2020 10:38:42 +0200 [thread overview]
Message-ID: <20200411103842.3d095fbf@windsurf.home> (raw)
In-Reply-To: <39b4e30872bf54a34bf482576022c0d025b89b25.1586592741.git.yann.morin.1998@free.fr>
On Sat, 11 Apr 2020 10:12:31 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> + "stamp_files": {
> + $(if $($(1)_OVERRIDE_SRCDIR), \
> + "rsync": "$(notdir $($(1)_TARGET_RSYNC))"$(comma) \
> + , \
> + "download": "$(notdir $($(1)_TARGET_SOURCE))"$(comma) \
> + "extract": "$(notdir $($(1)_TARGET_EXTRACT))"$(comma) \
> + "patch": "$(notdir $($(1)_TARGET_PATCH))"$(comma) \
> + )
> + "configure": "$(notdir $($(1)_TARGET_CONFIGURE))",
> + "build": "$(notdir $($(1)_TARGET_BUILD))",
> + $(if $(filter YES,$($(1)_INSTALL_STAGING)),\
> + "install_staging": "$(notdir $($(1)_TARGET_INSTALL_STAGING))"$(comma) \
> + )
> + $(if $(filter YES,$($(1)_INSTALL_TARGET)),\
> + "install_target": "$(notdir $($(1)_TARGET_INSTALL_TARGET))"$(comma) \
> + )
> + $(if $(filter YES,$($(1)_INSTALL_IMAGES)),\
> + "install_images": "$(notdir $($(1)_TARGET_INSTALL_IMAGES))"$(comma) \
> + )
> + $(if $(filter host,$($(1)_TYPE)), \
> + "install": "$(notdir $($(1)_TARGET_INSTALL_HOST))"$(comma) \
> + )
Isn't this going to add for each package exactly the same information,
over and over again ? I.e, just the names of stamp files, again, again,
and again. This seems like a big waste of space, making the JSON output
very noisy. I think the tool showing the progress should simply know
what the stamp files are.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-04-11 8:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 8:12 [Buildroot] [PATCH 0/8] core/show-info: export extra information about the package build (branch yem/show-info-extras) Yann E. MORIN
2020-04-11 8:12 ` [Buildroot] [PATCH 1/8] core/show-info: do not show install types for host packages Yann E. MORIN
2020-04-25 12:57 ` Thomas Petazzoni
2020-04-11 8:12 ` [Buildroot] [PATCH 2/8] infra/pkg-generic: don't set INSTALL_{TARGET, STAGING, IMAGES} for host Yann E. MORIN
2020-04-25 12:57 ` Thomas Petazzoni
2020-04-11 8:12 ` [Buildroot] [PATCH 3/8] core/show-info: report install types for virtual packages too Yann E. MORIN
2020-04-11 8:41 ` Thomas Petazzoni
2020-04-11 9:49 ` Yann E. MORIN
2020-04-25 13:07 ` Thomas Petazzoni
2020-04-11 8:12 ` [Buildroot] [PATCH 4/8] core/show-info: report the package build directory Yann E. MORIN
2020-04-25 13:08 ` Thomas Petazzoni
2020-04-11 8:12 ` [Buildroot] [PATCH 5/8] core/show-info: report whether a package is overriden Yann E. MORIN
2020-04-11 8:36 ` Thomas Petazzoni
2020-04-11 9:44 ` Yann E. MORIN
2020-04-11 12:42 ` Thomas Petazzoni
2020-04-11 13:22 ` Yann E. MORIN
2020-04-11 14:14 ` Thomas Petazzoni
2020-04-11 17:41 ` Yann E. MORIN
2020-04-11 8:12 ` [Buildroot] [PATCH 6/8] core/show-info: report package stamp files Yann E. MORIN
2020-04-11 8:38 ` Thomas Petazzoni [this message]
2020-04-11 8:12 ` [Buildroot] [PATCH 7/8] core/show-info: report the ordered list of build steps Yann E. MORIN
2020-04-11 8:39 ` Thomas Petazzoni
2020-04-11 13:41 ` Philippe Proulx
2020-04-11 14:19 ` Thomas Petazzoni
2020-04-11 15:06 ` Philippe Proulx
2020-04-11 15:27 ` Thomas Petazzoni
2020-04-11 18:20 ` Yann E. MORIN
2020-04-11 18:12 ` Yann E. MORIN
2020-04-11 18:02 ` Yann E. MORIN
2020-04-11 8:12 ` [Buildroot] [PATCH 8/8] core/show-info: report image name of filesystems Yann E. MORIN
2020-04-25 13:12 ` Thomas Petazzoni
2020-04-25 13:32 ` Yann E. MORIN
2021-07-27 20:08 ` Arnout Vandecappelle
2020-04-25 13:13 ` [Buildroot] [PATCH 0/8] core/show-info: export extra information about the package build (branch yem/show-info-extras) Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200411103842.3d095fbf@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox