Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 7/8] core/show-info: report the ordered list of build steps
Date: Sat, 11 Apr 2020 20:12:52 +0200	[thread overview]
Message-ID: <20200411181252.GP29898@scaer> (raw)
In-Reply-To: <20200411161903.7b007feb@windsurf.home>

Thomas, All,

On 2020-04-11 16:19 +0200, Thomas Petazzoni spake thusly:
> On Sat, 11 Apr 2020 09:41:47 -0400
> Philippe Proulx <eeppeliteloop@gmail.com> wrote:
> > Replying for patch 6/8 and this one.
> > Is the `show-info` target considered a public API?
> Somewhat yes: the goal of show-info is that people can craft their own
> tooling on top of it. Breaking the show-info output would break such
> tools.

Which in some cases wil not be avoidable, see my previous reply.

> > If so, without a
> > version, it means it can never break. So let me suggest another layout
> > which breaks `show-info` (name it `show-info-2` if you will).
> > 
> > Output example (using YAML only for clarity here):
> This could certainly work, and reduces a bit the duplication of
> information.

The show-info is not for human consumption, I don't see a problem with
its content growing.

Also, as I explained in my previous reply to Philippe, having the
information where it is needed (i.e at the package level) allows to
process show-info in a stream, without having to memorise anything.

OTOH, having metadata description means the whole of show-info as to be
loaded in memory before any rocessing can outcur, since the content of
json is not guaranteeed to be ordered.

Yes, we could try and get our bare show-info output would be ordered,
but as soon as it gets processed (e.g. with json_pp or whatever), the
ordering would get lost.

> However, I still don't understand why your tool is not capable of
> having this knowledge about the stamp files. This is something that
> rarely changes. I think we haven't changed the stamp files since... 5
> years? More? If your tool is in the Buildroot tree itself, it can
> simply be updated if there is ever a change in the sequencing of steps.

That's true. But if you want to consider show-info to be a public API
and thus be stable,m then you would have to consider the stampfiles to
also be public API and thus stable, which is definitely what we want.

But that's also true that it changes so rarely that it would be
acceptable to break the tools.

And if we have such tools in-tree, we can fix them as we change the
internal details.

Regards,
Yann E. MORIN.

> Best regards,
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2020-04-11 18:12 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-11  8:12 [Buildroot] [PATCH 0/8] core/show-info: export extra information about the package build (branch yem/show-info-extras) Yann E. MORIN
2020-04-11  8:12 ` [Buildroot] [PATCH 1/8] core/show-info: do not show install types for host packages Yann E. MORIN
2020-04-25 12:57   ` Thomas Petazzoni
2020-04-11  8:12 ` [Buildroot] [PATCH 2/8] infra/pkg-generic: don't set INSTALL_{TARGET, STAGING, IMAGES} for host Yann E. MORIN
2020-04-25 12:57   ` Thomas Petazzoni
2020-04-11  8:12 ` [Buildroot] [PATCH 3/8] core/show-info: report install types for virtual packages too Yann E. MORIN
2020-04-11  8:41   ` Thomas Petazzoni
2020-04-11  9:49     ` Yann E. MORIN
2020-04-25 13:07   ` Thomas Petazzoni
2020-04-11  8:12 ` [Buildroot] [PATCH 4/8] core/show-info: report the package build directory Yann E. MORIN
2020-04-25 13:08   ` Thomas Petazzoni
2020-04-11  8:12 ` [Buildroot] [PATCH 5/8] core/show-info: report whether a package is overriden Yann E. MORIN
2020-04-11  8:36   ` Thomas Petazzoni
2020-04-11  9:44     ` Yann E. MORIN
2020-04-11 12:42       ` Thomas Petazzoni
2020-04-11 13:22         ` Yann E. MORIN
2020-04-11 14:14           ` Thomas Petazzoni
2020-04-11 17:41             ` Yann E. MORIN
2020-04-11  8:12 ` [Buildroot] [PATCH 6/8] core/show-info: report package stamp files Yann E. MORIN
2020-04-11  8:38   ` Thomas Petazzoni
2020-04-11  8:12 ` [Buildroot] [PATCH 7/8] core/show-info: report the ordered list of build steps Yann E. MORIN
2020-04-11  8:39   ` Thomas Petazzoni
2020-04-11 13:41     ` Philippe Proulx
2020-04-11 14:19       ` Thomas Petazzoni
2020-04-11 15:06         ` Philippe Proulx
2020-04-11 15:27           ` Thomas Petazzoni
2020-04-11 18:20           ` Yann E. MORIN
2020-04-11 18:12         ` Yann E. MORIN [this message]
2020-04-11 18:02       ` Yann E. MORIN
2020-04-11  8:12 ` [Buildroot] [PATCH 8/8] core/show-info: report image name of filesystems Yann E. MORIN
2020-04-25 13:12   ` Thomas Petazzoni
2020-04-25 13:32     ` Yann E. MORIN
2021-07-27 20:08   ` Arnout Vandecappelle
2020-04-25 13:13 ` [Buildroot] [PATCH 0/8] core/show-info: export extra information about the package build (branch yem/show-info-extras) Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200411181252.GP29898@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox