* [Buildroot] [PATCH 1/2] imx/genimage: Specify the volume-label for vfat
@ 2020-04-15 12:36 Fabio Estevam
2020-04-15 12:36 ` [Buildroot] [PATCH 2/2] fs/ext2: Pass a default string to filesystem label Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabio Estevam @ 2020-04-15 12:36 UTC (permalink / raw)
To: buildroot
Currently the volume-label for the vfat partition is a string with
the following pattern: 5934-861D.
Specify the volume-label as "boot" to make it easier to identify it.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
board/freescale/common/imx/genimage.cfg.template | 1 +
board/freescale/common/imx/genimage.cfg.template_imx8 | 1 +
board/freescale/common/imx/genimage.cfg.template_spl | 1 +
3 files changed, 3 insertions(+)
diff --git a/board/freescale/common/imx/genimage.cfg.template b/board/freescale/common/imx/genimage.cfg.template
index 2a7036a7df..61b09bde9f 100644
--- a/board/freescale/common/imx/genimage.cfg.template
+++ b/board/freescale/common/imx/genimage.cfg.template
@@ -9,6 +9,7 @@
image boot.vfat {
vfat {
+ label = "boot"
files = {
%FILES%
}
diff --git a/board/freescale/common/imx/genimage.cfg.template_imx8 b/board/freescale/common/imx/genimage.cfg.template_imx8
index bd5f6cdc73..84a812f986 100644
--- a/board/freescale/common/imx/genimage.cfg.template_imx8
+++ b/board/freescale/common/imx/genimage.cfg.template_imx8
@@ -9,6 +9,7 @@
image boot.vfat {
vfat {
+ label = "boot"
files = {
%FILES%
}
diff --git a/board/freescale/common/imx/genimage.cfg.template_spl b/board/freescale/common/imx/genimage.cfg.template_spl
index d2d810777b..3b0667c383 100644
--- a/board/freescale/common/imx/genimage.cfg.template_spl
+++ b/board/freescale/common/imx/genimage.cfg.template_spl
@@ -9,6 +9,7 @@
image boot.vfat {
vfat {
+ label = "boot"
files = {
%FILES%
}
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 2/2] fs/ext2: Pass a default string to filesystem label
2020-04-15 12:36 [Buildroot] [PATCH 1/2] imx/genimage: Specify the volume-label for vfat Fabio Estevam
@ 2020-04-15 12:36 ` Fabio Estevam
2020-04-15 13:15 ` Pierre-Jean Texier
2020-04-15 13:15 ` [Buildroot] [PATCH 1/2] imx/genimage: Specify the volume-label for vfat Pierre-Jean Texier
2020-04-15 20:51 ` Thomas Petazzoni
2 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2020-04-15 12:36 UTC (permalink / raw)
To: buildroot
Currently the volume-label for the root filesystem partition is a string
wit the following pattern: ad09a287-46a9-4790-ba97-fbbb549e5e96.
Specify the volume-label as "rootfs" to make it easier to identify it.
Suggested-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
fs/ext2/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/ext2/Config.in b/fs/ext2/Config.in
index 74bacc1141..333ead95fe 100644
--- a/fs/ext2/Config.in
+++ b/fs/ext2/Config.in
@@ -43,6 +43,7 @@ config BR2_TARGET_ROOTFS_EXT2_REV
config BR2_TARGET_ROOTFS_EXT2_LABEL
string "filesystem label"
+ default "rootfs"
config BR2_TARGET_ROOTFS_EXT2_SIZE
string "exact size"
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] fs/ext2: Pass a default string to filesystem label
2020-04-15 12:36 ` [Buildroot] [PATCH 2/2] fs/ext2: Pass a default string to filesystem label Fabio Estevam
@ 2020-04-15 13:15 ` Pierre-Jean Texier
0 siblings, 0 replies; 5+ messages in thread
From: Pierre-Jean Texier @ 2020-04-15 13:15 UTC (permalink / raw)
To: buildroot
Hi Fabio,
Le 15/04/2020 ? 14:36, Fabio Estevam a ?crit?:
> Currently the volume-label for the root filesystem partition is a string
> wit the following pattern: ad09a287-46a9-4790-ba97-fbbb549e5e96.
>
> Specify the volume-label as "rootfs" to make it easier to identify it.
>
> Suggested-by: Arnout Vandecappelle <arnout@mind.be>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Tested-by: Pierre-Jean Texier <pjtexier@koncepto.io>
Thanks !
Pierre-Jean
> ---
> fs/ext2/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ext2/Config.in b/fs/ext2/Config.in
> index 74bacc1141..333ead95fe 100644
> --- a/fs/ext2/Config.in
> +++ b/fs/ext2/Config.in
> @@ -43,6 +43,7 @@ config BR2_TARGET_ROOTFS_EXT2_REV
>
> config BR2_TARGET_ROOTFS_EXT2_LABEL
> string "filesystem label"
> + default "rootfs"
>
> config BR2_TARGET_ROOTFS_EXT2_SIZE
> string "exact size"
>
--
Pierre-Jean Texier
Embedded Linux Engineer
https://koncepto.io
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] imx/genimage: Specify the volume-label for vfat
2020-04-15 12:36 [Buildroot] [PATCH 1/2] imx/genimage: Specify the volume-label for vfat Fabio Estevam
2020-04-15 12:36 ` [Buildroot] [PATCH 2/2] fs/ext2: Pass a default string to filesystem label Fabio Estevam
@ 2020-04-15 13:15 ` Pierre-Jean Texier
2020-04-15 20:51 ` Thomas Petazzoni
2 siblings, 0 replies; 5+ messages in thread
From: Pierre-Jean Texier @ 2020-04-15 13:15 UTC (permalink / raw)
To: buildroot
Hi Fabio,
Le 15/04/2020 ? 14:36, Fabio Estevam a ?crit?:
> Currently the volume-label for the vfat partition is a string with
> the following pattern: 5934-861D.
>
> Specify the volume-label as "boot" to make it easier to identify it.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Works fine on my WaRP7.
Tested-by: Pierre-Jean Texier <pjtexier@koncepto.io>
Thanks !
Pierre-Jean
> ---
> board/freescale/common/imx/genimage.cfg.template | 1 +
> board/freescale/common/imx/genimage.cfg.template_imx8 | 1 +
> board/freescale/common/imx/genimage.cfg.template_spl | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/board/freescale/common/imx/genimage.cfg.template b/board/freescale/common/imx/genimage.cfg.template
> index 2a7036a7df..61b09bde9f 100644
> --- a/board/freescale/common/imx/genimage.cfg.template
> +++ b/board/freescale/common/imx/genimage.cfg.template
> @@ -9,6 +9,7 @@
>
> image boot.vfat {
> vfat {
> + label = "boot"
> files = {
> %FILES%
> }
> diff --git a/board/freescale/common/imx/genimage.cfg.template_imx8 b/board/freescale/common/imx/genimage.cfg.template_imx8
> index bd5f6cdc73..84a812f986 100644
> --- a/board/freescale/common/imx/genimage.cfg.template_imx8
> +++ b/board/freescale/common/imx/genimage.cfg.template_imx8
> @@ -9,6 +9,7 @@
>
> image boot.vfat {
> vfat {
> + label = "boot"
> files = {
> %FILES%
> }
> diff --git a/board/freescale/common/imx/genimage.cfg.template_spl b/board/freescale/common/imx/genimage.cfg.template_spl
> index d2d810777b..3b0667c383 100644
> --- a/board/freescale/common/imx/genimage.cfg.template_spl
> +++ b/board/freescale/common/imx/genimage.cfg.template_spl
> @@ -9,6 +9,7 @@
>
> image boot.vfat {
> vfat {
> + label = "boot"
> files = {
> %FILES%
> }
>
--
Pierre-Jean Texier
Embedded Linux Engineer
https://koncepto.io
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 1/2] imx/genimage: Specify the volume-label for vfat
2020-04-15 12:36 [Buildroot] [PATCH 1/2] imx/genimage: Specify the volume-label for vfat Fabio Estevam
2020-04-15 12:36 ` [Buildroot] [PATCH 2/2] fs/ext2: Pass a default string to filesystem label Fabio Estevam
2020-04-15 13:15 ` [Buildroot] [PATCH 1/2] imx/genimage: Specify the volume-label for vfat Pierre-Jean Texier
@ 2020-04-15 20:51 ` Thomas Petazzoni
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2020-04-15 20:51 UTC (permalink / raw)
To: buildroot
On Wed, 15 Apr 2020 09:36:55 -0300
Fabio Estevam <festevam@gmail.com> wrote:
> Currently the volume-label for the vfat partition is a string with
> the following pattern: 5934-861D.
>
> Specify the volume-label as "boot" to make it easier to identify it.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> board/freescale/common/imx/genimage.cfg.template | 1 +
> board/freescale/common/imx/genimage.cfg.template_imx8 | 1 +
> board/freescale/common/imx/genimage.cfg.template_spl | 1 +
> 3 files changed, 3 insertions(+)
Series applied, thanks. I've also added another patch that drops the
useless BR2_TARGET_ROOTFS_EXT2_LABEL="rootfs" from a few defconfigs.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-15 20:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-15 12:36 [Buildroot] [PATCH 1/2] imx/genimage: Specify the volume-label for vfat Fabio Estevam
2020-04-15 12:36 ` [Buildroot] [PATCH 2/2] fs/ext2: Pass a default string to filesystem label Fabio Estevam
2020-04-15 13:15 ` Pierre-Jean Texier
2020-04-15 13:15 ` [Buildroot] [PATCH 1/2] imx/genimage: Specify the volume-label for vfat Pierre-Jean Texier
2020-04-15 20:51 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox