From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] support/scripts: add check-dotconfig.py
Date: Mon, 20 Apr 2020 11:17:56 +0200 [thread overview]
Message-ID: <20200420091757.2931721-1-romain.naour@gmail.com> (raw)
For the same reason as for 50b747f212be2c9c0f7cf10c674ed488d042715c,
we need to check if the generated configuration file (.config)
contains all symbols present in the defconfig file.
If not there is an issue with the defconfig.
This script will be used in .gitlab-ci.yml.
Inspired by is_toolchain_usable() function from genrandconfig:
https://git.busybox.net/buildroot/tree/utils/genrandconfig?h=2020.02#n164
Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
support/scripts/check-dotconfig.py | 37 ++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100755 support/scripts/check-dotconfig.py
diff --git a/support/scripts/check-dotconfig.py b/support/scripts/check-dotconfig.py
new file mode 100755
index 0000000000..9e60810c1d
--- /dev/null
+++ b/support/scripts/check-dotconfig.py
@@ -0,0 +1,37 @@
+#!/usr/bin/env python3
+
+# This script check if the .config is contains all lines present in the defconfig.
+
+import sys
+
+
+def main():
+ if not (len(sys.argv) == 3):
+ print("Error: incorrect number of arguments")
+ print("""Usage: check-dotconfig <configfile> <defconfig>""")
+ sys.exit(1)
+
+ configfile = sys.argv[1]
+ defconfig = sys.argv[2]
+
+ with open(configfile) as configf:
+ configlines = configf.readlines()
+
+ defconfiglines = []
+ with open(defconfig) as defconfigf:
+ for line in defconfigf.readlines():
+ if line.startswith("BR2_"):
+ defconfiglines.append(line)
+
+ # Check that all the defconfig lines are still present
+ for defconfigline in defconfiglines:
+ if defconfigline not in configlines:
+ print("WARN: defconfig can't be used\n")
+ print(" Missing: %s\n" % defconfigline.strip())
+ return False
+
+ return True
+
+
+if __name__ == "__main__":
+ main()
--
2.25.3
next reply other threads:[~2020-04-20 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 9:17 Romain Naour [this message]
2020-04-20 9:17 ` [Buildroot] [PATCH 2/2] gitlab-ci: check generated config files Romain Naour
2020-04-20 11:52 ` [Buildroot] [PATCH 1/2] support/scripts: add check-dotconfig.py Thomas Petazzoni
2020-04-20 12:19 ` Romain Naour
2020-04-20 12:38 ` Thomas Petazzoni
2020-04-20 13:06 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420091757.2931721-1-romain.naour@gmail.com \
--to=romain.naour@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox