From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] support/scripts: add check-dotconfig.py
Date: Mon, 20 Apr 2020 14:19:55 +0200 [thread overview]
Message-ID: <ec5face2-dba6-695a-81f4-1b4948261720@gmail.com> (raw)
In-Reply-To: <20200420135200.0331bfc0@windsurf.home>
Hello Thomas,
Le 20/04/2020 ? 13:52, Thomas Petazzoni a ?crit?:
> Hello,
>
> On Mon, 20 Apr 2020 11:17:56 +0200
> Romain Naour <romain.naour@gmail.com> wrote:
>
>> For the same reason as for 50b747f212be2c9c0f7cf10c674ed488d042715c,
>> we need to check if the generated configuration file (.config)
>> contains all symbols present in the defconfig file.
>
> Then can we also make the runtime-test infrastructure use this
> check-dotconfig.py script ?
Not with the current implementation of the runtime-test infrastructure since the
defconfig is bundled in the test python script.
The defconfig is written to .config but then we run make olddefconfig to
generate the real .config. So we can't compare the .config file with
check-dotconfig.py without creating a defconfig file.
>
> No need to do it right now, in this patch or patch series, but just
> something that would be good to have.
This can be easily be done in a followup patch.
Best regards,
Romain
>
> Thanks!
>
> Thomas
>
next prev parent reply other threads:[~2020-04-20 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 9:17 [Buildroot] [PATCH 1/2] support/scripts: add check-dotconfig.py Romain Naour
2020-04-20 9:17 ` [Buildroot] [PATCH 2/2] gitlab-ci: check generated config files Romain Naour
2020-04-20 11:52 ` [Buildroot] [PATCH 1/2] support/scripts: add check-dotconfig.py Thomas Petazzoni
2020-04-20 12:19 ` Romain Naour [this message]
2020-04-20 12:38 ` Thomas Petazzoni
2020-04-20 13:06 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec5face2-dba6-695a-81f4-1b4948261720@gmail.com \
--to=romain.naour@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox