From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/syrepo: fix SysV init script
Date: Sat, 25 Apr 2020 16:22:21 +0200 [thread overview]
Message-ID: <20200425162221.5105443c@windsurf.home> (raw)
In-Reply-To: <20200420095738.16104-1-heiko.thiery@gmail.com>
Hello Heiko,
Minor nit: typo in commit title: syrepo -> sysrepo. More questions below.
On Mon, 20 Apr 2020 11:57:38 +0200
Heiko Thiery <heiko.thiery@gmail.com> wrote:
> The sysrepo-plugind does not support to be controlled via the PID by the
> start-stop-daemon. This is because sysrepo-plugind does a fork.
> Thus the daemon is running with another PID known by start-stop-daemon.
"known" by start-stop-daemon, or "not known" ?
Also, it is not very clear. Indeed, in the "start" step, you're not
asking start-stop-daemon to create a PID file using the -m option. So
you're relying on the daemon to create one. Is this PID file incorrect
? Normally, when it is created by the daemon itself, even if the daemon
forks, it should be fine.
Otherwise, can you ask the daemon not to fork, and let
start-stop-daemon take care of this ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-04-25 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 9:57 [Buildroot] [PATCH 1/1] package/syrepo: fix SysV init script Heiko Thiery
2020-04-25 14:22 ` Thomas Petazzoni [this message]
2020-04-25 15:26 ` Heiko Thiery
2020-04-25 19:37 ` Thomas Petazzoni
2020-04-25 19:58 ` Heiko Thiery
2020-04-25 20:07 ` Thomas Petazzoni
2020-04-25 20:18 ` Heiko Thiery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200425162221.5105443c@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox