From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/syrepo: fix SysV init script
Date: Sat, 25 Apr 2020 22:07:58 +0200 [thread overview]
Message-ID: <20200425220758.7e83e2e0@windsurf.home> (raw)
In-Reply-To: <CAEyMn7atSwtJ6XHD3utVG+LWp7kprdKdufD5e6-qP_61_qHZMw@mail.gmail.com>
On Sat, 25 Apr 2020 21:58:56 +0200
Heiko Thiery <heiko.thiery@gmail.com> wrote:
> No it doesn't. The confusion is due to my bad commit message ;-/ I try
> to explain it better.
>
> The current script is not able to stop the daemon.
>
> Options to fix the problem:
>
> A) By adding the "-m -p $PIDFILE" option the pid file will be created
> but it will not contain the correct PID used by the daemon. This is
> obviously because the daemon forks.
> B) By not starting the daemon in background (sysrepo-plugind -d) and
> let do it by start-stop-daemon with "-b" option the log messages of
> the daemon will not longer ends in the syslog but to stderr.
> C) start the daemon without a pidfile and stop the daemon with the "-x" option.
>
> I think the best option is C. This is what the patch does.
Absolutely :-) I'll update the commit message with this explanation
when applying.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-04-25 20:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 9:57 [Buildroot] [PATCH 1/1] package/syrepo: fix SysV init script Heiko Thiery
2020-04-25 14:22 ` Thomas Petazzoni
2020-04-25 15:26 ` Heiko Thiery
2020-04-25 19:37 ` Thomas Petazzoni
2020-04-25 19:58 ` Heiko Thiery
2020-04-25 20:07 ` Thomas Petazzoni [this message]
2020-04-25 20:18 ` Heiko Thiery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200425220758.7e83e2e0@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox