From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 1/1] package/libtasn1: fix build with gcc 4.8
Date: Mon, 27 Apr 2020 22:31:52 +0200 [thread overview]
Message-ID: <20200427223152.3eb367dc@windsurf.home> (raw)
In-Reply-To: <20200424180321.892100-1-fontaine.fabrice@gmail.com>
On Fri, 24 Apr 2020 20:03:21 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fixes:
> - http://autobuild.buildroot.org/results/0030c903abf6c964806a97067af94a99867a3896
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Yann E. Morin):
> - Set -std=gnu99 instead of patching source code
>
> package/libtasn1/libtasn1.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/libtasn1/libtasn1.mk b/package/libtasn1/libtasn1.mk
> index 9b8260ab48..d5a6c69965 100644
> --- a/package/libtasn1/libtasn1.mk
> +++ b/package/libtasn1/libtasn1.mk
> @@ -17,4 +17,6 @@ LIBTASN1_AUTORECONF = YES
> # 'missing' fallback logic botched so disable it completely
> LIBTASN1_CONF_ENV = MAKEINFO="true"
>
> +LIBTASN1_CONF_OPTS = CFLAGS="$(TARGET_CFLAGS) -std=gnu99"
BTW: this should be fixed upstream by adding AC_PROG_CC_C99 in the
configure.ac. Then we can drop adding -std=gnu99 manually.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-04-27 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 18:03 [Buildroot] [PATCH v2, 1/1] package/libtasn1: fix build with gcc 4.8 Fabrice Fontaine
2020-04-27 20:31 ` Thomas Petazzoni
2020-04-27 20:31 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427223152.3eb367dc@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox