* [Buildroot] [PATCH v2, 1/1] package/libtasn1: fix build with gcc 4.8
@ 2020-04-24 18:03 Fabrice Fontaine
2020-04-27 20:31 ` Thomas Petazzoni
2020-04-27 20:31 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2020-04-24 18:03 UTC (permalink / raw)
To: buildroot
Fixes:
- http://autobuild.buildroot.org/results/0030c903abf6c964806a97067af94a99867a3896
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Yann E. Morin):
- Set -std=gnu99 instead of patching source code
package/libtasn1/libtasn1.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/libtasn1/libtasn1.mk b/package/libtasn1/libtasn1.mk
index 9b8260ab48..d5a6c69965 100644
--- a/package/libtasn1/libtasn1.mk
+++ b/package/libtasn1/libtasn1.mk
@@ -17,4 +17,6 @@ LIBTASN1_AUTORECONF = YES
# 'missing' fallback logic botched so disable it completely
LIBTASN1_CONF_ENV = MAKEINFO="true"
+LIBTASN1_CONF_OPTS = CFLAGS="$(TARGET_CFLAGS) -std=gnu99"
+
$(eval $(autotools-package))
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v2, 1/1] package/libtasn1: fix build with gcc 4.8
2020-04-24 18:03 [Buildroot] [PATCH v2, 1/1] package/libtasn1: fix build with gcc 4.8 Fabrice Fontaine
@ 2020-04-27 20:31 ` Thomas Petazzoni
2020-04-27 20:31 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2020-04-27 20:31 UTC (permalink / raw)
To: buildroot
On Fri, 24 Apr 2020 20:03:21 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fixes:
> - http://autobuild.buildroot.org/results/0030c903abf6c964806a97067af94a99867a3896
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Yann E. Morin):
> - Set -std=gnu99 instead of patching source code
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v2, 1/1] package/libtasn1: fix build with gcc 4.8
2020-04-24 18:03 [Buildroot] [PATCH v2, 1/1] package/libtasn1: fix build with gcc 4.8 Fabrice Fontaine
2020-04-27 20:31 ` Thomas Petazzoni
@ 2020-04-27 20:31 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2020-04-27 20:31 UTC (permalink / raw)
To: buildroot
On Fri, 24 Apr 2020 20:03:21 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fixes:
> - http://autobuild.buildroot.org/results/0030c903abf6c964806a97067af94a99867a3896
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Yann E. Morin):
> - Set -std=gnu99 instead of patching source code
>
> package/libtasn1/libtasn1.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/libtasn1/libtasn1.mk b/package/libtasn1/libtasn1.mk
> index 9b8260ab48..d5a6c69965 100644
> --- a/package/libtasn1/libtasn1.mk
> +++ b/package/libtasn1/libtasn1.mk
> @@ -17,4 +17,6 @@ LIBTASN1_AUTORECONF = YES
> # 'missing' fallback logic botched so disable it completely
> LIBTASN1_CONF_ENV = MAKEINFO="true"
>
> +LIBTASN1_CONF_OPTS = CFLAGS="$(TARGET_CFLAGS) -std=gnu99"
BTW: this should be fixed upstream by adding AC_PROG_CC_C99 in the
configure.ac. Then we can drop adding -std=gnu99 manually.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-27 20:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-24 18:03 [Buildroot] [PATCH v2, 1/1] package/libtasn1: fix build with gcc 4.8 Fabrice Fontaine
2020-04-27 20:31 ` Thomas Petazzoni
2020-04-27 20:31 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox