Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/cracklib: add python3 support
Date: Tue, 19 May 2020 21:12:23 +0200	[thread overview]
Message-ID: <20200519191223.GH27030@scaer> (raw)
In-Reply-To: <20200519190436.GG27030@scaer>

Fabrice, All,

On 2020-05-19 21:04 +0200, Yann E. MORIN spake thusly:
> On 2020-02-02 21:53 +0100, Fabrice Fontaine spake thusly:
> > python bindings supports python3 since version 2.8.19 and
> > https://github.com/cracklib/cracklib/commit/219de98766b9f1e4c8c5b174de770158ffda3a93
> > 
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> 
> Applied to master, thanks.
> (but I forgot to add a reference to a recent build failure...)

I eventually had to revert it, as the preparatory patch against python
was not applied, as upstream believes it is dangerous, and are still
debating the proper way:
    https://bugs.python.org/issue39026#msg369309

Hint: they believe removing the include is the best course of action.

Can you have anotherlook, please?

Thanks, and sorry for the long delay.,..

Regards,
Yann E. MORIN.

> Regards,
> Yann E. MORIN.
> 
> > ---
> >  package/cracklib/cracklib.mk | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/package/cracklib/cracklib.mk b/package/cracklib/cracklib.mk
> > index 91d510ff34..be1b50f138 100644
> > --- a/package/cracklib/cracklib.mk
> > +++ b/package/cracklib/cracklib.mk
> > @@ -19,9 +19,9 @@ else
> >  CRACKLIB_CONF_OPTS += --without-zlib
> >  endif
> >  
> > -ifeq ($(BR2_PACKAGE_PYTHON),y)
> > +ifeq ($(BR2_PACKAGE_PYTHON)$(BR2_PACKAGE_PYTHON3),y)
> >  CRACKLIB_CONF_OPTS += --with-python
> > -CRACKLIB_DEPENDENCIES += python
> > +CRACKLIB_DEPENDENCIES += $(if $(BR2_PACKAGE_PYTHON),python,python3)
> >  else
> >  CRACKLIB_CONF_OPTS += --without-python
> >  endif
> > -- 
> > 2.24.1
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-05-19 19:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-02 20:53 [Buildroot] [PATCH 1/2] package/python3: fix initconfig.h include Fabrice Fontaine
2020-02-02 20:53 ` [Buildroot] [PATCH 2/2] package/cracklib: add python3 support Fabrice Fontaine
2020-05-19 19:04   ` Yann E. MORIN
2020-05-19 19:12     ` Yann E. MORIN [this message]
2021-05-26 19:16 ` [Buildroot] [PATCH 1/2] package/python3: fix initconfig.h include Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200519191223.GH27030@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox