[Buildroot] [PATCH 1/2] package/python3: fix initconfig.h include

[Buildroot] [PATCH 1/2] package/python3: fix initconfig.h include

[Fabrice Fontaine]

This fix is needed to enable cracklib with python3

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 ...n-pystate.h-fix-initconfig.h-include.patch | 30 +++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 package/python3/0034-Include-cpython-pystate.h-fix-initconfig.h-include.patch

diff --git a/package/python3/0034-Include-cpython-pystate.h-fix-initconfig.h-include.patch b/package/python3/0034-Include-cpython-pystate.h-fix-initconfig.h-include.patch
new file mode 100644
index 0000000000..aa7835e0a4
--- /dev/null
+++ b/package/python3/0034-Include-cpython-pystate.h-fix-initconfig.h-include.patch
@@ -0,0 +1,30 @@
+From ce8731443896e7513239c2d831733b0d87417e42 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Sun, 2 Feb 2020 18:52:56 +0100
+Subject: [PATCH] Include/cpython/pystate.h: fix initconfig.h include
+
+This fix is needed to fix detection of python3.8/Python.h with cracklib
+
+See https://bugs.python.org/issue39026
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+---
+ Include/cpython/pystate.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Include/cpython/pystate.h b/Include/cpython/pystate.h
+index d1792575c9..0a141b6e67 100644
+--- a/Include/cpython/pystate.h
++++ b/Include/cpython/pystate.h
+@@ -6,7 +6,7 @@
+ extern "C" {
+ #endif
+ 
+-#include "cpython/initconfig.h"
++#include "initconfig.h"
+ 
+ PyAPI_FUNC(int) _PyInterpreterState_RequiresIDRef(PyInterpreterState *);
+ PyAPI_FUNC(void) _PyInterpreterState_RequireIDRef(PyInterpreterState *, int);
+-- 
+2.24.1
+
-- 
2.24.1

[Buildroot] [PATCH 2/2] package/cracklib: add python3 support

[Fabrice Fontaine]

python bindings supports python3 since version 2.8.19 and
https://github.com/cracklib/cracklib/commit/219de98766b9f1e4c8c5b174de770158ffda3a93

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/cracklib/cracklib.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/cracklib/cracklib.mk b/package/cracklib/cracklib.mk
index 91d510ff34..be1b50f138 100644
--- a/package/cracklib/cracklib.mk
+++ b/package/cracklib/cracklib.mk
@@ -19,9 +19,9 @@ else
 CRACKLIB_CONF_OPTS += --without-zlib
 endif
 
-ifeq ($(BR2_PACKAGE_PYTHON),y)
+ifeq ($(BR2_PACKAGE_PYTHON)$(BR2_PACKAGE_PYTHON3),y)
 CRACKLIB_CONF_OPTS += --with-python
-CRACKLIB_DEPENDENCIES += python
+CRACKLIB_DEPENDENCIES += $(if $(BR2_PACKAGE_PYTHON),python,python3)
 else
 CRACKLIB_CONF_OPTS += --without-python
 endif
-- 
2.24.1

[Buildroot] [PATCH 2/2] package/cracklib: add python3 support

[Yann E. MORIN]

Fabrice, All,

On 2020-02-02 21:53 +0100, Fabrice Fontaine spake thusly:
> python bindings supports python3 since version 2.8.19 and
> https://github.com/cracklib/cracklib/commit/219de98766b9f1e4c8c5b174de770158ffda3a93
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

(but I forgot to add a reference to a recent build failure...)

Regards,
Yann E. MORIN.

> ---
>  package/cracklib/cracklib.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/cracklib/cracklib.mk b/package/cracklib/cracklib.mk
> index 91d510ff34..be1b50f138 100644
> --- a/package/cracklib/cracklib.mk
> +++ b/package/cracklib/cracklib.mk
> @@ -19,9 +19,9 @@ else
>  CRACKLIB_CONF_OPTS += --without-zlib
>  endif
>  
> -ifeq ($(BR2_PACKAGE_PYTHON),y)
> +ifeq ($(BR2_PACKAGE_PYTHON)$(BR2_PACKAGE_PYTHON3),y)
>  CRACKLIB_CONF_OPTS += --with-python
> -CRACKLIB_DEPENDENCIES += python
> +CRACKLIB_DEPENDENCIES += $(if $(BR2_PACKAGE_PYTHON),python,python3)
>  else
>  CRACKLIB_CONF_OPTS += --without-python
>  endif
> -- 
> 2.24.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 2/2] package/cracklib: add python3 support

[Yann E. MORIN]

Fabrice, All,

On 2020-05-19 21:04 +0200, Yann E. MORIN spake thusly:
> On 2020-02-02 21:53 +0100, Fabrice Fontaine spake thusly:
> > python bindings supports python3 since version 2.8.19 and
> > https://github.com/cracklib/cracklib/commit/219de98766b9f1e4c8c5b174de770158ffda3a93
> > 
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> 
> Applied to master, thanks.
> (but I forgot to add a reference to a recent build failure...)

I eventually had to revert it, as the preparatory patch against python
was not applied, as upstream believes it is dangerous, and are still
debating the proper way:
    https://bugs.python.org/issue39026#msg369309

Hint: they believe removing the include is the best course of action.

Can you have anotherlook, please?

Thanks, and sorry for the long delay.,..

Regards,
Yann E. MORIN.

> Regards,
> Yann E. MORIN.
> 
> > ---
> >  package/cracklib/cracklib.mk | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/package/cracklib/cracklib.mk b/package/cracklib/cracklib.mk
> > index 91d510ff34..be1b50f138 100644
> > --- a/package/cracklib/cracklib.mk
> > +++ b/package/cracklib/cracklib.mk
> > @@ -19,9 +19,9 @@ else
> >  CRACKLIB_CONF_OPTS += --without-zlib
> >  endif
> >  
> > -ifeq ($(BR2_PACKAGE_PYTHON),y)
> > +ifeq ($(BR2_PACKAGE_PYTHON)$(BR2_PACKAGE_PYTHON3),y)
> >  CRACKLIB_CONF_OPTS += --with-python
> > -CRACKLIB_DEPENDENCIES += python
> > +CRACKLIB_DEPENDENCIES += $(if $(BR2_PACKAGE_PYTHON),python,python3)
> >  else
> >  CRACKLIB_CONF_OPTS += --without-python
> >  endif
> > -- 
> > 2.24.1
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/2] package/python3: fix initconfig.h include

[Arnout Vandecappelle]

On 02/02/2020 21:53, Fabrice Fontaine wrote:
> This fix is needed to enable cracklib with python3
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...n-pystate.h-fix-initconfig.h-include.patch | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 package/python3/0034-Include-cpython-pystate.h-fix-initconfig.h-include.patch
> 
> diff --git a/package/python3/0034-Include-cpython-pystate.h-fix-initconfig.h-include.patch b/package/python3/0034-Include-cpython-pystate.h-fix-initconfig.h-include.patch
> new file mode 100644
> index 0000000000..aa7835e0a4
> --- /dev/null
> +++ b/package/python3/0034-Include-cpython-pystate.h-fix-initconfig.h-include.patch
> @@ -0,0 +1,30 @@
> +From ce8731443896e7513239c2d831733b0d87417e42 Mon Sep 17 00:00:00 2001
> +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Date: Sun, 2 Feb 2020 18:52:56 +0100
> +Subject: [PATCH] Include/cpython/pystate.h: fix initconfig.h include
> +
> +This fix is needed to fix detection of python3.8/Python.h with cracklib
> +
> +See https://bugs.python.org/issue39026

 The last comment in that bug suggests to instead just remove the #include from
pystate.h. Care to try that (and report the conclusion in the bug, so it
hopefully progresses a bit)?

 Series marked as Changes Requested.

 Regards,
 Arnout

> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +---
> + Include/cpython/pystate.h | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/Include/cpython/pystate.h b/Include/cpython/pystate.h
> +index d1792575c9..0a141b6e67 100644
> +--- a/Include/cpython/pystate.h
> ++++ b/Include/cpython/pystate.h
> +@@ -6,7 +6,7 @@
> + extern "C" {
> + #endif
> + 
> +-#include "cpython/initconfig.h"
> ++#include "initconfig.h"
> + 
> + PyAPI_FUNC(int) _PyInterpreterState_RequiresIDRef(PyInterpreterState *);
> + PyAPI_FUNC(void) _PyInterpreterState_RequireIDRef(PyInterpreterState *, int);
> +-- 
> +2.24.1
> +
>