* [Buildroot] [PATCH 1/1] boot/uboot/: Name U-Boot boot script image
@ 2020-06-23 23:04 Yair Ben-Avraham
2020-06-24 20:21 ` Yann E. MORIN
2022-01-09 14:54 ` Arnout Vandecappelle
0 siblings, 2 replies; 4+ messages in thread
From: Yair Ben-Avraham @ 2020-06-23 23:04 UTC (permalink / raw)
To: buildroot
Signed-off-by: Yair Ben Avraham <yairba@protonmail.com>
---
boot/uboot/Config.in | 5 +++++
boot/uboot/uboot.mk | 1 +
2 files changed, 6 insertions(+)
diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
index 8cce9b1bae..310c4f8186 100644
--- a/boot/uboot/Config.in
+++ b/boot/uboot/Config.in
@@ -568,6 +568,11 @@ config BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE
help
Source file to generate the U-Boot boot script.
+config BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME
+ string "U-Boot boot script image name"
+ help
+ Image (*not* file) name.
+
endif
if BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG
diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index 71689207e3..ab945eb159 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -340,6 +340,7 @@ define UBOOT_INSTALL_IMAGES_CMDS
$(UBOOT_GENERATE_ENV_IMAGE)
$(if $(BR2_TARGET_UBOOT_BOOT_SCRIPT),
$(MKIMAGE) -C none -A $(MKIMAGE_ARCH) -T script \
+ -n $(BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME) \
-d $(call qstrip,$(BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE)) \
$(BINARIES_DIR)/boot.scr)
endef
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Buildroot] [PATCH 1/1] boot/uboot/: Name U-Boot boot script image
2020-06-23 23:04 [Buildroot] [PATCH 1/1] boot/uboot/: Name U-Boot boot script image Yair Ben-Avraham
@ 2020-06-24 20:21 ` Yann E. MORIN
2020-07-06 4:11 ` Yair Ben-Avraham
2022-01-09 14:54 ` Arnout Vandecappelle
1 sibling, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2020-06-24 20:21 UTC (permalink / raw)
To: buildroot
Yair, All,
On 2020-06-23 23:04 +0000, Yair Ben-Avraham spake thusly:
> Signed-off-by: Yair Ben Avraham <yairba@protonmail.com>
> ---
> boot/uboot/Config.in | 5 +++++
> boot/uboot/uboot.mk | 1 +
> 2 files changed, 6 insertions(+)
>
> diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
> index 8cce9b1bae..310c4f8186 100644
> --- a/boot/uboot/Config.in
> +++ b/boot/uboot/Config.in
> @@ -568,6 +568,11 @@ config BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE
> help
> Source file to generate the U-Boot boot script.
>
> +config BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME
> + string "U-Boot boot script image name"
> + help
> + Image (*not* file) name.
> +
> endif
>
> if BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index 71689207e3..ab945eb159 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -340,6 +340,7 @@ define UBOOT_INSTALL_IMAGES_CMDS
> $(UBOOT_GENERATE_ENV_IMAGE)
> $(if $(BR2_TARGET_UBOOT_BOOT_SCRIPT),
> $(MKIMAGE) -C none -A $(MKIMAGE_ARCH) -T script \
> + -n $(BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME) \
So, when the user does not set the option, we will end up passing:
-n ""
Is that correct?
Regards,
Yann E. MORIN.
> -d $(call qstrip,$(BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE)) \
> $(BINARIES_DIR)/boot.scr)
> endef
> --
> 2.20.1
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH 1/1] boot/uboot/: Name U-Boot boot script image
2020-06-24 20:21 ` Yann E. MORIN
@ 2020-07-06 4:11 ` Yair Ben-Avraham
0 siblings, 0 replies; 4+ messages in thread
From: Yair Ben-Avraham @ 2020-07-06 4:11 UTC (permalink / raw)
To: buildroot
Hi Yann,
Not elegant, but yes. Anyway an empty string is the default in case no image name is mentioned.
See u-boot/tools/mkimage.c static struct image_tool_params params
Yair
--
Yair Ben-Avraham
yairba at protonmail.com
+31.6.1316.5535
??????? Original Message ???????
On Wednesday, June 24, 2020 10:21 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Yair, All,
>
> On 2020-06-23 23:04 +0000, Yair Ben-Avraham spake thusly:
>
> > Signed-off-by: Yair Ben Avraham yairba at protonmail.com
> >
> > ------------------------------------------------------
> >
> > boot/uboot/Config.in | 5 +++++
> > boot/uboot/uboot.mk | 1 +
> > 2 files changed, 6 insertions(+)
> > diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
> > index 8cce9b1bae..310c4f8186 100644
> > --- a/boot/uboot/Config.in
> > +++ b/boot/uboot/Config.in
> > @@ -568,6 +568,11 @@ config BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE
> > help
> > Source file to generate the U-Boot boot script.
> > +config BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME
> >
> > - string "U-Boot boot script image name"
> >
> >
> > - help
> >
> >
> > - Image (*not* file) name.
> >
> >
> > -
> >
> > endif
> > if BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG
> > diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> > index 71689207e3..ab945eb159 100644
> > --- a/boot/uboot/uboot.mk
> > +++ b/boot/uboot/uboot.mk
> > @@ -340,6 +340,7 @@ define UBOOT_INSTALL_IMAGES_CMDS
> > $(UBOOT_GENERATE_ENV_IMAGE)
> > $(if $(BR2_TARGET_UBOOT_BOOT_SCRIPT),
> > $(MKIMAGE) -C none -A $(MKIMAGE_ARCH) -T script \
> >
> > - -n $(BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME) \\
> >
> >
>
> So, when the user does not set the option, we will end up passing:
>
> -n ""
>
> Is that correct?
>
> Regards,
> Yann E. MORIN.
>
> > -d $(call qstrip,$(BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE)) \\
> > $(BINARIES_DIR)/boot.scr)
> >
> >
> > endef
> >
> > ------
> >
> > 2.20.1
> >
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
>
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | /*\ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] boot/uboot/: Name U-Boot boot script image
2020-06-23 23:04 [Buildroot] [PATCH 1/1] boot/uboot/: Name U-Boot boot script image Yair Ben-Avraham
2020-06-24 20:21 ` Yann E. MORIN
@ 2022-01-09 14:54 ` Arnout Vandecappelle
1 sibling, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2022-01-09 14:54 UTC (permalink / raw)
To: Yair Ben-Avraham, buildroot@buildroot.org
Hi Yair,
On 24/06/2020 01:04, Yair Ben-Avraham wrote:
> Signed-off-by: Yair Ben Avraham <yairba@protonmail.com>
Shortly after you submitted this patch, the logic for U-boot scripts moved
from boot/uboot to package/u-boot-tools. Could you update this patch to take
that into account?
Also, please update the commit message to explain the use case. Why would you
want the name field in the script image to be set to anything? AFAIK it is not
visible or used anywhere.
> ---
> boot/uboot/Config.in | 5 +++++
> boot/uboot/uboot.mk | 1 +
> 2 files changed, 6 insertions(+)
>
> diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
> index 8cce9b1bae..310c4f8186 100644
> --- a/boot/uboot/Config.in
> +++ b/boot/uboot/Config.in
> @@ -568,6 +568,11 @@ config BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE
> help
> Source file to generate the U-Boot boot script.
>
> +config BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME
> + string "U-Boot boot script image name"
> + help
> + Image (*not* file) name.
> +
> endif
>
> if BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index 71689207e3..ab945eb159 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -340,6 +340,7 @@ define UBOOT_INSTALL_IMAGES_CMDS
> $(UBOOT_GENERATE_ENV_IMAGE)
> $(if $(BR2_TARGET_UBOOT_BOOT_SCRIPT),
> $(MKIMAGE) -C none -A $(MKIMAGE_ARCH) -T script \
> + -n $(BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME) \
We generally prefer explicit quoting, i.e.
-n "$(call qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_SCRIPT_IMAGE_NAME))"
Regards,
Arnout
> -d $(call qstrip,$(BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE)) \
> $(BINARIES_DIR)/boot.scr)
> endef
> --
> 2.20.1
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-09 14:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-23 23:04 [Buildroot] [PATCH 1/1] boot/uboot/: Name U-Boot boot script image Yair Ben-Avraham
2020-06-24 20:21 ` Yann E. MORIN
2020-07-06 4:11 ` Yair Ben-Avraham
2022-01-09 14:54 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox