Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/5] toolchain: add gcc 10 entry
@ 2020-06-08 22:13 Romain Naour
  2020-06-08 22:13 ` [Buildroot] [PATCH 2/5] package/gcc: add support for gcc 10 Romain Naour
                   ` (4 more replies)
  0 siblings, 5 replies; 14+ messages in thread
From: Romain Naour @ 2020-06-08 22:13 UTC (permalink / raw)
  To: buildroot

In order to add gcc 10 support for internal and external toolchain in
follow-up commits, introduce BR2_TOOLCHAIN_GCC_AT_LEAST_10 symbol.

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 toolchain/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/toolchain/Config.in b/toolchain/Config.in
index 6865199ffc..83f5286701 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -591,10 +591,15 @@ config BR2_TOOLCHAIN_GCC_AT_LEAST_9
 	bool
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_8
 
+config BR2_TOOLCHAIN_GCC_AT_LEAST_10
+	bool
+	select BR2_TOOLCHAIN_GCC_AT_LEAST_9
+
 # This order guarantees that the highest version is set, as kconfig
 # stops affecting a value on the first matching default.
 config BR2_TOOLCHAIN_GCC_AT_LEAST
 	string
+	default "10"	if BR2_TOOLCHAIN_GCC_AT_LEAST_10
 	default "9"	if BR2_TOOLCHAIN_GCC_AT_LEAST_9
 	default "8"	if BR2_TOOLCHAIN_GCC_AT_LEAST_8
 	default "7"	if BR2_TOOLCHAIN_GCC_AT_LEAST_7
-- 
2.25.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 2/5] package/gcc: add support for gcc 10
  2020-06-08 22:13 [Buildroot] [PATCH 1/5] toolchain: add gcc 10 entry Romain Naour
@ 2020-06-08 22:13 ` Romain Naour
  2020-06-24 19:55   ` Thomas Petazzoni
  2020-06-08 22:13 ` [Buildroot] [PATCH 3/5] arch: add BR2_ARCH_NEEDS_GCC_AT_LEAST_10 Romain Naour
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 14+ messages in thread
From: Romain Naour @ 2020-06-08 22:13 UTC (permalink / raw)
  To: buildroot

Keep the same patch as for gcc 9.x fixing a parallel build issue:
58ecbbc3ef18c43ae1c02a5c4bf30aa7ef2d8092.

Keep libzstd support disabled for now, it could be used to LTO bytecode.

https://gcc.gnu.org/gcc-10/changes.html
https://gcc.gnu.org/gcc-10/porting_to.html

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 ...move-SELFTEST_DEPS-before-including-.patch | 79 +++++++++++++++++++
 package/gcc/Config.in.host                    | 14 ++++
 package/gcc/gcc.hash                          |  2 +
 package/gcc/gcc.mk                            |  3 +-
 4 files changed, 97 insertions(+), 1 deletion(-)
 create mode 100644 package/gcc/10.1.0/0001-gcc-Makefile.in-move-SELFTEST_DEPS-before-including-.patch

diff --git a/package/gcc/10.1.0/0001-gcc-Makefile.in-move-SELFTEST_DEPS-before-including-.patch b/package/gcc/10.1.0/0001-gcc-Makefile.in-move-SELFTEST_DEPS-before-including-.patch
new file mode 100644
index 0000000000..281bb53690
--- /dev/null
+++ b/package/gcc/10.1.0/0001-gcc-Makefile.in-move-SELFTEST_DEPS-before-including-.patch
@@ -0,0 +1,79 @@
+From f05b73275515c4a1a70e28e06229bf682ac74385 Mon Sep 17 00:00:00 2001
+From: Romain Naour <romain.naour@gmail.com>
+Date: Thu, 21 May 2020 15:58:02 +0200
+Subject: [PATCH] gcc/Makefile.in: move SELFTEST_DEPS before including language
+ makefile fragments
+
+As reported by several Buildroot users [1][2][3], the gcc build
+may fail while running selftests makefile target.
+
+The problem only occurs when ccache is used with gcc 9 and 10,
+probably due to a race condition.
+
+While debuging with "make -p" we can notice that s-selftest-c target
+contain only "cc1" as dependency instead of cc1 and SELFTEST_DEPS [4].
+
+  s-selftest-c: cc1
+
+While the build is failing, the s-selftest-c dependencies recipe is
+still running and reported as a bug by make.
+
+  "Dependencies recipe running (THIS IS A BUG)."
+
+A change [5] in gcc 9 seems to introduce the problem since we can't
+reproduce this problem with gcc 8.
+
+As suggested by Yann E. MORIN [6], move SELFTEST_DEPS before
+including language makefile fragments.
+
+With the fix applied, the s-seltest-c dependency contains
+SELFTEST_DEPS value.
+
+  s-selftest-c: cc1 xgcc specs stmp-int-hdrs ../../gcc/testsuite/selftests
+
+[1] http://lists.busybox.net/pipermail/buildroot/2020-May/282171.html
+[2] http://lists.busybox.net/pipermail/buildroot/2020-May/282766.html
+[3] https://github.com/cirosantilli/linux-kernel-module-cheat/issues/108
+[4] https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/c/Make-lang.in;h=bfae6fd2549c4f728816cd355fa9739dcc08fcde;hb=033eb5671769a4c681a44aad08a454e667e08502#l120
+[5] https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=033eb5671769a4c681a44aad08a454e667e08502
+[6] http://lists.busybox.net/pipermail/buildroot/2020-May/283213.html
+
+Signed-off-by: Romain Naour <romain.naour@gmail.com>
+Cc: Ben Dakin-Norris <ben.dakin-norris@navtechradar.com>
+Cc: Maxim Kochetkov <fido_max@inbox.ru>
+Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
+Cc: Yann E. MORIN <yann.morin.1998@free.fr>
+Cc: David Malcolm <dmalcolm@gcc.gnu.org>
+---
+This patch should be backported to gcc 10 and gcc 9.
+---
+ gcc/Makefile.in | 6 ++++--
+ 1 file changed, 4 insertions(+), 2 deletions(-)
+
+diff --git a/gcc/Makefile.in b/gcc/Makefile.in
+index 543b477ff18..c8611e35c70 100644
+--- a/gcc/Makefile.in
++++ b/gcc/Makefile.in
+@@ -1725,6 +1725,10 @@ $(FULL_DRIVER_NAME): ./xgcc
+ 	rm -f $@
+ 	$(LN_S) $< $@
+ 
++# SELFTEST_DEPS need to be set before including language makefile fragments.
++# Otherwise $(SELFTEST_DEPS) is empty when used from various <LANG>/Make-lang.in.
++SELFTEST_DEPS = $(GCC_PASSES) stmp-int-hdrs $(srcdir)/testsuite/selftests
++
+ #\f
+ # Language makefile fragments.
+ 
+@@ -2001,8 +2005,6 @@ DEVNULL=$(if $(findstring mingw,$(build)),nul,/dev/null)
+ SELFTEST_FLAGS = -nostdinc $(DEVNULL) -S -o $(DEVNULL) \
+ 	-fself-test=$(srcdir)/testsuite/selftests
+ 
+-SELFTEST_DEPS = $(GCC_PASSES) stmp-int-hdrs $(srcdir)/testsuite/selftests
+-
+ # Run the selftests during the build once we have a driver and the frontend,
+ # so that self-test failures are caught as early as possible.
+ # Use "s-selftest-FE" to ensure that we only run the selftests if the
+-- 
+2.25.4
+
diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host
index a41408b72b..264428d06b 100644
--- a/package/gcc/Config.in.host
+++ b/package/gcc/Config.in.host
@@ -50,6 +50,19 @@ config BR2_GCC_VERSION_9_X
 	depends on !BR2_csky
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_9
 
+config BR2_GCC_VERSION_10_X
+	bool "gcc 10.x"
+	# or1k needs binutils >= 2.32
+	depends on !(BR2_or1k && BR2_BINUTILS_VERSION_2_31_X)
+	# powerpc spe support has been deprecated since gcc 8.x.
+	# https://gcc.gnu.org/ml/gcc/2018-04/msg00102.html
+	depends on !BR2_powerpc_SPE
+	# C-SKY sk610 needs abiv1, which is not supported in
+	# upstream gcc. C-SKY gcc upstream support not tested
+	# with upstream binutils and glibc.
+	depends on !BR2_csky
+	select BR2_TOOLCHAIN_GCC_AT_LEAST_10
+
 endchoice
 
 # libcilkrts was introduced in gcc 4.9 and removed in gcc 8.x
@@ -75,6 +88,7 @@ config BR2_GCC_VERSION
 	default "7.5.0"     if BR2_GCC_VERSION_7_X
 	default "8.4.0"     if BR2_GCC_VERSION_8_X
 	default "9.3.0"     if BR2_GCC_VERSION_9_X
+	default "10.1.0"    if BR2_GCC_VERSION_10_X
 	default "arc-2020.03-release" if BR2_GCC_VERSION_ARC
 	default "48152afb96c59733d5bc79e3399bb7b3d4b44266" if BR2_GCC_VERSION_CSKY
 
diff --git a/package/gcc/gcc.hash b/package/gcc/gcc.hash
index ef1290fc7c..91bb86f0aa 100644
--- a/package/gcc/gcc.hash
+++ b/package/gcc/gcc.hash
@@ -4,6 +4,8 @@ sha512  fe716cc19f2e3255d3a8b1b8290777bf769c6d98e6e0b07b81a3d6ad43f8af74cb170dfa
 sha512  6de904f552a02de33b11ef52312bb664396efd7e1ce3bbe37bfad5ef617f133095b3767b4804bc7fe78df335cb53bc83f1ac055baed40979ce4c2c3e46b70280  gcc-8.4.0.tar.xz
 #  From ftp://gcc.gnu.org/pub/gcc/releases/gcc-9.3.0/sha512.sum
 sha512  4b9e3639eef6e623747a22c37a904b4750c93b6da77cf3958d5047e9b5ebddb7eebe091cc16ca0a227c0ecbd2bf3b984b221130f269a97ee4cc18f9cf6c444de  gcc-9.3.0.tar.xz
+# From ftp://gcc.gnu.org/pub/gcc/releases/gcc-10.1.0/sha512.sum
+sha512  0cb2a74c793face751f42bc580960b00e2bfea785872a0a2155f1f1dbfaa248f9591b67f4322db0f096f8844aca9243bc02732bda106c3b6e43b02bb67eb3096  gcc-10.1.0.tar.xz
 
 # Locally calculated (fetched from Github)
 sha512  09ad77fce757d77f2db49cd049b78861abfa5c1c6c3be76228815ec2b15810c1985525c48b0300e83e88f3fa33dee0062f34790cc8b6bc2fa6b0301595acf42b  gcc-arc-2020.03-release.tar.gz
diff --git a/package/gcc/gcc.mk b/package/gcc/gcc.mk
index af25d268a7..d8260bc87b 100644
--- a/package/gcc/gcc.mk
+++ b/package/gcc/gcc.mk
@@ -82,7 +82,8 @@ HOST_GCC_COMMON_CONF_OPTS = \
 	--with-mpc=$(HOST_DIR) \
 	--with-mpfr=$(HOST_DIR) \
 	--with-pkgversion="Buildroot $(BR2_VERSION_FULL)" \
-	--with-bugurl="http://bugs.buildroot.net/"
+	--with-bugurl="http://bugs.buildroot.net/" \
+	--without-zstd
 
 # Don't build documentation. It takes up extra space / build time,
 # and sometimes needs specific makeinfo versions to work
-- 
2.25.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 3/5] arch: add BR2_ARCH_NEEDS_GCC_AT_LEAST_10
  2020-06-08 22:13 [Buildroot] [PATCH 1/5] toolchain: add gcc 10 entry Romain Naour
  2020-06-08 22:13 ` [Buildroot] [PATCH 2/5] package/gcc: add support for gcc 10 Romain Naour
@ 2020-06-08 22:13 ` Romain Naour
  2020-06-24 19:55   ` Thomas Petazzoni
  2020-06-08 22:13 ` [Buildroot] [PATCH 4/5] toolchain-external: add gcc 10 entry Romain Naour
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 14+ messages in thread
From: Romain Naour @ 2020-06-08 22:13 UTC (permalink / raw)
  To: buildroot

This new symbol will be used by architectures introduced with gcc 10 and
by external toolchains based on gcc 10.

[1] https://gcc.gnu.org/gcc-10/changes.html

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 arch/Config.in             | 4 ++++
 package/gcc/Config.in.host | 1 +
 2 files changed, 5 insertions(+)

diff --git a/arch/Config.in b/arch/Config.in
index 94bd2150ca..0707c076e2 100644
--- a/arch/Config.in
+++ b/arch/Config.in
@@ -308,6 +308,10 @@ config BR2_ARCH_NEEDS_GCC_AT_LEAST_9
 	bool
 	select BR2_ARCH_NEEDS_GCC_AT_LEAST_8
 
+config BR2_ARCH_NEEDS_GCC_AT_LEAST_10
+	bool
+	select BR2_ARCH_NEEDS_GCC_AT_LEAST_9
+
 # The following string values are defined by the individual
 # Config.in.$ARCH files
 config BR2_ARCH
diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host
index 264428d06b..c7444e243b 100644
--- a/package/gcc/Config.in.host
+++ b/package/gcc/Config.in.host
@@ -39,6 +39,7 @@ config BR2_GCC_VERSION_8_X
 
 config BR2_GCC_VERSION_9_X
 	bool "gcc 9.x"
+	depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_10
 	# or1k needs binutils >= 2.32
 	depends on !(BR2_or1k && BR2_BINUTILS_VERSION_2_31_X)
 	# powerpc spe support has been deprecated since gcc 8.x.
-- 
2.25.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 4/5] toolchain-external: add gcc 10 entry
  2020-06-08 22:13 [Buildroot] [PATCH 1/5] toolchain: add gcc 10 entry Romain Naour
  2020-06-08 22:13 ` [Buildroot] [PATCH 2/5] package/gcc: add support for gcc 10 Romain Naour
  2020-06-08 22:13 ` [Buildroot] [PATCH 3/5] arch: add BR2_ARCH_NEEDS_GCC_AT_LEAST_10 Romain Naour
@ 2020-06-08 22:13 ` Romain Naour
  2020-06-24 19:55   ` Thomas Petazzoni
  2020-06-08 22:13 ` [Buildroot] [PATCH 5/5] package/gcc: switch to gcc 9.x as the default Romain Naour
  2020-06-24 19:53 ` [Buildroot] [PATCH 1/5] toolchain: add gcc 10 entry Thomas Petazzoni
  4 siblings, 1 reply; 14+ messages in thread
From: Romain Naour @ 2020-06-08 22:13 UTC (permalink / raw)
  To: buildroot

This patch allows to use an external toolchain based on gcc 10.

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 .../toolchain-external-custom/Config.in.options               | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
index a4430f7169..ee45e73292 100644
--- a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
+++ b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
@@ -31,6 +31,10 @@ choice
 	  Set to the gcc version that is used by your external
 	  toolchain.
 
+config BR2_TOOLCHAIN_EXTERNAL_GCC_10
+	bool "10.x"
+	select BR2_TOOLCHAIN_GCC_AT_LEAST_10
+
 config BR2_TOOLCHAIN_EXTERNAL_GCC_9
 	bool "9.x"
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_9
-- 
2.25.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 5/5] package/gcc: switch to gcc 9.x as the default
  2020-06-08 22:13 [Buildroot] [PATCH 1/5] toolchain: add gcc 10 entry Romain Naour
                   ` (2 preceding siblings ...)
  2020-06-08 22:13 ` [Buildroot] [PATCH 4/5] toolchain-external: add gcc 10 entry Romain Naour
@ 2020-06-08 22:13 ` Romain Naour
  2020-06-24 19:56   ` Thomas Petazzoni
  2020-06-24 19:53 ` [Buildroot] [PATCH 1/5] toolchain: add gcc 10 entry Thomas Petazzoni
  4 siblings, 1 reply; 14+ messages in thread
From: Romain Naour @ 2020-06-08 22:13 UTC (permalink / raw)
  To: buildroot

Even if gcc 8 is still maintained for some time (gcc 8.5 is pending),
switch to gcc 9.x since it has been released since 2019-05-03 and
gcc 10.x is available since 2020-05-07.

We have been having toolchains in the autobuilders with gcc
9.x for a while, so the vast majority of the problems should have
already been solved.

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/gcc/Config.in.host | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host
index c7444e243b..f417712b52 100644
--- a/package/gcc/Config.in.host
+++ b/package/gcc/Config.in.host
@@ -4,7 +4,7 @@ choice
 	prompt "GCC compiler Version"
 	default BR2_GCC_VERSION_ARC if BR2_arc
 	default BR2_GCC_VERSION_CSKY if BR2_csky
-	default BR2_GCC_VERSION_8_X
+	default BR2_GCC_VERSION_9_X
 	help
 	  Select the version of gcc you wish to use.
 
-- 
2.25.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 1/5] toolchain: add gcc 10 entry
  2020-06-08 22:13 [Buildroot] [PATCH 1/5] toolchain: add gcc 10 entry Romain Naour
                   ` (3 preceding siblings ...)
  2020-06-08 22:13 ` [Buildroot] [PATCH 5/5] package/gcc: switch to gcc 9.x as the default Romain Naour
@ 2020-06-24 19:53 ` Thomas Petazzoni
  4 siblings, 0 replies; 14+ messages in thread
From: Thomas Petazzoni @ 2020-06-24 19:53 UTC (permalink / raw)
  To: buildroot

On Tue,  9 Jun 2020 00:13:43 +0200
Romain Naour <romain.naour@gmail.com> wrote:

> In order to add gcc 10 support for internal and external toolchain in
> follow-up commits, introduce BR2_TOOLCHAIN_GCC_AT_LEAST_10 symbol.
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
>  toolchain/Config.in | 5 +++++
>  1 file changed, 5 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 2/5] package/gcc: add support for gcc 10
  2020-06-08 22:13 ` [Buildroot] [PATCH 2/5] package/gcc: add support for gcc 10 Romain Naour
@ 2020-06-24 19:55   ` Thomas Petazzoni
  2020-06-24 20:38     ` Romain Naour
  0 siblings, 1 reply; 14+ messages in thread
From: Thomas Petazzoni @ 2020-06-24 19:55 UTC (permalink / raw)
  To: buildroot

On Tue,  9 Jun 2020 00:13:44 +0200
Romain Naour <romain.naour@gmail.com> wrote:

> Keep the same patch as for gcc 9.x fixing a parallel build issue:
> 58ecbbc3ef18c43ae1c02a5c4bf30aa7ef2d8092.
> 
> Keep libzstd support disabled for now, it could be used to LTO bytecode.

"... it could be used for LTO bytecode compression", otherwise it
doesn't make a lot of sense.

I've applied, but I have some comments/questions below.

> +config BR2_GCC_VERSION_10_X
> +	bool "gcc 10.x"
> +	# or1k needs binutils >= 2.32
> +	depends on !(BR2_or1k && BR2_BINUTILS_VERSION_2_31_X)

Why are we doing this here, instead of in the binutils package ? This
looks strange.

> +	# powerpc spe support has been deprecated since gcc 8.x.
> +	# https://gcc.gnu.org/ml/gcc/2018-04/msg00102.html
> +	depends on !BR2_powerpc_SPE

Should we now drop support for PowerPC SPE ?

> +	# C-SKY sk610 needs abiv1, which is not supported in
> +	# upstream gcc. C-SKY gcc upstream support not tested
> +	# with upstream binutils and glibc.
> +	depends on !BR2_csky

We haven't had any news/contribution for C-SKY people for quite a
while. I know in recent SoC they have used RISC-V cores, but they were
supposed to continue making C-SKY based SoCs. I am fearing that this
looks like yet another abandoned CPU architecture :-/

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 3/5] arch: add BR2_ARCH_NEEDS_GCC_AT_LEAST_10
  2020-06-08 22:13 ` [Buildroot] [PATCH 3/5] arch: add BR2_ARCH_NEEDS_GCC_AT_LEAST_10 Romain Naour
@ 2020-06-24 19:55   ` Thomas Petazzoni
  0 siblings, 0 replies; 14+ messages in thread
From: Thomas Petazzoni @ 2020-06-24 19:55 UTC (permalink / raw)
  To: buildroot

On Tue,  9 Jun 2020 00:13:45 +0200
Romain Naour <romain.naour@gmail.com> wrote:

> This new symbol will be used by architectures introduced with gcc 10 and
> by external toolchains based on gcc 10.
> 
> [1] https://gcc.gnu.org/gcc-10/changes.html
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
>  arch/Config.in             | 4 ++++
>  package/gcc/Config.in.host | 1 +
>  2 files changed, 5 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 4/5] toolchain-external: add gcc 10 entry
  2020-06-08 22:13 ` [Buildroot] [PATCH 4/5] toolchain-external: add gcc 10 entry Romain Naour
@ 2020-06-24 19:55   ` Thomas Petazzoni
  0 siblings, 0 replies; 14+ messages in thread
From: Thomas Petazzoni @ 2020-06-24 19:55 UTC (permalink / raw)
  To: buildroot

On Tue,  9 Jun 2020 00:13:46 +0200
Romain Naour <romain.naour@gmail.com> wrote:

> This patch allows to use an external toolchain based on gcc 10.
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
>  .../toolchain-external-custom/Config.in.options               | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 5/5] package/gcc: switch to gcc 9.x as the default
  2020-06-08 22:13 ` [Buildroot] [PATCH 5/5] package/gcc: switch to gcc 9.x as the default Romain Naour
@ 2020-06-24 19:56   ` Thomas Petazzoni
  2020-06-24 20:41     ` Romain Naour
                       ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Thomas Petazzoni @ 2020-06-24 19:56 UTC (permalink / raw)
  To: buildroot

On Tue,  9 Jun 2020 00:13:47 +0200
Romain Naour <romain.naour@gmail.com> wrote:

> Even if gcc 8 is still maintained for some time (gcc 8.5 is pending),
> switch to gcc 9.x since it has been released since 2019-05-03 and
> gcc 10.x is available since 2020-05-07.
> 
> We have been having toolchains in the autobuilders with gcc
> 9.x for a while, so the vast majority of the problems should have
> already been solved.
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
>  package/gcc/Config.in.host | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Following this, we should drop gcc 7.x support. However, one defconfig
(roseapplepi) still uses gcc 7.x. I've notified Peter Korsgaard on IRC,
and I am doing it here as well: if this defconfig is not updated to a
newer kernel that builds with gcc >= 8.x, we will have to drop support
for this defconfig.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 2/5] package/gcc: add support for gcc 10
  2020-06-24 19:55   ` Thomas Petazzoni
@ 2020-06-24 20:38     ` Romain Naour
  0 siblings, 0 replies; 14+ messages in thread
From: Romain Naour @ 2020-06-24 20:38 UTC (permalink / raw)
  To: buildroot

Hi Thomas,

Le 24/06/2020 ? 21:55, Thomas Petazzoni a ?crit?:
> On Tue,  9 Jun 2020 00:13:44 +0200
> Romain Naour <romain.naour@gmail.com> wrote:
> 
>> Keep the same patch as for gcc 9.x fixing a parallel build issue:
>> 58ecbbc3ef18c43ae1c02a5c4bf30aa7ef2d8092.
>>
>> Keep libzstd support disabled for now, it could be used to LTO bytecode.
> 
> "... it could be used for LTO bytecode compression", otherwise it
> doesn't make a lot of sense.
> 
> I've applied, but I have some comments/questions below.
> 
>> +config BR2_GCC_VERSION_10_X
>> +	bool "gcc 10.x"
>> +	# or1k needs binutils >= 2.32
>> +	depends on !(BR2_or1k && BR2_BINUTILS_VERSION_2_31_X)
> 
> Why are we doing this here, instead of in the binutils package ? This
> looks strange.

This dependency was added by [1] when we had a gcc 5 fork for or1k.

[1]
https://git.buildroot.net/buildroot/commit/?id=e0ba09768eb27872e8685754952601bdac9ac75b

It here because it's gcc that require a recent enough binutils version.
Maybe we should consider adding BR2_TOOLCHAIN_BINUTILS_AT_LEAST_xxxx.
I think we already have a problem with new cpu variant that require the latest
binutils version.

> 
>> +	# powerpc spe support has been deprecated since gcc 8.x.
>> +	# https://gcc.gnu.org/ml/gcc/2018-04/msg00102.html
>> +	depends on !BR2_powerpc_SPE
> 
> Should we now drop support for PowerPC SPE ?

If every body is ok, then we can drop it.

> 
>> +	# C-SKY sk610 needs abiv1, which is not supported in
>> +	# upstream gcc. C-SKY gcc upstream support not tested
>> +	# with upstream binutils and glibc.
>> +	depends on !BR2_csky
> 
> We haven't had any news/contribution for C-SKY people for quite a
> while. I know in recent SoC they have used RISC-V cores, but they were
> supposed to continue making C-SKY based SoCs. I am fearing that this
> looks like yet another abandoned CPU architecture :-/

I'm not sure about this, their gitlab is still active:
https://gitlab.com/c-sky/buildroot/-/pipelines

IIRC we had some news from Guo Ren about the upstream qemu support for csky cpus

http://lists.busybox.net/pipermail/buildroot/2020-May/283411.html

Best regards,
Romain

> 
> Best regards,
> 
> Thomas
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 5/5] package/gcc: switch to gcc 9.x as the default
  2020-06-24 19:56   ` Thomas Petazzoni
@ 2020-06-24 20:41     ` Romain Naour
  2020-07-07 13:13     ` Peter Korsgaard
  2020-08-29 12:13     ` Peter Korsgaard
  2 siblings, 0 replies; 14+ messages in thread
From: Romain Naour @ 2020-06-24 20:41 UTC (permalink / raw)
  To: buildroot

Hi Thomas,

Le 24/06/2020 ? 21:56, Thomas Petazzoni a ?crit?:
> On Tue,  9 Jun 2020 00:13:47 +0200
> Romain Naour <romain.naour@gmail.com> wrote:
> 
>> Even if gcc 8 is still maintained for some time (gcc 8.5 is pending),
>> switch to gcc 9.x since it has been released since 2019-05-03 and
>> gcc 10.x is available since 2020-05-07.
>>
>> We have been having toolchains in the autobuilders with gcc
>> 9.x for a while, so the vast majority of the problems should have
>> already been solved.
>>
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> ---
>>  package/gcc/Config.in.host | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied to master, thanks.
> 
> Following this, we should drop gcc 7.x support. However, one defconfig
> (roseapplepi) still uses gcc 7.x. I've notified Peter Korsgaard on IRC,
> and I am doing it here as well: if this defconfig is not updated to a
> newer kernel that builds with gcc >= 8.x, we will have to drop support
> for this defconfig.

Yes, I would like to avoid the mess like for beagleboneblack defconfig for qt5
when it was using gcc 5 only.

Best regards,
Romain


> 
> Thomas
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 5/5] package/gcc: switch to gcc 9.x as the default
  2020-06-24 19:56   ` Thomas Petazzoni
  2020-06-24 20:41     ` Romain Naour
@ 2020-07-07 13:13     ` Peter Korsgaard
  2020-08-29 12:13     ` Peter Korsgaard
  2 siblings, 0 replies; 14+ messages in thread
From: Peter Korsgaard @ 2020-07-07 13:13 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Tue,  9 Jun 2020 00:13:47 +0200
 > Romain Naour <romain.naour@gmail.com> wrote:

 >> Even if gcc 8 is still maintained for some time (gcc 8.5 is pending),
 >> switch to gcc 9.x since it has been released since 2019-05-03 and
 >> gcc 10.x is available since 2020-05-07.
 >> 
 >> We have been having toolchains in the autobuilders with gcc
 >> 9.x for a while, so the vast majority of the problems should have
 >> already been solved.
 >> 
 >> Signed-off-by: Romain Naour <romain.naour@gmail.com>
 >> ---
 >> package/gcc/Config.in.host | 2 +-
 >> 1 file changed, 1 insertion(+), 1 deletion(-)

 > Applied to master, thanks.

 > Following this, we should drop gcc 7.x support. However, one defconfig
 > (roseapplepi) still uses gcc 7.x. I've notified Peter Korsgaard on IRC,
 > and I am doing it here as well: if this defconfig is not updated to a
 > newer kernel that builds with gcc >= 8.x, we will have to drop support
 > for this defconfig.

I'll take a look at updating it next weekend, otherwise we can just drop
it.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH 5/5] package/gcc: switch to gcc 9.x as the default
  2020-06-24 19:56   ` Thomas Petazzoni
  2020-06-24 20:41     ` Romain Naour
  2020-07-07 13:13     ` Peter Korsgaard
@ 2020-08-29 12:13     ` Peter Korsgaard
  2 siblings, 0 replies; 14+ messages in thread
From: Peter Korsgaard @ 2020-08-29 12:13 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Tue,  9 Jun 2020 00:13:47 +0200
 > Romain Naour <romain.naour@gmail.com> wrote:

 >> Even if gcc 8 is still maintained for some time (gcc 8.5 is pending),
 >> switch to gcc 9.x since it has been released since 2019-05-03 and
 >> gcc 10.x is available since 2020-05-07.
 >> 
 >> We have been having toolchains in the autobuilders with gcc
 >> 9.x for a while, so the vast majority of the problems should have
 >> already been solved.
 >> 
 >> Signed-off-by: Romain Naour <romain.naour@gmail.com>
 >> ---
 >> package/gcc/Config.in.host | 2 +-
 >> 1 file changed, 1 insertion(+), 1 deletion(-)

 > Applied to master, thanks.

 > Following this, we should drop gcc 7.x support. However, one defconfig
 > (roseapplepi) still uses gcc 7.x. I've notified Peter Korsgaard on IRC,
 > and I am doing it here as well: if this defconfig is not updated to a
 > newer kernel that builds with gcc >= 8.x, we will have to drop support
 > for this defconfig.

This has now been done (in next), so we can drop gcc 7.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2020-08-29 12:13 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-08 22:13 [Buildroot] [PATCH 1/5] toolchain: add gcc 10 entry Romain Naour
2020-06-08 22:13 ` [Buildroot] [PATCH 2/5] package/gcc: add support for gcc 10 Romain Naour
2020-06-24 19:55   ` Thomas Petazzoni
2020-06-24 20:38     ` Romain Naour
2020-06-08 22:13 ` [Buildroot] [PATCH 3/5] arch: add BR2_ARCH_NEEDS_GCC_AT_LEAST_10 Romain Naour
2020-06-24 19:55   ` Thomas Petazzoni
2020-06-08 22:13 ` [Buildroot] [PATCH 4/5] toolchain-external: add gcc 10 entry Romain Naour
2020-06-24 19:55   ` Thomas Petazzoni
2020-06-08 22:13 ` [Buildroot] [PATCH 5/5] package/gcc: switch to gcc 9.x as the default Romain Naour
2020-06-24 19:56   ` Thomas Petazzoni
2020-06-24 20:41     ` Romain Naour
2020-07-07 13:13     ` Peter Korsgaard
2020-08-29 12:13     ` Peter Korsgaard
2020-06-24 19:53 ` [Buildroot] [PATCH 1/5] toolchain: add gcc 10 entry Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox