* [Buildroot] [PATCH] package/urandom-scripts: new package
2020-07-20 15:20 [Buildroot] [PATCH] package/urandom-scripts: new package christoph.muellner at theobroma-systems.com
@ 2020-07-20 21:14 ` Yann E. MORIN
0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2020-07-20 21:14 UTC (permalink / raw)
To: buildroot
Christoph, All,
On 2020-07-20 17:20 +0200, christoph.muellner at theobroma-systems.com spake thusly:
> From: Christoph M?llner <christoph.muellner@theobroma-systems.com>
>
> The init script S20urandom is used to preserve the kernel's RNG
> seed between reboots. This functionality is not required for the
> package "initscripts". Further there are use-cases where this script
> should not be installed at all (e.g. systems that only have read-only
> partitions), but that's currently not possible as the script is
> a mandatory part of the package "initscripts".
>
> Let's move the script into its own package "urandom-scripts" and select it,
> if the default skeleton is enabled. This maintains backward-compatibility
> and allows to deselect it.
>
> Signed-off-by: Christoph M?llner <christoph.muellner@theobroma-systems.com>
Applied to master, with a few changes, see below...
> ---
> package/Config.in | 1 +
> package/urandom-scripts/Config.in | 6 ++++++
> .../init.d => urandom-scripts}/S20urandom | 0
> package/urandom-scripts/urandom-scripts.mk | 12 ++++++++++++
> 4 files changed, 19 insertions(+)
> create mode 100644 package/urandom-scripts/Config.in
> rename package/{initscripts/init.d => urandom-scripts}/S20urandom (100%)
> create mode 100644 package/urandom-scripts/urandom-scripts.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 22531d4fb5..89bcafc398 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -2290,6 +2290,7 @@ menu "Security"
> source "package/selinux-python/Config.in"
> source "package/semodule-utils/Config.in"
> source "package/setools/Config.in"
> + source "package/urandom-scripts/Config.in"
> endmenu
>
> menu "Shell and utilities"
> diff --git a/package/urandom-scripts/Config.in b/package/urandom-scripts/Config.in
> new file mode 100644
> index 0000000000..5451206bd2
> --- /dev/null
> +++ b/package/urandom-scripts/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_URANDOM_SCRIPTS
> + bool "urandom-initscripts"
> + default y if BR2_ROOTFS_SKELETON_DEFAULT
> + depends on BR2_PACKAGE_INITSCRIPTS
I see that you miodelled your package after ifupdown-scripts, which is
good (I like being copied, thanks!).
However, I think the best chnage was to keep the existign behaviour: it
default to 'y' when initscripts is enabled, as it previously came from
initscripts.
Furthermore, sysV init scripts can be used when openRC is the init
system, and custom (none) init system could make use of them too. So I
made it unavailable only for systemd.
> + help
> + Initscript to preserve the random seed between reboots.
I extended the help text to state that this is a poor solution overall,
and that better alternative exist.
Applied to master, thanks!
Regards,
Yann E. MORIN.
> diff --git a/package/initscripts/init.d/S20urandom b/package/urandom-scripts/S20urandom
> similarity index 100%
> rename from package/initscripts/init.d/S20urandom
> rename to package/urandom-scripts/S20urandom
> diff --git a/package/urandom-scripts/urandom-scripts.mk b/package/urandom-scripts/urandom-scripts.mk
> new file mode 100644
> index 0000000000..2c09728c46
> --- /dev/null
> +++ b/package/urandom-scripts/urandom-scripts.mk
> @@ -0,0 +1,12 @@
> +################################################################################
> +#
> +# urandom-scripts
> +#
> +################################################################################
> +
> +define URANDOM_SCRIPTS_INSTALL_INIT_SYSV
> + $(INSTALL) -D -m 0755 $(URANDOM_SCRIPTS_PKGDIR)/S20urandom \
> + $(TARGET_DIR)/etc/init.d/S20urandom
> +endef
> +
> +$(eval $(generic-package))
> --
> 2.26.2
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 2+ messages in thread