[Buildroot] [PATCH 1/2] package/gettext-tiny.hash: remove hash value for gettext-gnu

[Buildroot] [PATCH 1/2] package/gettext-tiny.hash: remove hash value for gettext-gnu

[Heiko Thiery]

The gettext-tiny hash file holds a value that belongs to the gettext-gnu.

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
 package/gettext-tiny/gettext-tiny.hash | 2 --
 1 file changed, 2 deletions(-)

diff --git a/package/gettext-tiny/gettext-tiny.hash b/package/gettext-tiny/gettext-tiny.hash
index 201b05c6ff..585a2bdcc3 100644
--- a/package/gettext-tiny/gettext-tiny.hash
+++ b/package/gettext-tiny/gettext-tiny.hash
@@ -2,5 +2,3 @@
 sha256 efc740007c82a9b3a0d382fb50d212fa7dc0beddb9695409ee79684f9f2124b2  gettext-tiny-adaa9c64921e80f2b8dd3610ffb508618b9204f3.tar.gz
 sha256 b57aa4fdc1c614c28d41c1e2d5c4090935964c5f86291ba7d1c99ffd1d698b34  LICENSE
 sha256 e79e9c8a0c85d735ff98185918ec94ed7d175efc377012787aebcf3b80f0d90b  extra/COPYING
-# From https://lists.gnu.org/archive/html/info-gnu/2019-05/msg00011.html
-sha1 62f4a6a2fd5f80bfd0e66c497a04094fa3e07b90 gettext-0.20.1.tar.xz
-- 
2.20.1

[Buildroot] [PATCH 2/2] package/gettext-tiny: bump to version 0.3.2

[Heiko Thiery]

- Adapt license hash
  (minor additions in LICENSE file about files in doc folder:
  "Files contained in the doc/ directory may be licensed under different terms.",
  but there are no folder present so no license change)
- Also separate the fields in the hash file by two spaces

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
 package/gettext-tiny/gettext-tiny.hash | 6 +++---
 package/gettext-tiny/gettext-tiny.mk   | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/package/gettext-tiny/gettext-tiny.hash b/package/gettext-tiny/gettext-tiny.hash
index 585a2bdcc3..c59b3b50a2 100644
--- a/package/gettext-tiny/gettext-tiny.hash
+++ b/package/gettext-tiny/gettext-tiny.hash
@@ -1,4 +1,4 @@
 # Locally Computed:
-sha256 efc740007c82a9b3a0d382fb50d212fa7dc0beddb9695409ee79684f9f2124b2  gettext-tiny-adaa9c64921e80f2b8dd3610ffb508618b9204f3.tar.gz
-sha256 b57aa4fdc1c614c28d41c1e2d5c4090935964c5f86291ba7d1c99ffd1d698b34  LICENSE
-sha256 e79e9c8a0c85d735ff98185918ec94ed7d175efc377012787aebcf3b80f0d90b  extra/COPYING
+sha256  29cc165e27e83d2bb3760118c2368eadab550830d962d758e51bd36eb860f383  gettext-tiny-0.3.2.tar.gz
+sha256  4c938aa3d8fa3c184bba5e87a8a2febc89560627c9d0567536879e3eca1a7b4f  LICENSE
+sha256  e79e9c8a0c85d735ff98185918ec94ed7d175efc377012787aebcf3b80f0d90b  extra/COPYING
diff --git a/package/gettext-tiny/gettext-tiny.mk b/package/gettext-tiny/gettext-tiny.mk
index 87813ae5af..c297cb1fe5 100644
--- a/package/gettext-tiny/gettext-tiny.mk
+++ b/package/gettext-tiny/gettext-tiny.mk
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-GETTEXT_TINY_VERSION = adaa9c64921e80f2b8dd3610ffb508618b9204f3
-GETTEXT_TINY_SITE = $(call github,sabotage-linux,gettext-tiny,$(GETTEXT_TINY_VERSION))
+GETTEXT_TINY_VERSION = 0.3.2
+GETTEXT_TINY_SITE = $(call github,sabotage-linux,gettext-tiny,v$(GETTEXT_TINY_VERSION))
 GETTEXT_TINY_LICENSE = MIT, GPL-3.0+ (extra gettext)
 GETTEXT_TINY_INSTALL_STAGING = YES
 GETTEXT_TINY_LICENSE_FILES = LICENSE
-- 
2.20.1

[Buildroot] [PATCH 1/2] package/gettext-tiny.hash: remove hash value for gettext-gnu

[Thomas Petazzoni]

On Wed, 22 Jul 2020 16:53:48 +0200
Heiko Thiery <heiko.thiery@gmail.com> wrote:

> The gettext-tiny hash file holds a value that belongs to the gettext-gnu.
> 
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>

No, it does belong to gettext-tiny as well: gettext-tiny downloads
gettext-gnu:

HOST_GETTEXT_TINY_EXTRA_DOWNLOADS = $(GETTEXT_GNU_SITE)/$(GETTEXT_GNU_SOURCE)

I don't think gettext-tiny can build after you apply this change, it
should complain that one file that it downloads does not have a hash.
Are you sure you tested this ? If you did, then we have a bug in
Buildroot :-)

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/2] package/gettext-tiny.hash: remove hash value for gettext-gnu

[Thomas Petazzoni]

On Thu, 23 Jul 2020 16:21:42 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> I don't think gettext-tiny can build after you apply this change, it
> should complain that one file that it downloads does not have a hash.
> Are you sure you tested this ? If you did, then we have a bug in
> Buildroot :-)

There's no bug in Buildroot, it really fails:

ERROR: No hash found for gettext-0.20.1.tar.xz
make: *** [package/pkg-generic.mk:171: /home/thomas/projets/buildroot/output/build/host-gettext-tiny-0.3.2/.stamp_downloaded] Error 1

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 2/2] package/gettext-tiny: bump to version 0.3.2

[Thomas Petazzoni]

On Wed, 22 Jul 2020 16:53:50 +0200
Heiko Thiery <heiko.thiery@gmail.com> wrote:

> - Adapt license hash
>   (minor additions in LICENSE file about files in doc folder:
>   "Files contained in the doc/ directory may be licensed under different terms.",
>   but there are no folder present so no license change)
> - Also separate the fields in the hash file by two spaces
> 
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
>  package/gettext-tiny/gettext-tiny.hash | 6 +++---
>  package/gettext-tiny/gettext-tiny.mk   | 4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/2] package/gettext-tiny.hash: remove hash value for gettext-gnu

[Heiko Thiery]

Hi Thomas,

Am Do., 23. Juli 2020 um 16:25 Uhr schrieb Thomas Petazzoni
<thomas.petazzoni@bootlin.com>:
>
> On Thu, 23 Jul 2020 16:21:42 +0200
> Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
>
> > I don't think gettext-tiny can build after you apply this change, it
> > should complain that one file that it downloads does not have a hash.
> > Are you sure you tested this ? If you did, then we have a bug in
> > Buildroot :-)

Sorry for that .. indeed I did not check that it builds. I faced this
after doing the bump and the check ;-/

>
> There's no bug in Buildroot, it really fails:
>
> ERROR: No hash found for gettext-0.20.1.tar.xz
> make: *** [package/pkg-generic.mk:171: /home/thomas/projets/buildroot/output/build/host-gettext-tiny-0.3.2/.stamp_downloaded] Error 1
>
> Thomas

-- 
Heko