Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 0/5] libwebsockets fixup
@ 2020-07-26  2:28 aduskett at gmail.com
  2020-07-26  2:28 ` [Buildroot] [PATCH 1/5] package/libwebsockets: remove dependency on mmu aduskett at gmail.com
                   ` (5 more replies)
  0 siblings, 6 replies; 10+ messages in thread
From: aduskett at gmail.com @ 2020-07-26  2:28 UTC (permalink / raw)
  To: buildroot

From: Adam Duskett <Aduskett@gmail.com>

As I was picking through the packages under my name in the developers' file, I
checked libwebsockets and found that it was quite out of date!

I started to dig around and found two issues I wanted to fix before updating
libwebsockets:

1) libwebsockets compiles just fine without fork() and has had vfork()
   support for at * least * 5 years (I couldn't find anything further back,
   but it might have been there even longer.)

2) zlib hasn't been a requirement since 2013 and is only necessary if
   LWS_WITHOUT_EXTENSIONS is "ON," which is the default behavior.

As such, the first two patches deal directly with those issues.
The first removes "depends on BR2_USE_MMU," the second explicitly sets
LWS_WITHOUT_EXTENSIONS to "OFF." (See the patch for more details and size
comparisons.)

The 4.0 series of libwebsockets also has several new features and options
which we may want to enable in a separate patch series, but for this patch
series, I just wanted to include a check for libglib2 and libmount.

The other options we may want to enable in the future are:
 - LWS_ROLE_MQTT
 - LWS_WITH_SYS_ASYNC_DNS
 - LWS_WITH_SYS_NTPCLIENT
 - LWS_WITH_SYS_DHCP_CLIENT
 - LWS_WITH_SECURE_STREAMS
 - LWS_WITH_STRUCT_JSON
 - LWS_WITH_SPAWN
 - LWS_WITH_SQLITE3/LWS_WITH_STRUCT_SQLITE3

Feel free to check out the CMakeLists.txt and the changelog file to see what
those options do, some of them are quite neat! If we do decide to impliment
those options, a Config.in entry would be needed for all of them except
for SQLITE.

Also, mbedtls and wolfssl are supported and have been for quite a while, but
nobody cares about adding support for those libraries. I sure as heck don't!

I tested the changes on Fedora 32 and CentOS7 with
"./utils/test-pkg -c ./defconfig -p libwebsockets" and got
"6 builds, 0 skipped, 0 build failed, 0 legal-info failed" as a result.

Thanks for taking a look at the series!

Adam Duskett (5):
  package/libwebsockets: remove dependency on mmu
  package/libwebsockets: add support for extensions
  package/libwebsockets: bump version to 4.0.20
  package/libwebsockets: add libglib2 support
  package/libwebsockets: add fsmount support

 ...ts-txt-fix-static-build-with-openssl.patch | 34 -------------------
 package/libwebsockets/Config.in               |  1 -
 package/libwebsockets/libwebsockets.hash      |  4 +--
 package/libwebsockets/libwebsockets.mk        | 21 ++++++++++--
 4 files changed, 20 insertions(+), 40 deletions(-)
 delete mode 100644 package/libwebsockets/0001-CMakeLists-txt-fix-static-build-with-openssl.patch

-- 
2.26.2

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-08-13  9:40 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-26  2:28 [Buildroot] [PATCH 0/5] libwebsockets fixup aduskett at gmail.com
2020-07-26  2:28 ` [Buildroot] [PATCH 1/5] package/libwebsockets: remove dependency on mmu aduskett at gmail.com
2020-07-26  7:11   ` Thomas Petazzoni
2020-08-13  9:40   ` Peter Korsgaard
2020-07-26  2:28 ` [Buildroot] [PATCH 2/5] package/libwebsockets: add support for extensions aduskett at gmail.com
2020-07-26  2:28 ` [Buildroot] [PATCH 3/5] package/libwebsockets: bump version to 4.0.20 aduskett at gmail.com
2020-07-27  7:21   ` Yann E. MORIN
2020-07-26  2:29 ` [Buildroot] [PATCH 4/5] package/libwebsockets: add libglib2 support aduskett at gmail.com
2020-07-26  2:29 ` [Buildroot] [PATCH 5/5] package/libwebsockets: add fsmount support aduskett at gmail.com
2020-07-27  7:07 ` [Buildroot] [PATCH 0/5] libwebsockets fixup Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox