* [Buildroot] [PATCH 1/1] package/iputils: drop wrong linux-headers dependency
@ 2020-08-11 22:37 Fabrice Fontaine
2020-08-12 4:01 ` Petr Vorel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2020-08-11 22:37 UTC (permalink / raw)
To: buildroot
Commit 9ffcd9279e5505535a73cf1200b3a86fd425cf32 wrongly added a
linux-headers dependency when switching to meson.
Remove it as headers are always provided by the toolchain.
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/iputils/iputils.mk | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/package/iputils/iputils.mk b/package/iputils/iputils.mk
index 0d260891e2..d09bc58b34 100644
--- a/package/iputils/iputils.mk
+++ b/package/iputils/iputils.mk
@@ -40,13 +40,8 @@ IPUTILS_DEPENDENCIES += libgcrypt
else ifeq ($(BR2_PACKAGE_OPENSSL),y)
IPUTILS_CONF_OPTS += -DUSE_CRYPTO=openssl
IPUTILS_DEPENDENCIES += openssl
-else ifeq ($(BR2_PACKAGE_LINUX_HEADERS),y)
-IPUTILS_CONF_OPTS += -DUSE_CRYPTO=kernel
-IPUTILS_DEPENDENCIES += linux-headers
else
-IPUTILS_CONF_OPTS += -DUSE_CRYPTO=none
-# BUILD_NINFOD=true and USE_CRYPTO=none cannot be combined
-IPUTILS_NINFOD = n
+IPUTILS_CONF_OPTS += -DUSE_CRYPTO=kernel
endif
ifeq ($(BR2_PACKAGE_SYSTEMD),y)
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Buildroot] [PATCH 1/1] package/iputils: drop wrong linux-headers dependency
2020-08-11 22:37 [Buildroot] [PATCH 1/1] package/iputils: drop wrong linux-headers dependency Fabrice Fontaine
@ 2020-08-12 4:01 ` Petr Vorel
2020-08-12 14:47 ` Thomas Petazzoni
2020-08-28 15:58 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2020-08-12 4:01 UTC (permalink / raw)
To: buildroot
Hi Fabrice,
> Commit 9ffcd9279e5505535a73cf1200b3a86fd425cf32 wrongly added a
> linux-headers dependency when switching to meson.
> Remove it as headers are always provided by the toolchain.
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Thanks!
Acked-by: Petr Vorel <petr.vorel@gmail.com>
BTW next release (which should be soon) will not depend on any crypto library
(md5 implementation is included).
Kind regards,
Petr
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/iputils: drop wrong linux-headers dependency
2020-08-11 22:37 [Buildroot] [PATCH 1/1] package/iputils: drop wrong linux-headers dependency Fabrice Fontaine
2020-08-12 4:01 ` Petr Vorel
@ 2020-08-12 14:47 ` Thomas Petazzoni
2020-08-28 15:58 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2020-08-12 14:47 UTC (permalink / raw)
To: buildroot
On Wed, 12 Aug 2020 00:37:40 +0200
Fabrice Fontaine via buildroot <buildroot@busybox.net> wrote:
> Commit 9ffcd9279e5505535a73cf1200b3a86fd425cf32 wrongly added a
> linux-headers dependency when switching to meson.
>
> Remove it as headers are always provided by the toolchain.
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/iputils/iputils.mk | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/iputils: drop wrong linux-headers dependency
2020-08-11 22:37 [Buildroot] [PATCH 1/1] package/iputils: drop wrong linux-headers dependency Fabrice Fontaine
2020-08-12 4:01 ` Petr Vorel
2020-08-12 14:47 ` Thomas Petazzoni
@ 2020-08-28 15:58 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2020-08-28 15:58 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine via buildroot <buildroot@busybox.net> writes:
> Commit 9ffcd9279e5505535a73cf1200b3a86fd425cf32 wrongly added a
> linux-headers dependency when switching to meson.
> Remove it as headers are always provided by the toolchain.
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2020.02.x and 2020.05.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-28 15:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-11 22:37 [Buildroot] [PATCH 1/1] package/iputils: drop wrong linux-headers dependency Fabrice Fontaine
2020-08-12 4:01 ` Petr Vorel
2020-08-12 14:47 ` Thomas Petazzoni
2020-08-28 15:58 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox