* [Buildroot] [PATCH] libbacktrace: new package @ 2020-08-13 20:11 Avi Shukron 2020-08-13 20:45 ` Yann E. MORIN 0 siblings, 1 reply; 5+ messages in thread From: Avi Shukron @ 2020-08-13 20:11 UTC (permalink / raw) To: buildroot libbacktrace is a C library that may be linked into a C/C++ program to produce symbolic backtraces. Signed-off-by: Avi Shukron <avraham.shukron@gmail.com> --- package/Config.in | 1 + package/libbacktrace/Config.in | 7 +++++++ package/libbacktrace/libbacktrace.hash | 3 +++ package/libbacktrace/libbacktrace.mk | 16 ++++++++++++++++ 4 files changed, 27 insertions(+) create mode 100644 package/libbacktrace/Config.in create mode 100644 package/libbacktrace/libbacktrace.hash create mode 100644 package/libbacktrace/libbacktrace.mk diff --git a/package/Config.in b/package/Config.in index d7e79f4795..cf65919091 100644 --- a/package/Config.in +++ b/package/Config.in @@ -179,6 +179,7 @@ menu "Development tools" source "package/subversion/Config.in" source "package/tree/Config.in" source "package/yasm/Config.in" + source "package/libbacktrace/Config.in" endmenu menu "Filesystem and flash utilities" diff --git a/package/libbacktrace/Config.in b/package/libbacktrace/Config.in new file mode 100644 index 0000000000..0f940dd588 --- /dev/null +++ b/package/libbacktrace/Config.in @@ -0,0 +1,7 @@ +config BR2_PACKAGE_LIBBACKTRACE + bool "libbacktrace" + help + A C library that may be linked into a C/C++ program to + produce symbolic backtraces + + https://github.com/ianlancetaylor/libbacktrace diff --git a/package/libbacktrace/libbacktrace.hash b/package/libbacktrace/libbacktrace.hash new file mode 100644 index 0000000000..9c73990677 --- /dev/null +++ b/package/libbacktrace/libbacktrace.hash @@ -0,0 +1,3 @@ +# Locally computed: +sha256 ef8a9b3247488f8901ca60de9b17b745d7bd67e5ec1e622f80d62364572200d8 LICENSE +sha256 13072c499c76866c188beaf3d50f3dddbf2c27ed9fd72b33d1b857acd33b1cb5 9b7f216e867916594d81e8b6118f092ac3fcf704.tar.gz diff --git a/package/libbacktrace/libbacktrace.mk b/package/libbacktrace/libbacktrace.mk new file mode 100644 index 0000000000..4179295cea --- /dev/null +++ b/package/libbacktrace/libbacktrace.mk @@ -0,0 +1,16 @@ +################################################################################ +# +# libbacktrace +# +################################################################################ + +LIBBACKTRACE_VERSION = 9b7f216e867916594d81e8b6118f092ac3fcf704 +LIBBACKTRACE_SITE = https://github.com/ianlancetaylor/libbacktrace/archive +LIBBACKTRACE_SOURCE = $(LIBBACKTRACE_VERSION).tar.gz + +LIBBACKTRACE_LICENSE = BSD +LIBBACKTRACE_LICENSE_FILES = LICENSE + +LIBBACKTRACE_INSTALL_STAGING = YES + +$(eval $(autotools-package)) -- 2.25.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] libbacktrace: new package 2020-08-13 20:11 [Buildroot] [PATCH] libbacktrace: new package Avi Shukron @ 2020-08-13 20:45 ` Yann E. MORIN 2020-08-14 22:34 ` [Buildroot] [PATCH v2] " Avi Shukron 0 siblings, 1 reply; 5+ messages in thread From: Yann E. MORIN @ 2020-08-13 20:45 UTC (permalink / raw) To: buildroot Avi, All, On 2020-08-13 23:11 +0300, Avi Shukron spake thusly: > libbacktrace is a C library that may be linked into a C/C++ program to > produce symbolic backtraces. Thanks for this patch. See below for some comments. > Signed-off-by: Avi Shukron <avraham.shukron@gmail.com> > --- > package/Config.in | 1 + > package/libbacktrace/Config.in | 7 +++++++ > package/libbacktrace/libbacktrace.hash | 3 +++ > package/libbacktrace/libbacktrace.mk | 16 ++++++++++++++++ > 4 files changed, 27 insertions(+) > create mode 100644 package/libbacktrace/Config.in > create mode 100644 package/libbacktrace/libbacktrace.hash > create mode 100644 package/libbacktrace/libbacktrace.mk > > diff --git a/package/Config.in b/package/Config.in > index d7e79f4795..cf65919091 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -179,6 +179,7 @@ menu "Development tools" > source "package/subversion/Config.in" > source "package/tree/Config.in" > source "package/yasm/Config.in" > + source "package/libbacktrace/Config.in" Keep alphabetical ordering. This can be verified with: $ make check-package package/Config.in:182: Packages in: menu "Development tools", are not alphabetically ordered; correct order: '-', '_', digits, capitals, lowercase; first incorrect package: libbacktrace [--SNIP--] > diff --git a/package/libbacktrace/libbacktrace.hash b/package/libbacktrace/libbacktrace.hash > new file mode 100644 > index 0000000000..9c73990677 > --- /dev/null > +++ b/package/libbacktrace/libbacktrace.hash > @@ -0,0 +1,3 @@ > +# Locally computed: > +sha256 ef8a9b3247488f8901ca60de9b17b745d7bd67e5ec1e622f80d62364572200d8 LICENSE > +sha256 13072c499c76866c188beaf3d50f3dddbf2c27ed9fd72b33d1b857acd33b1cb5 9b7f216e867916594d81e8b6118f092ac3fcf704.tar.gz It is customary that we put the licenses after the source archives. > diff --git a/package/libbacktrace/libbacktrace.mk b/package/libbacktrace/libbacktrace.mk > new file mode 100644 > index 0000000000..4179295cea > --- /dev/null > +++ b/package/libbacktrace/libbacktrace.mk > @@ -0,0 +1,16 @@ > +################################################################################ > +# > +# libbacktrace > +# > +################################################################################ > + > +LIBBACKTRACE_VERSION = 9b7f216e867916594d81e8b6118f092ac3fcf704 > +LIBBACKTRACE_SITE = https://github.com/ianlancetaylor/libbacktrace/archive > +LIBBACKTRACE_SOURCE = $(LIBBACKTRACE_VERSION).tar.gz You should use the github helper macro, as this provides a better named archive, and thus you do not need to set the _SOURCE variable either: LIBBACTRACE_SITE = $(call github,ianlancetaylor,libbacktrace,$(LIBBACKTRACE_VERSION)) > +LIBBACKTRACE_LICENSE = BSD There are a lot of "BSD" license, so we want to have the exact one. The closest would be BSD-3C, but the wording of the third bullet point is slightly different, so it is not exactly BSD-3C. I think we can list it as: LIBBACKTRACE_LICENSE = BSD-3C-like Care to fix those and respin, please? Regards, Yann E. MORIN. > +LIBBACKTRACE_LICENSE_FILES = LICENSE > + > +LIBBACKTRACE_INSTALL_STAGING = YES > + > +$(eval $(autotools-package)) > -- > 2.25.1 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2] libbacktrace: new package 2020-08-13 20:45 ` Yann E. MORIN @ 2020-08-14 22:34 ` Avi Shukron 2020-08-15 5:12 ` Asaf Kahlon 0 siblings, 1 reply; 5+ messages in thread From: Avi Shukron @ 2020-08-14 22:34 UTC (permalink / raw) To: buildroot A C library that may be linked into a C/C++ program to produce symbolic backtraces. Signed-off-by: Avi Shukron <avraham.shukron@gmail.com> --- package/Config.in | 1 + package/libbacktrace/Config.in | 7 +++++++ package/libbacktrace/libbacktrace.hash | 3 +++ package/libbacktrace/libbacktrace.mk | 15 +++++++++++++++ 4 files changed, 26 insertions(+) create mode 100644 package/libbacktrace/Config.in create mode 100644 package/libbacktrace/libbacktrace.hash create mode 100644 package/libbacktrace/libbacktrace.mk diff --git a/package/Config.in b/package/Config.in index d7e79f4795..7460d3f006 100644 --- a/package/Config.in +++ b/package/Config.in @@ -170,6 +170,7 @@ menu "Development tools" source "package/grep/Config.in" source "package/jo/Config.in" source "package/jq/Config.in" + source "package/libbacktrace/Config.in" source "package/libtool/Config.in" source "package/make/Config.in" source "package/patch/Config.in" diff --git a/package/libbacktrace/Config.in b/package/libbacktrace/Config.in new file mode 100644 index 0000000000..0f940dd588 --- /dev/null +++ b/package/libbacktrace/Config.in @@ -0,0 +1,7 @@ +config BR2_PACKAGE_LIBBACKTRACE + bool "libbacktrace" + help + A C library that may be linked into a C/C++ program to + produce symbolic backtraces + + https://github.com/ianlancetaylor/libbacktrace diff --git a/package/libbacktrace/libbacktrace.hash b/package/libbacktrace/libbacktrace.hash new file mode 100644 index 0000000000..ecd530a33b --- /dev/null +++ b/package/libbacktrace/libbacktrace.hash @@ -0,0 +1,3 @@ +# Locally computed: +sha256 13072c499c76866c188beaf3d50f3dddbf2c27ed9fd72b33d1b857acd33b1cb5 libbacktrace-9b7f216e867916594d81e8b6118f092ac3fcf704.tar.gz +sha256 ef8a9b3247488f8901ca60de9b17b745d7bd67e5ec1e622f80d62364572200d8 LICENSE diff --git a/package/libbacktrace/libbacktrace.mk b/package/libbacktrace/libbacktrace.mk new file mode 100644 index 0000000000..fb1f6c058a --- /dev/null +++ b/package/libbacktrace/libbacktrace.mk @@ -0,0 +1,15 @@ +################################################################################ +# +# libbacktrace +# +################################################################################ + +LIBBACKTRACE_VERSION = 9b7f216e867916594d81e8b6118f092ac3fcf704 +LIBBACKTRACE_SITE = $(call github,ianlancetaylor,libbacktrace,$(LIBBACKTRACE_VERSION)) + +LIBBACKTRACE_LICENSE = BSD-3C-like +LIBBACKTRACE_LICENSE_FILES = LICENSE + +LIBBACKTRACE_INSTALL_STAGING = YES + +$(eval $(autotools-package)) -- 2.25.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2] libbacktrace: new package 2020-08-14 22:34 ` [Buildroot] [PATCH v2] " Avi Shukron @ 2020-08-15 5:12 ` Asaf Kahlon 2020-08-15 8:59 ` Avraham Shukron 0 siblings, 1 reply; 5+ messages in thread From: Asaf Kahlon @ 2020-08-15 5:12 UTC (permalink / raw) To: buildroot Hello, On Sat, Aug 15, 2020 at 1:35 AM Avi Shukron <avraham.shukron@gmail.com> wrote: > > A C library that may be linked into a C/C++ program to produce > symbolic backtraces. > > Signed-off-by: Avi Shukron <avraham.shukron@gmail.com> > --- > package/Config.in | 1 + > package/libbacktrace/Config.in | 7 +++++++ > package/libbacktrace/libbacktrace.hash | 3 +++ > package/libbacktrace/libbacktrace.mk | 15 +++++++++++++++ > 4 files changed, 26 insertions(+) > create mode 100644 package/libbacktrace/Config.in > create mode 100644 package/libbacktrace/libbacktrace.hash > create mode 100644 package/libbacktrace/libbacktrace.mk > > diff --git a/package/Config.in b/package/Config.in > index d7e79f4795..7460d3f006 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -170,6 +170,7 @@ menu "Development tools" > source "package/grep/Config.in" > source "package/jo/Config.in" > source "package/jq/Config.in" > + source "package/libbacktrace/Config.in" Comparing to other packages in the "development tools" menu, I don't think this is the correct place for libbacktrace. In my opinion, it should be placed on one of the submenus under "libraries". > source "package/libtool/Config.in" > source "package/make/Config.in" > source "package/patch/Config.in" > diff --git a/package/libbacktrace/Config.in b/package/libbacktrace/Config.in > new file mode 100644 > index 0000000000..0f940dd588 > --- /dev/null > +++ b/package/libbacktrace/Config.in > @@ -0,0 +1,7 @@ > +config BR2_PACKAGE_LIBBACKTRACE > + bool "libbacktrace" > + help > + A C library that may be linked into a C/C++ program to > + produce symbolic backtraces > + > + https://github.com/ianlancetaylor/libbacktrace > diff --git a/package/libbacktrace/libbacktrace.hash b/package/libbacktrace/libbacktrace.hash > new file mode 100644 > index 0000000000..ecd530a33b > --- /dev/null > +++ b/package/libbacktrace/libbacktrace.hash > @@ -0,0 +1,3 @@ > +# Locally computed: > +sha256 13072c499c76866c188beaf3d50f3dddbf2c27ed9fd72b33d1b857acd33b1cb5 libbacktrace-9b7f216e867916594d81e8b6118f092ac3fcf704.tar.gz > +sha256 ef8a9b3247488f8901ca60de9b17b745d7bd67e5ec1e622f80d62364572200d8 LICENSE > diff --git a/package/libbacktrace/libbacktrace.mk b/package/libbacktrace/libbacktrace.mk > new file mode 100644 > index 0000000000..fb1f6c058a > --- /dev/null > +++ b/package/libbacktrace/libbacktrace.mk > @@ -0,0 +1,15 @@ > +################################################################################ > +# > +# libbacktrace > +# > +################################################################################ > + > +LIBBACKTRACE_VERSION = 9b7f216e867916594d81e8b6118f092ac3fcf704 > +LIBBACKTRACE_SITE = $(call github,ianlancetaylor,libbacktrace,$(LIBBACKTRACE_VERSION)) > + > +LIBBACKTRACE_LICENSE = BSD-3C-like > +LIBBACKTRACE_LICENSE_FILES = LICENSE > + > +LIBBACKTRACE_INSTALL_STAGING = YES > + > +$(eval $(autotools-package)) > -- > 2.25.1 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot Regards, Asaf. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2] libbacktrace: new package 2020-08-15 5:12 ` Asaf Kahlon @ 2020-08-15 8:59 ` Avraham Shukron 0 siblings, 0 replies; 5+ messages in thread From: Avraham Shukron @ 2020-08-15 8:59 UTC (permalink / raw) To: buildroot The only appropriate submenu under "Libraries" is alongside libunwind under "Other", which is kinda saying "I don't know where else to put it". Anyway - I don't think it is important too much as long as it is searchable in a place that makes sense. I'll send v3 soon. On Sat, Aug 15, 2020 at 8:12 AM Asaf Kahlon <asafka7@gmail.com> wrote: > Hello, > > On Sat, Aug 15, 2020 at 1:35 AM Avi Shukron <avraham.shukron@gmail.com> > wrote: > > > > A C library that may be linked into a C/C++ program to produce > > symbolic backtraces. > > > > Signed-off-by: Avi Shukron <avraham.shukron@gmail.com> > > --- > > package/Config.in | 1 + > > package/libbacktrace/Config.in | 7 +++++++ > > package/libbacktrace/libbacktrace.hash | 3 +++ > > package/libbacktrace/libbacktrace.mk | 15 +++++++++++++++ > > 4 files changed, 26 insertions(+) > > create mode 100644 package/libbacktrace/Config.in > > create mode 100644 package/libbacktrace/libbacktrace.hash > > create mode 100644 package/libbacktrace/libbacktrace.mk > > > > diff --git a/package/Config.in b/package/Config.in > > index d7e79f4795..7460d3f006 100644 > > --- a/package/Config.in > > +++ b/package/Config.in > > @@ -170,6 +170,7 @@ menu "Development tools" > > source "package/grep/Config.in" > > source "package/jo/Config.in" > > source "package/jq/Config.in" > > + source "package/libbacktrace/Config.in" > Comparing to other packages in the "development tools" menu, I don't > think this is the correct place for libbacktrace. > In my opinion, it should be placed on one of the submenus under > "libraries". > > > source "package/libtool/Config.in" > > source "package/make/Config.in" > > source "package/patch/Config.in" > > diff --git a/package/libbacktrace/Config.in > b/package/libbacktrace/Config.in > > new file mode 100644 > > index 0000000000..0f940dd588 > > --- /dev/null > > +++ b/package/libbacktrace/Config.in > > @@ -0,0 +1,7 @@ > > +config BR2_PACKAGE_LIBBACKTRACE > > + bool "libbacktrace" > > + help > > + A C library that may be linked into a C/C++ program to > > + produce symbolic backtraces > > + > > + https://github.com/ianlancetaylor/libbacktrace > > diff --git a/package/libbacktrace/libbacktrace.hash > b/package/libbacktrace/libbacktrace.hash > > new file mode 100644 > > index 0000000000..ecd530a33b > > --- /dev/null > > +++ b/package/libbacktrace/libbacktrace.hash > > @@ -0,0 +1,3 @@ > > +# Locally computed: > > +sha256 > 13072c499c76866c188beaf3d50f3dddbf2c27ed9fd72b33d1b857acd33b1cb5 > libbacktrace-9b7f216e867916594d81e8b6118f092ac3fcf704.tar.gz > > +sha256 > ef8a9b3247488f8901ca60de9b17b745d7bd67e5ec1e622f80d62364572200d8 LICENSE > > diff --git a/package/libbacktrace/libbacktrace.mk > b/package/libbacktrace/libbacktrace.mk > > new file mode 100644 > > index 0000000000..fb1f6c058a > > --- /dev/null > > +++ b/package/libbacktrace/libbacktrace.mk > > @@ -0,0 +1,15 @@ > > > +################################################################################ > > +# > > +# libbacktrace > > +# > > > +################################################################################ > > + > > +LIBBACKTRACE_VERSION = 9b7f216e867916594d81e8b6118f092ac3fcf704 > > +LIBBACKTRACE_SITE = $(call > github,ianlancetaylor,libbacktrace,$(LIBBACKTRACE_VERSION)) > > + > > +LIBBACKTRACE_LICENSE = BSD-3C-like > > +LIBBACKTRACE_LICENSE_FILES = LICENSE > > + > > +LIBBACKTRACE_INSTALL_STAGING = YES > > + > > +$(eval $(autotools-package)) > > -- > > 2.25.1 > > > > _______________________________________________ > > buildroot mailing list > > buildroot at busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > Regards, > Asaf. > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200815/ec0bb0e7/attachment.html> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-15 8:59 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-08-13 20:11 [Buildroot] [PATCH] libbacktrace: new package Avi Shukron 2020-08-13 20:45 ` Yann E. MORIN 2020-08-14 22:34 ` [Buildroot] [PATCH v2] " Avi Shukron 2020-08-15 5:12 ` Asaf Kahlon 2020-08-15 8:59 ` Avraham Shukron
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox