* [Buildroot] [PATCH 1/1] package/libcamera: disable werror
@ 2020-08-16 10:06 Fabrice Fontaine
2020-08-16 21:03 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Fabrice Fontaine @ 2020-08-16 10:06 UTC (permalink / raw)
To: buildroot
This will fix the following build failure:
../src/gstreamer/gstlibcameraallocator.cpp: In static member function 'static GQuark FrameWrap::getQuark()':
/home/peko/autobuild/instance-1/output-1/host/x86_64-buildroot-linux-gnu/sysroot/usr/include/glib-2.0/glib/gatomic.h:128:15: error: variable 'gapg_temp_atomic' set but not used [-Werror=unused-but-set-variable]
gpointer *gapg_temp_atomic = (gpointer *)(atomic); \
^
Fixes:
- http://autobuild.buildroot.org/results/c28500d4cc55fbd2bac87f2c11759ddc9163bc91
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libcamera/libcamera.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
index 9739f715a1..34911cee79 100644
--- a/package/libcamera/libcamera.mk
+++ b/package/libcamera/libcamera.mk
@@ -15,7 +15,8 @@ LIBCAMERA_DEPENDENCIES = \
LIBCAMERA_CONF_OPTS = \
-Dandroid=false \
-Ddocumentation=false \
- -Dtest=false
+ -Dtest=false \
+ -Dwerror=false
LIBCAMERA_INSTALL_STAGING = YES
LIBCAMERA_LICENSE = \
LGPL-2.1+ (library), \
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Buildroot] [PATCH 1/1] package/libcamera: disable werror 2020-08-16 10:06 [Buildroot] [PATCH 1/1] package/libcamera: disable werror Fabrice Fontaine @ 2020-08-16 21:03 ` Yann E. MORIN 2020-08-17 11:16 ` Kieran Bingham 0 siblings, 1 reply; 4+ messages in thread From: Yann E. MORIN @ 2020-08-16 21:03 UTC (permalink / raw) To: buildroot Fabrice, All, On 2020-08-16 12:06 +0200, Fabrice Fontaine spake thusly: > This will fix the following build failure: > > ../src/gstreamer/gstlibcameraallocator.cpp: In static member function 'static GQuark FrameWrap::getQuark()': > /home/peko/autobuild/instance-1/output-1/host/x86_64-buildroot-linux-gnu/sysroot/usr/include/glib-2.0/glib/gatomic.h:128:15: error: variable 'gapg_temp_atomic' set but not used [-Werror=unused-but-set-variable] > gpointer *gapg_temp_atomic = (gpointer *)(atomic); \ > ^ > > Fixes: > - http://autobuild.buildroot.org/results/c28500d4cc55fbd2bac87f2c11759ddc9163bc91 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Applied to master, thanks. Regards, Yann E. MORIN. > --- > package/libcamera/libcamera.mk | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk > index 9739f715a1..34911cee79 100644 > --- a/package/libcamera/libcamera.mk > +++ b/package/libcamera/libcamera.mk > @@ -15,7 +15,8 @@ LIBCAMERA_DEPENDENCIES = \ > LIBCAMERA_CONF_OPTS = \ > -Dandroid=false \ > -Ddocumentation=false \ > - -Dtest=false > + -Dtest=false \ > + -Dwerror=false > LIBCAMERA_INSTALL_STAGING = YES > LIBCAMERA_LICENSE = \ > LGPL-2.1+ (library), \ > -- > 2.27.0 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/libcamera: disable werror 2020-08-16 21:03 ` Yann E. MORIN @ 2020-08-17 11:16 ` Kieran Bingham 2020-08-17 11:39 ` Fabrice Fontaine 0 siblings, 1 reply; 4+ messages in thread From: Kieran Bingham @ 2020-08-17 11:16 UTC (permalink / raw) To: buildroot Hi Fabrice, Out of interest, have you investigated to see if this has been fixed or reported in upstream glib? This looks like an issue in the specific glib version rather than libcamera, so IMO disabling -Werror is just a workaround ... a viable one of course ... but not solving the underlying fault. Of course that is the peril of -Werror, we aim to keep warning free, but the dependencies are out of our control so if they fail to do the same, then that can cause these issues for packaging. Anyway the -Werror=false is only at the buildroot packaging, so we can still aim to be warning clear in libcamera of course ;-) Thanks for keeping libcamera building successfully on buildroot! -- Regards Kieran On 16/08/2020 22:03, Yann E. MORIN wrote: > Fabrice, All, > > On 2020-08-16 12:06 +0200, Fabrice Fontaine spake thusly: >> This will fix the following build failure: >> >> ../src/gstreamer/gstlibcameraallocator.cpp: In static member function 'static GQuark FrameWrap::getQuark()': >> /home/peko/autobuild/instance-1/output-1/host/x86_64-buildroot-linux-gnu/sysroot/usr/include/glib-2.0/glib/gatomic.h:128:15: error: variable 'gapg_temp_atomic' set but not used [-Werror=unused-but-set-variable] >> gpointer *gapg_temp_atomic = (gpointer *)(atomic); \ >> ^ >> >> Fixes: >> - http://autobuild.buildroot.org/results/c28500d4cc55fbd2bac87f2c11759ddc9163bc91 >> >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > Applied to master, thanks. > > Regards, > Yann E. MORIN. > >> --- >> package/libcamera/libcamera.mk | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk >> index 9739f715a1..34911cee79 100644 >> --- a/package/libcamera/libcamera.mk >> +++ b/package/libcamera/libcamera.mk >> @@ -15,7 +15,8 @@ LIBCAMERA_DEPENDENCIES = \ >> LIBCAMERA_CONF_OPTS = \ >> -Dandroid=false \ >> -Ddocumentation=false \ >> - -Dtest=false >> + -Dtest=false \ >> + -Dwerror=false >> LIBCAMERA_INSTALL_STAGING = YES >> LIBCAMERA_LICENSE = \ >> LGPL-2.1+ (library), \ >> -- >> 2.27.0 >> >> _______________________________________________ >> buildroot mailing list >> buildroot at busybox.net >> http://lists.busybox.net/mailman/listinfo/buildroot > -- Regards -- Kieran ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/libcamera: disable werror 2020-08-17 11:16 ` Kieran Bingham @ 2020-08-17 11:39 ` Fabrice Fontaine 0 siblings, 0 replies; 4+ messages in thread From: Fabrice Fontaine @ 2020-08-17 11:39 UTC (permalink / raw) To: buildroot Hi Kieran, Le lun. 17 ao?t 2020 ? 13:16, Kieran Bingham <kieran.bingham@ideasonboard.com> a ?crit : > > Hi Fabrice, > > Out of interest, have you investigated to see if this has been fixed or > reported in upstream glib? To my knowledge, the issue has not been fixed or reported. I don't really understand why we get this failure, gapg_temp_atomic has been added since version 2.63.1 and https://github.com/GNOME/glib/commit/3251cce524dbde48e0e5ea0df3169f76e10d0794. gapg_temp_atomic is set and then used in __atomic_load. > > This looks like an issue in the specific glib version rather than > libcamera, so IMO disabling -Werror is just a workaround ... a viable > one of course ... but not solving the underlying fault. > > Of course that is the peril of -Werror, we aim to keep warning free, but > the dependencies are out of our control so if they fail to do the same, > then that can cause these issues for packaging. > > Anyway the -Werror=false is only at the buildroot packaging, so we can > still aim to be warning clear in libcamera of course ;-) > > Thanks for keeping libcamera building successfully on buildroot! > > -- > Regards > > Kieran > > > On 16/08/2020 22:03, Yann E. MORIN wrote: > > Fabrice, All, > > > > On 2020-08-16 12:06 +0200, Fabrice Fontaine spake thusly: > >> This will fix the following build failure: > >> > >> ../src/gstreamer/gstlibcameraallocator.cpp: In static member function 'static GQuark FrameWrap::getQuark()': > >> /home/peko/autobuild/instance-1/output-1/host/x86_64-buildroot-linux-gnu/sysroot/usr/include/glib-2.0/glib/gatomic.h:128:15: error: variable 'gapg_temp_atomic' set but not used [-Werror=unused-but-set-variable] > >> gpointer *gapg_temp_atomic = (gpointer *)(atomic); \ > >> ^ > >> > >> Fixes: > >> - http://autobuild.buildroot.org/results/c28500d4cc55fbd2bac87f2c11759ddc9163bc91 > >> > >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > > > Applied to master, thanks. > > > > Regards, > > Yann E. MORIN. > > > >> --- > >> package/libcamera/libcamera.mk | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk > >> index 9739f715a1..34911cee79 100644 > >> --- a/package/libcamera/libcamera.mk > >> +++ b/package/libcamera/libcamera.mk > >> @@ -15,7 +15,8 @@ LIBCAMERA_DEPENDENCIES = \ > >> LIBCAMERA_CONF_OPTS = \ > >> -Dandroid=false \ > >> -Ddocumentation=false \ > >> - -Dtest=false > >> + -Dtest=false \ > >> + -Dwerror=false > >> LIBCAMERA_INSTALL_STAGING = YES > >> LIBCAMERA_LICENSE = \ > >> LGPL-2.1+ (library), \ > >> -- > >> 2.27.0 > >> > >> _______________________________________________ > >> buildroot mailing list > >> buildroot at busybox.net > >> http://lists.busybox.net/mailman/listinfo/buildroot > > > > -- > Regards > -- > Kieran Best Regards, Fabrice ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-17 11:39 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-08-16 10:06 [Buildroot] [PATCH 1/1] package/libcamera: disable werror Fabrice Fontaine 2020-08-16 21:03 ` Yann E. MORIN 2020-08-17 11:16 ` Kieran Bingham 2020-08-17 11:39 ` Fabrice Fontaine
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox