* [Buildroot] [PATCH 1/1] package/iprutils: fix build with gcc 4.8
@ 2020-08-18 19:12 Fabrice Fontaine
2020-08-18 20:11 ` Yann E. MORIN
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2020-08-18 19:12 UTC (permalink / raw)
To: buildroot
Fixes:
- http://autobuild.buildroot.org/results/41fde4aa06f7c025bb05aa594716643b9010358f
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
...gure.ac-add-AC_USE_SYSTEM_EXTENSIONS.patch | 44 +++++++++++++++++++
package/iprutils/iprutils.mk | 2 +
2 files changed, 46 insertions(+)
create mode 100644 package/iprutils/0001-configure.ac-add-AC_USE_SYSTEM_EXTENSIONS.patch
diff --git a/package/iprutils/0001-configure.ac-add-AC_USE_SYSTEM_EXTENSIONS.patch b/package/iprutils/0001-configure.ac-add-AC_USE_SYSTEM_EXTENSIONS.patch
new file mode 100644
index 0000000000..76085b4a3c
--- /dev/null
+++ b/package/iprutils/0001-configure.ac-add-AC_USE_SYSTEM_EXTENSIONS.patch
@@ -0,0 +1,44 @@
+From 068f37c100e105fd8edcae07762613e8e33c5282 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Tue, 18 Aug 2020 20:26:58 +0200
+Subject: [PATCH] configure.ac: add AC_USE_SYSTEM_EXTENSIONS
+
+Build with gcc 4.8 will raise two errors, one on uint, the other one on
+alphasort:
+
+In file included from iprdump.c:17:0:
+iprlib.h:1866:2: error: unknown type name 'uint'
+ uint supported_with_min_ucode_level;
+ ^
+
+iprlib.c: In function 'ipr_get_pci_slots':
+iprlib.c:1999:48: error: 'alphasort' undeclared (first use in this function)
+ num_slots = scandir(rootslot, &slotdir, NULL, alphasort);
+ ^
+
+Fix them by adding AC_USE_SYSTEM_EXTENSIONS in configure.ac
+
+Fixes:
+ - http://autobuild.buildroot.org/results/41fde4aa06f7c025bb05aa594716643b9010358f
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Upstream status: https://github.com/bjking1/iprutils/pull/4]
+---
+ configure.ac | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/configure.ac b/configure.ac
+index 462a8b5..7f5fa7d 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -14,6 +14,7 @@ AC_INIT([iprutils], [2.4.19.1], [iprdd-devel at lists.sourceforge.net])
+
+ AM_INIT_AUTOMAKE([1.9 foreign])
+ AC_CONFIG_MACRO_DIR([build-aux])
++AC_USE_SYSTEM_EXTENSIONS
+
+ # Checks for programs.
+ AC_PROG_CC
+--
+2.27.0
+
diff --git a/package/iprutils/iprutils.mk b/package/iprutils/iprutils.mk
index 3fa8223ff6..9595125ac9 100644
--- a/package/iprutils/iprutils.mk
+++ b/package/iprutils/iprutils.mk
@@ -10,5 +10,7 @@ IPRUTILS_SITE = https://downloads.sourceforge.net/project/iprdd/iprutils%20for%2
IPRUTILS_DEPENDENCIES = ncurses libsysfs pciutils zlib
IPRUTILS_LICENSE = Common Public License Version 1.0
IPRUTILS_LICENSE_FILES = LICENSE
+# We"re patching configure.ac
+IPRUTILS_AUTORECONF = YES
$(eval $(autotools-package))
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] package/iprutils: fix build with gcc 4.8
2020-08-18 19:12 [Buildroot] [PATCH 1/1] package/iprutils: fix build with gcc 4.8 Fabrice Fontaine
@ 2020-08-18 20:11 ` Yann E. MORIN
0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2020-08-18 20:11 UTC (permalink / raw)
To: buildroot
Fabrice, All,
On 2020-08-18 21:12 +0200, Fabrice Fontaine spake thusly:
> Fixes:
> - http://autobuild.buildroot.org/results/41fde4aa06f7c025bb05aa594716643b9010358f
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Issues are with glibc version, not gcc version, so I tweaked the patch'
commit and the commit log accordingly, and applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> ...gure.ac-add-AC_USE_SYSTEM_EXTENSIONS.patch | 44 +++++++++++++++++++
> package/iprutils/iprutils.mk | 2 +
> 2 files changed, 46 insertions(+)
> create mode 100644 package/iprutils/0001-configure.ac-add-AC_USE_SYSTEM_EXTENSIONS.patch
>
> diff --git a/package/iprutils/0001-configure.ac-add-AC_USE_SYSTEM_EXTENSIONS.patch b/package/iprutils/0001-configure.ac-add-AC_USE_SYSTEM_EXTENSIONS.patch
> new file mode 100644
> index 0000000000..76085b4a3c
> --- /dev/null
> +++ b/package/iprutils/0001-configure.ac-add-AC_USE_SYSTEM_EXTENSIONS.patch
> @@ -0,0 +1,44 @@
> +From 068f37c100e105fd8edcae07762613e8e33c5282 Mon Sep 17 00:00:00 2001
> +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Date: Tue, 18 Aug 2020 20:26:58 +0200
> +Subject: [PATCH] configure.ac: add AC_USE_SYSTEM_EXTENSIONS
> +
> +Build with gcc 4.8 will raise two errors, one on uint, the other one on
> +alphasort:
> +
> +In file included from iprdump.c:17:0:
> +iprlib.h:1866:2: error: unknown type name 'uint'
> + uint supported_with_min_ucode_level;
> + ^
> +
> +iprlib.c: In function 'ipr_get_pci_slots':
> +iprlib.c:1999:48: error: 'alphasort' undeclared (first use in this function)
> + num_slots = scandir(rootslot, &slotdir, NULL, alphasort);
> + ^
> +
> +Fix them by adding AC_USE_SYSTEM_EXTENSIONS in configure.ac
> +
> +Fixes:
> + - http://autobuild.buildroot.org/results/41fde4aa06f7c025bb05aa594716643b9010358f
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +[Upstream status: https://github.com/bjking1/iprutils/pull/4]
> +---
> + configure.ac | 1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/configure.ac b/configure.ac
> +index 462a8b5..7f5fa7d 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -14,6 +14,7 @@ AC_INIT([iprutils], [2.4.19.1], [iprdd-devel at lists.sourceforge.net])
> +
> + AM_INIT_AUTOMAKE([1.9 foreign])
> + AC_CONFIG_MACRO_DIR([build-aux])
> ++AC_USE_SYSTEM_EXTENSIONS
> +
> + # Checks for programs.
> + AC_PROG_CC
> +--
> +2.27.0
> +
> diff --git a/package/iprutils/iprutils.mk b/package/iprutils/iprutils.mk
> index 3fa8223ff6..9595125ac9 100644
> --- a/package/iprutils/iprutils.mk
> +++ b/package/iprutils/iprutils.mk
> @@ -10,5 +10,7 @@ IPRUTILS_SITE = https://downloads.sourceforge.net/project/iprdd/iprutils%20for%2
> IPRUTILS_DEPENDENCIES = ncurses libsysfs pciutils zlib
> IPRUTILS_LICENSE = Common Public License Version 1.0
> IPRUTILS_LICENSE_FILES = LICENSE
> +# We"re patching configure.ac
> +IPRUTILS_AUTORECONF = YES
>
> $(eval $(autotools-package))
> --
> 2.27.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-18 20:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-18 19:12 [Buildroot] [PATCH 1/1] package/iprutils: fix build with gcc 4.8 Fabrice Fontaine
2020-08-18 20:11 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox