* [Buildroot] [PATCH 1/1] package/dieharder: fix build with gcc 10 @ 2020-08-19 16:34 Fabrice Fontaine 2020-08-19 21:34 ` Yann E. MORIN 0 siblings, 1 reply; 4+ messages in thread From: Fabrice Fontaine @ 2020-08-19 16:34 UTC (permalink / raw) To: buildroot Disable -fno-common with dieharder, there is more than 100 variables to fix and upstream seems dead. Fixes: - http://autobuild.buildroot.org/results/ba70d111cd1f2029a193a88af3b44daf6ef27786 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/dieharder/dieharder.mk | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/package/dieharder/dieharder.mk b/package/dieharder/dieharder.mk index c3eee64553..cbf28922fd 100644 --- a/package/dieharder/dieharder.mk +++ b/package/dieharder/dieharder.mk @@ -36,4 +36,9 @@ endif # parallel build fail, disable it DIEHARDER_MAKE = $(MAKE1) +# Too many fixes needed to build with -fno-common which is default since gcc 10 +ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_10),y) +DIEHARDER_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -fcommon" +endif + $(eval $(autotools-package)) -- 2.27.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/dieharder: fix build with gcc 10 2020-08-19 16:34 [Buildroot] [PATCH 1/1] package/dieharder: fix build with gcc 10 Fabrice Fontaine @ 2020-08-19 21:34 ` Yann E. MORIN 2020-08-20 6:21 ` Julien Viard de Galbert 0 siblings, 1 reply; 4+ messages in thread From: Yann E. MORIN @ 2020-08-19 21:34 UTC (permalink / raw) To: buildroot Fabrice, All, On 2020-08-19 18:34 +0200, Fabrice Fontaine spake thusly: > Disable -fno-common with dieharder, there is more than 100 variables to > fix and upstream seems dead. > > Fixes: > - http://autobuild.buildroot.org/results/ba70d111cd1f2029a193a88af3b44daf6ef27786 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Initially, I was not very happy that we just papered over the problem, but this is too daunting to fix, and indeed upstream is not very well alive it seems: last release in 2011, no public VCS... It's a bit shamefull that we have a security-related package that is so old an unmaintained... :-( Applied to master, thanks. Regards, Yann E. MORIN. > --- > package/dieharder/dieharder.mk | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/package/dieharder/dieharder.mk b/package/dieharder/dieharder.mk > index c3eee64553..cbf28922fd 100644 > --- a/package/dieharder/dieharder.mk > +++ b/package/dieharder/dieharder.mk > @@ -36,4 +36,9 @@ endif > # parallel build fail, disable it > DIEHARDER_MAKE = $(MAKE1) > > +# Too many fixes needed to build with -fno-common which is default since gcc 10 > +ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_10),y) > +DIEHARDER_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -fcommon" > +endif > + > $(eval $(autotools-package)) > -- > 2.27.0 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/dieharder: fix build with gcc 10 2020-08-19 21:34 ` Yann E. MORIN @ 2020-08-20 6:21 ` Julien Viard de Galbert 2020-08-20 20:35 ` Yann E. MORIN 0 siblings, 1 reply; 4+ messages in thread From: Julien Viard de Galbert @ 2020-08-20 6:21 UTC (permalink / raw) To: buildroot On Wed, Aug 19, 2020 at 11:34:42PM +0200, Yann E. MORIN wrote: > Fabrice, All, Yann, Fabrice, All, > > On 2020-08-19 18:34 +0200, Fabrice Fontaine spake thusly: > > Disable -fno-common with dieharder, there is more than 100 variables to > > fix and upstream seems dead. > > > > Fixes: > > - http://autobuild.buildroot.org/results/ba70d111cd1f2029a193a88af3b44daf6ef27786 > > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > Initially, I was not very happy that we just papered over the problem, > but this is too daunting to fix, and indeed upstream is not very well > alive it seems: last release in 2011, no public VCS... It's a bit > shamefull that we have a security-related package that is so old an > unmaintained... :-( As I introduced the package a few years ago, I was wondering if we had a way to measure the usage of this package and think about removing it. Then I checked with the guardians of the temple aka debian and found that the maintainer probably fixed the gcc 10 issue: | dieharder (3.31.1.2-1) unstable; urgency=medium | | * New upstream minor release accomodating gcc-10 and its treatment of | multiple definitions of global variables (Closes: #957134) | | * Based on new 'upstream' git repo at github.com/eddelbuettel/dieharder | which spawned off the salsa.debian.org repo for this package | | -- Dirk Eddelbuettel <edd@debian.org> Sat, 25 Jul 2020 12:36:49 -0500 This would not be the first time that debian extended the life of unmaintained upstream. What do you think ? Regards, Julien VdG > > Applied to master, thanks. > > Regards, > Yann E. MORIN. > > > --- > > package/dieharder/dieharder.mk | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/package/dieharder/dieharder.mk b/package/dieharder/dieharder.mk > > index c3eee64553..cbf28922fd 100644 > > --- a/package/dieharder/dieharder.mk > > +++ b/package/dieharder/dieharder.mk > > @@ -36,4 +36,9 @@ endif > > # parallel build fail, disable it > > DIEHARDER_MAKE = $(MAKE1) > > > > +# Too many fixes needed to build with -fno-common which is default since gcc 10 > > +ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_10),y) > > +DIEHARDER_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -fcommon" > > +endif > > + > > $(eval $(autotools-package)) > > -- > > 2.27.0 > > > > _______________________________________________ > > buildroot mailing list > > buildroot at busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/dieharder: fix build with gcc 10 2020-08-20 6:21 ` Julien Viard de Galbert @ 2020-08-20 20:35 ` Yann E. MORIN 0 siblings, 0 replies; 4+ messages in thread From: Yann E. MORIN @ 2020-08-20 20:35 UTC (permalink / raw) To: buildroot Julien, All, On 2020-08-20 08:21 +0200, Julien Viard de Galbert spake thusly: [--SNIP--] > As I introduced the package a few years ago, I was wondering if we had a > way to measure the usage of this package and think about removing it. > Then I checked with the guardians of the temple aka debian and found > that the maintainer probably fixed the gcc 10 issue: > > | dieharder (3.31.1.2-1) unstable; urgency=medium > | > | * New upstream minor release accomodating gcc-10 and its treatment of > | multiple definitions of global variables (Closes: #957134) > | > | * Based on new 'upstream' git repo at github.com/eddelbuettel/dieharder > | which spawned off the salsa.debian.org repo for this package > | > | -- Dirk Eddelbuettel <edd@debian.org> Sat, 25 Jul 2020 12:36:49 -0500 > > This would not be the first time that debian extended the life of > unmaintained upstream. > > What do you think ? I would be OK with switching to the github repo, indeed. When you send the update patch, could you identify how much it has diverged from the original upstream, too, so we can assess if that can be considered for master (only bug fixes), or if it would go to next (if there are features). thanks for the heads up! :-) Regards, Yann E. MORIN. > Regards, > > Julien VdG > > > > > Applied to master, thanks. > > > > Regards, > > Yann E. MORIN. > > > > > --- > > > package/dieharder/dieharder.mk | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/package/dieharder/dieharder.mk b/package/dieharder/dieharder.mk > > > index c3eee64553..cbf28922fd 100644 > > > --- a/package/dieharder/dieharder.mk > > > +++ b/package/dieharder/dieharder.mk > > > @@ -36,4 +36,9 @@ endif > > > # parallel build fail, disable it > > > DIEHARDER_MAKE = $(MAKE1) > > > > > > +# Too many fixes needed to build with -fno-common which is default since gcc 10 > > > +ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_10),y) > > > +DIEHARDER_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -fcommon" > > > +endif > > > + > > > $(eval $(autotools-package)) > > > -- > > > 2.27.0 > > > > > > _______________________________________________ > > > buildroot mailing list > > > buildroot at busybox.net > > > http://lists.busybox.net/mailman/listinfo/buildroot > > > > -- > > .-----------------.--------------------.------------------.--------------------. > > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > > '------------------------------^-------^------------------^--------------------' -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-20 20:35 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-08-19 16:34 [Buildroot] [PATCH 1/1] package/dieharder: fix build with gcc 10 Fabrice Fontaine 2020-08-19 21:34 ` Yann E. MORIN 2020-08-20 6:21 ` Julien Viard de Galbert 2020-08-20 20:35 ` Yann E. MORIN
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox