From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/ripgrep: fix debug build
Date: Mon, 24 Aug 2020 11:05:00 +0200 [thread overview]
Message-ID: <20200824090500.GF10811@scaer> (raw)
In-Reply-To: <20200822182237.1834735-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2020-08-22 20:22 +0200, Fabrice Fontaine spake thusly:
> There is no --debug mode for cargo resulting in the following build
> failure since the addition of this package with commit
> 4b0d1ef6ac00c5170a3fb9d15d06b3d3172e0c97:
>
> error: Unknown flag: '--debug'
>
> Fixes:
> - http://autobuild.buildroot.org/results/58e74bb056ec65680ecebaa559aa14bdebbf5c85
> - http://autobuild.buildroot.org/results/28c6364a89a6044d5a036614f7a6e59815efb770
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, but keeping the default 'dev' mode when in debug, as
discussed in the thread, and confirmed by Sam. Thanks.
Regards,
Yann E. MORIN.
> ---
> package/ripgrep/ripgrep.mk | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/package/ripgrep/ripgrep.mk b/package/ripgrep/ripgrep.mk
> index 832c076f26..ac9038945c 100644
> --- a/package/ripgrep/ripgrep.mk
> +++ b/package/ripgrep/ripgrep.mk
> @@ -11,12 +11,11 @@ RIPGREP_LICENSE_FILES = LICENSE-MIT
>
> RIPGREP_DEPENDENCIES = host-rustc
> RIPGREP_CARGO_ENV = CARGO_HOME=$(HOST_DIR)/share/cargo
> -RIPGREP_CARGO_MODE = $(if $(BR2_ENABLE_DEBUG),debug,release)
>
> RIPGREP_BIN_DIR = target/$(RUSTC_TARGET_NAME)/$(RIPGREP_CARGO_MODE)
>
> RIPGREP_CARGO_OPTS = \
> - --$(RIPGREP_CARGO_MODE) \
> + --release \
> --target=$(RUSTC_TARGET_NAME) \
> --manifest-path=$(@D)/Cargo.toml
>
> --
> 2.28.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-08-24 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-22 18:22 [Buildroot] [PATCH 1/1] package/ripgrep: fix debug build Fabrice Fontaine
2020-08-23 19:39 ` Yann E. MORIN
2020-08-24 2:42 ` Sam Voss
2020-08-24 9:05 ` Yann E. MORIN [this message]
2020-08-28 17:09 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824090500.GF10811@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox