Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/ripgrep: fix debug build
@ 2020-08-22 18:22 Fabrice Fontaine
  2020-08-23 19:39 ` Yann E. MORIN
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2020-08-22 18:22 UTC (permalink / raw)
  To: buildroot

There is no --debug mode for cargo resulting in the following build
failure since the addition of this package with commit
4b0d1ef6ac00c5170a3fb9d15d06b3d3172e0c97:

error: Unknown flag: '--debug'

Fixes:
 - http://autobuild.buildroot.org/results/58e74bb056ec65680ecebaa559aa14bdebbf5c85
 - http://autobuild.buildroot.org/results/28c6364a89a6044d5a036614f7a6e59815efb770

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/ripgrep/ripgrep.mk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/package/ripgrep/ripgrep.mk b/package/ripgrep/ripgrep.mk
index 832c076f26..ac9038945c 100644
--- a/package/ripgrep/ripgrep.mk
+++ b/package/ripgrep/ripgrep.mk
@@ -11,12 +11,11 @@ RIPGREP_LICENSE_FILES = LICENSE-MIT
 
 RIPGREP_DEPENDENCIES = host-rustc
 RIPGREP_CARGO_ENV = CARGO_HOME=$(HOST_DIR)/share/cargo
-RIPGREP_CARGO_MODE = $(if $(BR2_ENABLE_DEBUG),debug,release)
 
 RIPGREP_BIN_DIR = target/$(RUSTC_TARGET_NAME)/$(RIPGREP_CARGO_MODE)
 
 RIPGREP_CARGO_OPTS = \
-	--$(RIPGREP_CARGO_MODE) \
+	--release \
 	--target=$(RUSTC_TARGET_NAME) \
 	--manifest-path=$(@D)/Cargo.toml
 
-- 
2.28.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/ripgrep: fix debug build
  2020-08-22 18:22 [Buildroot] [PATCH 1/1] package/ripgrep: fix debug build Fabrice Fontaine
@ 2020-08-23 19:39 ` Yann E. MORIN
  2020-08-24  2:42   ` Sam Voss
  2020-08-24  9:05 ` Yann E. MORIN
  2020-08-28 17:09 ` Peter Korsgaard
  2 siblings, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2020-08-23 19:39 UTC (permalink / raw)
  To: buildroot

Fabrice, All,

Question for a cargo expert! See below!

On 2020-08-22 20:22 +0200, Fabrice Fontaine spake thusly:
> There is no --debug mode for cargo resulting in the following build
> failure since the addition of this package with commit
> 4b0d1ef6ac00c5170a3fb9d15d06b3d3172e0c97:
> 
> error: Unknown flag: '--debug'
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/58e74bb056ec65680ecebaa559aa14bdebbf5c85
>  - http://autobuild.buildroot.org/results/28c6364a89a6044d5a036614f7a6e59815efb770
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/ripgrep/ripgrep.mk | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/package/ripgrep/ripgrep.mk b/package/ripgrep/ripgrep.mk
> index 832c076f26..ac9038945c 100644
> --- a/package/ripgrep/ripgrep.mk
> +++ b/package/ripgrep/ripgrep.mk
> @@ -11,12 +11,11 @@ RIPGREP_LICENSE_FILES = LICENSE-MIT
>  
>  RIPGREP_DEPENDENCIES = host-rustc
>  RIPGREP_CARGO_ENV = CARGO_HOME=$(HOST_DIR)/share/cargo
> -RIPGREP_CARGO_MODE = $(if $(BR2_ENABLE_DEBUG),debug,release)
>  
>  RIPGREP_BIN_DIR = target/$(RUSTC_TARGET_NAME)/$(RIPGREP_CARGO_MODE)
>  
>  RIPGREP_CARGO_OPTS = \
> -	--$(RIPGREP_CARGO_MODE) \
> +	--release \

Wouldn't we need to pass --release only when in non-debug builds, i.e:

    $(if $(BR2_ENABLE_DEBUG),,--release)

Regards,
Yann E. MORIN.

>  	--target=$(RUSTC_TARGET_NAME) \
>  	--manifest-path=$(@D)/Cargo.toml
>  
> -- 
> 2.28.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/ripgrep: fix debug build
  2020-08-23 19:39 ` Yann E. MORIN
@ 2020-08-24  2:42   ` Sam Voss
  0 siblings, 0 replies; 5+ messages in thread
From: Sam Voss @ 2020-08-24  2:42 UTC (permalink / raw)
  To: buildroot

Yann, Fabrice,

On Sun, Aug 23, 2020 at 2:39 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> Fabrice, All,
>
> Question for a cargo expert! See below!
>
> On 2020-08-22 20:22 +0200, Fabrice Fontaine spake thusly:
> > There is no --debug mode for cargo resulting in the following build
> > failure since the addition of this package with commit
> > 4b0d1ef6ac00c5170a3fb9d15d06b3d3172e0c97:

This also seems to be visible in the manual, in the cargo-based
package section. The example manual text will need to be updated to
avoid this issue for new packages.

> >
> > error: Unknown flag: '--debug'
> >
> > Fixes:
> >  - http://autobuild.buildroot.org/results/58e74bb056ec65680ecebaa559aa14bdebbf5c85
> >  - http://autobuild.buildroot.org/results/28c6364a89a6044d5a036614f7a6e59815efb770
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/ripgrep/ripgrep.mk | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/package/ripgrep/ripgrep.mk b/package/ripgrep/ripgrep.mk
> > index 832c076f26..ac9038945c 100644
> > --- a/package/ripgrep/ripgrep.mk
> > +++ b/package/ripgrep/ripgrep.mk
> > @@ -11,12 +11,11 @@ RIPGREP_LICENSE_FILES = LICENSE-MIT
> >
> >  RIPGREP_DEPENDENCIES = host-rustc
> >  RIPGREP_CARGO_ENV = CARGO_HOME=$(HOST_DIR)/share/cargo
> > -RIPGREP_CARGO_MODE = $(if $(BR2_ENABLE_DEBUG),debug,release)
> >
> >  RIPGREP_BIN_DIR = target/$(RUSTC_TARGET_NAME)/$(RIPGREP_CARGO_MODE)
> >
> >  RIPGREP_CARGO_OPTS = \
> > -     --$(RIPGREP_CARGO_MODE) \
> > +     --release \
>
> Wouldn't we need to pass --release only when in non-debug builds, i.e:
>
>     $(if $(BR2_ENABLE_DEBUG),,--release)

This seems more than reasonable, however as this patch is likely
coming in before the cargo-restructuring[1] patchset, so we should
make sure it also works its way back into those patches.

FWIW I agree it should leave the debug/release logic, so that it's
possible to enable the debug symbols (most notably not build the
'release' profile instead of the default 'dev' profile[2]). I think
for now we should just "set nothing" in the debug case and let the
"dev" profile take over, and someday somebody may wish to make it more
robust by setting the correct[3] debug flags when appropriate.

Thanks for looking at this!

Sam

1: https://patchwork.ozlabs.org/project/buildroot/patch/20200220160119.3407-1-patrick.havelange at essensium.com/
2: https://doc.rust-lang.org/cargo/reference/profiles.html#release
3: https://doc.rust-lang.org/cargo/reference/profiles.html#debug

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/ripgrep: fix debug build
  2020-08-22 18:22 [Buildroot] [PATCH 1/1] package/ripgrep: fix debug build Fabrice Fontaine
  2020-08-23 19:39 ` Yann E. MORIN
@ 2020-08-24  9:05 ` Yann E. MORIN
  2020-08-28 17:09 ` Peter Korsgaard
  2 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2020-08-24  9:05 UTC (permalink / raw)
  To: buildroot

Fabrice, All,

On 2020-08-22 20:22 +0200, Fabrice Fontaine spake thusly:
> There is no --debug mode for cargo resulting in the following build
> failure since the addition of this package with commit
> 4b0d1ef6ac00c5170a3fb9d15d06b3d3172e0c97:
> 
> error: Unknown flag: '--debug'
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/58e74bb056ec65680ecebaa559aa14bdebbf5c85
>  - http://autobuild.buildroot.org/results/28c6364a89a6044d5a036614f7a6e59815efb770
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, but keeping the default 'dev' mode when in debug, as
discussed in the thread, and confirmed by Sam. Thanks.

Regards,
Yann E. MORIN.

> ---
>  package/ripgrep/ripgrep.mk | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/package/ripgrep/ripgrep.mk b/package/ripgrep/ripgrep.mk
> index 832c076f26..ac9038945c 100644
> --- a/package/ripgrep/ripgrep.mk
> +++ b/package/ripgrep/ripgrep.mk
> @@ -11,12 +11,11 @@ RIPGREP_LICENSE_FILES = LICENSE-MIT
>  
>  RIPGREP_DEPENDENCIES = host-rustc
>  RIPGREP_CARGO_ENV = CARGO_HOME=$(HOST_DIR)/share/cargo
> -RIPGREP_CARGO_MODE = $(if $(BR2_ENABLE_DEBUG),debug,release)
>  
>  RIPGREP_BIN_DIR = target/$(RUSTC_TARGET_NAME)/$(RIPGREP_CARGO_MODE)
>  
>  RIPGREP_CARGO_OPTS = \
> -	--$(RIPGREP_CARGO_MODE) \
> +	--release \
>  	--target=$(RUSTC_TARGET_NAME) \
>  	--manifest-path=$(@D)/Cargo.toml
>  
> -- 
> 2.28.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/ripgrep: fix debug build
  2020-08-22 18:22 [Buildroot] [PATCH 1/1] package/ripgrep: fix debug build Fabrice Fontaine
  2020-08-23 19:39 ` Yann E. MORIN
  2020-08-24  9:05 ` Yann E. MORIN
@ 2020-08-28 17:09 ` Peter Korsgaard
  2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2020-08-28 17:09 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > There is no --debug mode for cargo resulting in the following build
 > failure since the addition of this package with commit
 > 4b0d1ef6ac00c5170a3fb9d15d06b3d3172e0c97:

 > error: Unknown flag: '--debug'

 > Fixes:
 >  - http://autobuild.buildroot.org/results/58e74bb056ec65680ecebaa559aa14bdebbf5c85
 >  - http://autobuild.buildroot.org/results/28c6364a89a6044d5a036614f7a6e59815efb770

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2020.02.x and 2020.05.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-28 17:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-22 18:22 [Buildroot] [PATCH 1/1] package/ripgrep: fix debug build Fabrice Fontaine
2020-08-23 19:39 ` Yann E. MORIN
2020-08-24  2:42   ` Sam Voss
2020-08-24  9:05 ` Yann E. MORIN
2020-08-28 17:09 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox