Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] docs/manual/adding-packages-cargo.txt: drop debug profile
Date: Mon, 24 Aug 2020 11:06:57 +0200	[thread overview]
Message-ID: <20200824090657.GG10811@scaer> (raw)
In-Reply-To: <20200824070901.815730-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2020-08-24 09:09 +0200, Fabrice Fontaine spake thusly:
> There is no debug profile on cargo. The available profiles are: dev
> (enabled by default), release, test and bench.
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  docs/manual/adding-packages-cargo.txt | 41 +++++++++++++--------------
>  1 file changed, 20 insertions(+), 21 deletions(-)
> 
> diff --git a/docs/manual/adding-packages-cargo.txt b/docs/manual/adding-packages-cargo.txt
> index bb078b6981..8fcc80bcc6 100644
> --- a/docs/manual/adding-packages-cargo.txt
> +++ b/docs/manual/adding-packages-cargo.txt
> @@ -47,32 +47,31 @@ package. Let's start with an example:
>  13: FOO_DEPENDENCIES = host-rustc
>  14:
>  15: FOO_CARGO_ENV = CARGO_HOME=$(HOST_DIR)/share/cargo
> -16: FOO_CARGO_MODE = $(if $(BR2_ENABLE_DEBUG),debug,release)
> -17:
> -18: FOO_BIN_DIR = target/$(RUSTC_TARGET_NAME)/$(FOO_CARGO_MODE)
> -19:
> -20: FOO_CARGO_OPTS = \
> -21:   --$(FOO_CARGO_MODE) \
> -22: 	--target=$(RUSTC_TARGET_NAME) \
> -23: 	--manifest-path=$(@D)/Cargo.toml
> -24:
> -25: define FOO_BUILD_CMDS
> -26: 	$(TARGET_MAKE_ENV) $(FOO_CARGO_ENV) \
> -27: 		cargo build $(FOO_CARGO_OPTS)
> -28: endef
> -29:
> -30: define FOO_INSTALL_TARGET_CMDS
> -31: 	$(INSTALL) -D -m 0755 $(@D)/$(FOO_BIN_DIR)/foo \
> -32: 		$(TARGET_DIR)/usr/bin/foo
> -33: endef
> -34:
> -35: $(eval $(generic-package))
> +16:
> +17: FOO_BIN_DIR = target/$(RUSTC_TARGET_NAME)/$(FOO_CARGO_MODE)
> +18:
> +19: FOO_CARGO_OPTS = \
> +20: 	$(if $(BR2_ENABLE_DEBUG),,--release) \
> +21: 	--target=$(RUSTC_TARGET_NAME) \
> +22: 	--manifest-path=$(@D)/Cargo.toml
> +23:
> +24: define FOO_BUILD_CMDS
> +25: 	$(TARGET_MAKE_ENV) $(FOO_CARGO_ENV) \
> +26: 		cargo build $(FOO_CARGO_OPTS)
> +27: endef
> +28:
> +29: define FOO_INSTALL_TARGET_CMDS
> +30: 	$(INSTALL) -D -m 0755 $(@D)/$(FOO_BIN_DIR)/foo \
> +31: 		$(TARGET_DIR)/usr/bin/foo
> +32: endef
> +33:
> +34: $(eval $(generic-package))
>  --------------------------------
>  
>  The Makefile starts with the definition of the standard variables for package
>  declaration (lines 7 to 11).
>  
> -As seen in line 35, it is based on the
> +As seen in line 34, it is based on the
>  xref:generic-package-tutorial[+generic-package+ infrastructure]. So, it defines
>  the variables required by this particular infrastructure, where Cargo is
>  invoked:
> -- 
> 2.28.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-08-24  9:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24  7:09 [Buildroot] [PATCH 1/1] docs/manual/adding-packages-cargo.txt: drop debug profile Fabrice Fontaine
2020-08-24  9:06 ` Yann E. MORIN [this message]
2020-08-28 17:08 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200824090657.GG10811@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox